[Bug 525046] New: freeradius-client-1.1.6-41.11: 2 * memory leak
http://bugzilla.novell.com/show_bug.cgi?id=525046 Summary: freeradius-client-1.1.6-41.11: 2 * memory leak Classification: openSUSE Product: openSUSE 11.2 Version: Factory Platform: All OS/Version: openSUSE 11.1 Status: NEW Severity: Normal Priority: P5 - None Component: Other AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: dcb314@hotmail.com QAContact: qa@suse.de Found By: --- I just had a look at factory package freeradius-client-1.1.6-41.11 For source code file freeradius-client-1.1.6/lib/config.c around line 320 is the source code for the function rc_config_init. I notice the following code authservers = malloc(sizeof(SERVER)); acctservers = malloc(sizeof(SERVER)); but no corresponding matching calls to free. This looks like a memory leak to me. Suggest add calls to free to close the leak. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=525046
Marcus Meissner
http://bugzilla.novell.com/show_bug.cgi?id=525046
User puzel@novell.com added comment
http://bugzilla.novell.com/show_bug.cgi?id=525046#c1
Petr Uzel
http://bugzilla.novell.com/show_bug.cgi?id=525046
User dcb314@hotmail.com added comment
http://bugzilla.novell.com/show_bug.cgi?id=525046#c2
David Binderman
I believe the memory is freed properly in rc_config_free(). I might be wrong, so if you still think there is a memory leak, please report it directly to freeradius upstream. Thanks
You may have that belief, but I fail to find any supporting evidence for it. I would recommend further examination of this problem. A few seconds spent examining the source code would suggest that authservers and acctservers fields are filled in then ignored, since rh is returned. Not only does it appear to me to be a memory leak, it looks like dead code too. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=525046
User puzel@novell.com added comment
http://bugzilla.novell.com/show_bug.cgi?id=525046#c3
Petr Uzel
http://bugzilla.novell.com/show_bug.cgi?id=525046
User dcb314@hotmail.com added comment
http://bugzilla.novell.com/show_bug.cgi?id=525046#c4
--- Comment #4 from David Binderman
Apologies, David - you are right that there is a memory leak.
By the first reading, I somehow followed the intention of the author and not the actual code...
Would you be so kind to report the bug upstream?
Thank you for your most generous apology. I myself had also made the mistake of not properly reading code. However. the freeradius project is unknown to me, and I'd like to keep it that way. Am I correct in thinking that someone in the OpenSuse or Novell organisations already has a suitable account with the freeradius folks to file this bug report ? They appear to be the person best placed to file this bug report upstream. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=525046
User puzel@novell.com added comment
http://bugzilla.novell.com/show_bug.cgi?id=525046#c5
Petr Uzel
participants (1)
-
bugzilla_noreply@novell.com