[Bug 537468] New: apache2-2.2.13-1.3: memory leak
http://bugzilla.novell.com/show_bug.cgi?id=537468 Summary: apache2-2.2.13-1.3: memory leak Classification: openSUSE Product: openSUSE 11.2 Version: Factory Platform: All OS/Version: openSUSE 11.1 Status: NEW Severity: Normal Priority: P5 - None Component: Apache AssignedTo: bnc-team-apache@forge.provo.novell.com ReportedBy: dcb314@hotmail.com QAContact: qa@suse.de Found By: --- I just had a look at factory package apache2-2.2.13-1.3 For source code file httpd-2.2.13/modules/ssl/ssl_scache_dbm.c around line 240, function ssl_scache_dbm_retrieve is the following code ucpData = malloc(nData); and later is if (expiry <= now) { ssl_scache_dbm_remove(s, id, idlen); return NULL; } so ucpData is not freed if the function returns NULL. This looks like a memory leak to me. Suggest call free inside the if. if (expiry <= now) { ssl_scache_dbm_remove(s, id, idlen); free( ucpData); return NULL; } -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=537468 User pat@indy.rr.com added comment http://bugzilla.novell.com/show_bug.cgi?id=537468#c1 --- Comment #1 from patrick shanahan <pat@indy.rr.com> 2009-09-24 20:55:05 MDT --- Last nite my apache2 server stopped: cat /var/log/apache2/error_log [Thu Sep 24 00:17:01 2009] [notice] seg fault or similar nasty error detected in the parent process 16:09 wahoo:~ # rcapache2 start Starting httpd2 (prefork) failed dmesg: [14891.859160] httpd2-prefork[11030]: segfault at 8 ip 00007f216093c09d sp 00007fff3e55b648 error 4 in mod_php5.so[7f21606fc000+2a8000] disabling php5 apache2 module allows the server to start apache2-2.2.13-1.6.x86_64 apache2-mod_php5-5.3.0-1.2.x86_64 apache2-prefork-2.2.13-1.6.x86_64 apache2-worker-2.2.13-1.6.x86_64 php5-5.3.0-1.2.x86_64 -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=537468 User rguenther@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=537468#c2 --- Comment #2 from Richard Guenther <rguenther@novell.com> 2009-10-17 08:55:23 MDT --- David, in case the issues are not introduced by a patch local to openSUSE please report the issues upstream. Packagers, please do not add openSUSE-local patches to fix this kind of errors but forward the bugs upstream and close the bugs as RESOLVED UPSTREAM. Note that it is perfectly fine to have "resource leaks" at the end of a program as the kernel will clean up for you. Manually freeing them only increases binary size and runtime. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=537468 https://bugzilla.novell.com/show_bug.cgi?id=537468#c3 Roman Drahtmueller <draht@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |draht@novell.com AssignedTo|bnc-team-apache@forge.provo |mvyskocil@novell.com |.novell.com | --- Comment #3 from Roman Drahtmueller <draht@novell.com> 2010-11-11 16:29:02 UTC --- I assume that the apache2-crash in mod_php5 is unrelated to the memory leak, but rather to package php5 containing apache's mod_php5. The memory leak seems obvious, though. I'll try to get this forwarded upstream. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=537468 https://bugzilla.novell.com/show_bug.cgi?id=537468#c4 --- Comment #4 from Roman Drahtmueller <draht@novell.com> 2010-11-11 16:35:37 UTC --- Nice spotting, btw. Patrick, have you tried to get the patch upstreamed as you suggest it? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=537468 https://bugzilla.novell.com/show_bug.cgi?id=537468#c5 --- Comment #5 from patrick shanahan <pat@indy.rr.com> 2010-11-11 16:54:03 UTC --- No, but iirc, I changed version of mod_php5 and locked the package in zypper for some period and have since removed the lock and updated. Currently: 11:51 wahoo:~ # rpm -q --last apache2 apache2-mod_php5 apache2-prefork apache2-worker php5 apache2-mod_php5-5.3.3_svn201011020214-37.1 Tue Nov 2 09:02:07 2010 php5-5.3.3_svn201011020214-37.1 Tue Nov 2 09:01:50 2010 apache2-prefork-2.2.17-25.1 Thu Oct 21 19:34:07 2010 apache2-2.2.17-25.1 Thu Oct 21 19:34:04 2010 apache2-worker is not installed I have not had the problem since. tks, -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=537468 https://bugzilla.novell.com/show_bug.cgi?id=537468#c6 Michal Vyskocil <mvyskocil@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO InfoProvider| |pat@indy.rr.com --- Comment #6 from Michal Vyskocil <mvyskocil@novell.com> 2010-11-12 08:58:33 UTC --- OK, then this bug should be closed, right? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=537468 https://bugzilla.novell.com/show_bug.cgi?id=537468#c7 patrick shanahan <pat@indy.rr.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |NEW InfoProvider|pat@indy.rr.com | --- Comment #7 from patrick shanahan <pat@indy.rr.com> 2010-11-12 17:51:15 UTC --- If the comment is directed to me, I would have to defer to the original reporter, David Binderman <dcb314@hotmail.com>. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=537468 https://bugzilla.novell.com/show_bug.cgi?id=537468#c8 Michal Vyskocil <mvyskocil@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #8 from Michal Vyskocil <mvyskocil@novell.com> 2010-11-15 09:23:46 UTC --- No, the missing leak is not important for downstream - such bugs have to be fixed in upstream. On the other hand you reported in comment#1 some crash and in comment#5 you reported this already disappeared. I wanted to be sure - anyway I expect this is already fixed, so closing it. If not, please reopen. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com