[Bug 716766] New: Software Manager: finds files which does not exist
https://bugzilla.novell.com/show_bug.cgi?id=716766 https://bugzilla.novell.com/show_bug.cgi?id=716766#c0 Summary: Software Manager: finds files which does not exist Classification: openSUSE Product: openSUSE 11.4 Version: Final Platform: x86-64 OS/Version: Other Status: NEW Severity: Normal Priority: P5 - None Component: YaST2 AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: bluedzins@wp.pl QAContact: jsrain@suse.com Found By: --- Blocker: --- Install package "scala". In SM select in "search for" section: * File list Now search for: scala-compiler.jar SM will show that scala package matches the search criteria. Nic, the only problem is, there is no such file in the list. But now there is a kicker! Search for: kde In SM deselect in "search for" section ALL options! Now search for: scala-compiler.jar You will get scala. How on Earth is it possible to match anything, if you turned off all criteria, i.e. no matching is possible at all? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=716766
https://bugzilla.novell.com/show_bug.cgi?id=716766#c
zj jia
https://bugzilla.novell.com/show_bug.cgi?id=716766
https://bugzilla.novell.com/show_bug.cgi?id=716766#c2
Thomas Göttlicher
Install package "scala".
In SM select in "search for" section: * File list
Now search for: scala-compiler.jar
SM will show that scala package matches the search criteria. Nic, the only problem is, there is no such file in the list. The package scale contains a file called /usr/share/scala/lib/scala-compiler.jar. That's the reason why the search result is correct.
But now there is a kicker! Search for: kde
In SM deselect in "search for" section ALL options!
Now search for: scala-compiler.jar
You will get scala. How on Earth is it possible to match anything, if you turned off all criteria, i.e. no matching is possible at all?
The called zypp functions that lead to this result are: zypp::PoolQuery query; query.addKind(zypp::ResKind::package); query.setCaseSensitive( _caseSensitive->isChecked() ); query.addString( searchtext ); See YQPkgSearchFilterView::filter() in http://svn.opensuse.org/svn/yast/trunk/qt-pkg/src/YQPkgSearchFilterView.cc zypp-maintainers, can you explain why zypp returns results in this case even if query.addAttribute( zypp::sat::SolvAttr::filelist ) is NOT set? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=716766
https://bugzilla.novell.com/show_bug.cgi?id=716766#c3
Duncan Mac-Vicar
https://bugzilla.novell.com/show_bug.cgi?id=716766
https://bugzilla.novell.com/show_bug.cgi?id=716766#c4
--- Comment #4 from Maciej Pilichowski
https://bugzilla.novell.com/show_bug.cgi?id=716766
https://bugzilla.novell.com/show_bug.cgi?id=716766#c5
--- Comment #5 from Thomas Göttlicher
"Just the user" says -- please find "java-compiler.jar" in this list, you can use your favorite tool. Note, I didn't made this list up, this is what yast shows (2.8.1-1.2). Here it is:
The initial report doesn't say "java-compiler.jar" but "scala-compiler.jar".
rpm -ql scala | grep -i 'scala-compiler.jar' /usr/share/scala/lib/scala-compiler.jar
-- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=716766
https://bugzilla.novell.com/show_bug.cgi?id=716766#c6
--- Comment #6 from Maciej Pilichowski
https://bugzilla.novell.com/show_bug.cgi?id=716766
https://bugzilla.novell.com/show_bug.cgi?id=716766#c7
--- Comment #7 from Thomas Göttlicher
My mistake in comment #4, it should be "scala-compiler.jar" not "java...".
Yast/SM finds something which is not there (of course it can be other way -- it shows incorrect file list). Anyway, the outcome should be consistent and currently it is not the case.
(Above is the output from Yast/SM not rpm.) The packages selector trims the file list if it's too long for performance reasons.
-- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=716766
https://bugzilla.novell.com/show_bug.cgi?id=716766#c8
Michael Andres
Probably this:
// If no attributes defined at all, then add 'query all' if ( _attrMatchList.empty() ) {
(in PoolQuery)
That explains the second case. Confusing yes, but should be not hard to fix.
That's no bug. If you say "Search for 'foo' in all packages" it will search for 'foo' in (all attributes of) all packages. If you say 'just in the filelist' it will search just in the filelist. Why would someone want to search nowhere? Isn't it easier not to search at all then. IMO either UI job or WONTFIX. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=716766
https://bugzilla.novell.com/show_bug.cgi?id=716766#c9
Thomas Göttlicher
Why would someone want to search nowhere? Isn't it easier not to search at all then. Good point.
IMO either UI job or WONTFIX.
I agree. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=716766
https://bugzilla.novell.com/show_bug.cgi?id=716766#c10
Maciej Pilichowski
Why would someone want to search nowhere? Isn't it easier not to search at all then.
Exactly my point. Not only easier is not to search, but searching does not make any sense. I am glad you agreed with me. However, Yast _IS_ searching, so reopening. (and btw. due to those mysterious "performance reasons" which keep Yast from showing entire list of files, the search should be blocked for sure, because searching is waayyy slower than displaying the file list). I rephrase (just in case) -- any search with invalid/incorrect options should be disabled, because garbage at input -> garbage at output. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=716766
https://bugzilla.novell.com/show_bug.cgi?id=716766#c11
Thomas Göttlicher
Why would someone want to search nowhere? Isn't it easier not to search at all then.
Exactly my point. Not only easier is not to search, but searching does not make any sense. I am glad you agreed with me.
However, Yast _IS_ searching, so reopening.
(and btw. due to those mysterious "performance reasons" which keep Yast from showing entire list of files, the search should be blocked for sure, because searching is waayyy slower than displaying the file list). Try yast2-qt-pkg older than 2.18.3 and you will find out that long (>500 lines) file lists make switching tabs slow.
I rephrase (just in case) -- any search with invalid/incorrect options should be disabled, because garbage at input -> garbage at output.
In my option it doesn't make sense to disable the search if no checkbox has been selected. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=716766
https://bugzilla.novell.com/show_bug.cgi?id=716766#c12
--- Comment #12 from Maciej Pilichowski
https://bugzilla.novell.com/show_bug.cgi?id=716766
https://bugzilla.novell.com/show_bug.cgi?id=716766#c13
--- Comment #13 from Thomas Göttlicher
So it makes sense to wait for invalid search, but it does not make sense to wait for a tab (despite filling list can be done asynchronously or with unfold button) and despite the fact checking the list is a valid operation, and searching with invalid options is not? You are right it doesn't make sense to wait some minutes for a long file list.
When the search is invalid what is the point of doing it? Can you explain how this can be useful? It is quite clear the user made a mistake. If the user decides not to specify any search option he/she doesn't care what is searched for he/she just wants results. That's the reason why it makes sense to search for everything just to present any packages that might fit his/her expectation.
-- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=716766
https://bugzilla.novell.com/show_bug.cgi?id=716766#c14
--- Comment #14 from Maciej Pilichowski
If the user decides not to specify any search option he/she doesn't care what is searched for he/she just wants results.
Thomas, please, show me the data. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com