[Bug 891065] New: [yast2-core] stdio agents do not know the target root
https://bugzilla.novell.com/show_bug.cgi?id=891065 https://bugzilla.novell.com/show_bug.cgi?id=891065#c0 Summary: [yast2-core] stdio agents do not know the target root Classification: openSUSE Product: openSUSE Factory Version: 201408* Platform: Other OS/Version: SLES 12 Status: ASSIGNED Severity: Major Priority: P5 - None Component: YaST2 AssignedTo: mvidner@suse.com ReportedBy: mvidner@suse.com QAContact: jsrain@suse.com CC: jsuchome@suse.com Found By: --- Blocker: --- +++ This bug was initially created as a clone of Bug #879365 +++ The original bug turned out to be caused by something else, so creating this one instead. During the installation we call Yast::WFM.SCROpen("chroot=/mnt:scr", ...) to let many SCR agents operate on the system being installed rather than the inst-sys. This works in cases where the agents are implemented in C++ and can query the main SCR objects about the target root. But the agents that are separate processes communicating via stdio, there is no interface to know the target root. I have added logging to determine the actual impact of this, and during a default installation of SLE12, one agent is affected: ag_uid, used at 2 places in UsersCache.pm https://github.com/yast/yast-users/blob/b83a66a0c6f5bce424e46c8f5a713b79d188... https://github.com/yast/yast-users/blob/b83a66a0c6f5bce424e46c8f5a713b79d188... We need to add the missing interface so that such agents in add-ons can work. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=891065 https://bugzilla.novell.com/show_bug.cgi?id=891065#c1 Martin Vidner <mvidner@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - None |P2 - High CC| |jreidinger@suse.com --- Comment #1 from Martin Vidner <mvidner@suse.com> 2014-08-08 15:18:24 CEST --- My proposed fix is to extend the agent initialization protocol. Current state: Before YaST starts sending SCR commands to the agent, it initializes it, passing it the arguments of the initialization term. That is, if we have --- foo.scr --- .foo `ag_foo(`File("/etc/foo"), `File("/etc/bar")) --- then, assuming ag_foo is implemented in a separate process, SCR.Read(path(".foo.hello")) will result in YaST running ag_foo and sending it `File("/etc/foo") `File("/etc/bar") `Read(.hello) Note that all existing agents have zero or one initialization term, not two like here. Proposed fix: After sending the initialization commands, before sending the SCR commands, send a `SetRoot(string) command to inform the agent of the root it should operate on. I have checked that ag_uid logs this command as unknown but does not crash. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=891065 https://bugzilla.novell.com/show_bug.cgi?id=891065#c2 --- Comment #2 from Martin Vidner <mvidner@suse.com> 2014-08-08 17:10:52 CEST --- Git: https://github.com/yast/yast-core/pull/77 RPM: yast2-core-3.1.8 OBS: https://build.opensuse.org/request/show/243986 Unfortunately the SLE build fails while testing ag_any on run_df: http://river.suse.de/view/YaST/job/yast-core-master/8/console I will investigate that on Monday. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=891065 https://bugzilla.novell.com/show_bug.cgi?id=891065#c3 Martin Vidner <mvidner@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #3 from Martin Vidner <mvidner@suse.com> 2014-08-11 14:00:39 CEST --- Made tests more robust. IBS: https://build.suse.de/request/show/42458 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com