[Bug 1095749] Error message 'repository managed by service "' when managing repos via YaST
http://bugzilla.suse.com/show_bug.cgi?id=1095749 http://bugzilla.suse.com/show_bug.cgi?id=1095749#c8 --- Comment #8 from Stefan Hundhammer <shundhammer@suse.com> --- AFAICS this check here https://github.com/yast/yast-packager/blob/master/src/lib/packager/clients/r... might be a bit over-optimistic. That "service" key might not even be in that hash, so accessing it would return 'nil' which is not checked at all. Also, it is pointless to construct that message and only afterwards check if it should be posted; this is an invitation to other problems. We should probably check like this at the very beginning of that function: def warn_service_repository(source_state) service = source_state["service"] return if service.nil? || service.empty? ... ... end -- You are receiving this mail because: You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply@novell.com