[Bug 1019575] New: Factory source checker is declining requests that should have a second review
http://bugzilla.suse.com/show_bug.cgi?id=1019575 Bug ID: 1019575 Summary: Factory source checker is declining requests that should have a second review Classification: openSUSE Product: openSUSE Backports Version: SLE-12 Hardware: Other OS: Other Status: NEW Severity: Normal Priority: P5 - None Component: Factory Source Check Assignee: packagehub-bugs@suse.com Reporter: sbahling@suse.com QA Contact: packagehub-bugs@suse.com Found By: --- Blocker: --- By default the factory source checker will set an SR to openSUSE:Backorts to "Declined" if the factory source check fails. In some cases the failure is because of a bug in the check scripts or in some cases it's because of a minor difference like a security patch which should actually be acceptable based on human review. Auto-declining causes frustration for the contributors. Instead of auto-declining, the bot should fall back to human review and only declined if upon human review it is determined that the submission really does not meet policies. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=1019575
http://bugzilla.suse.com/show_bug.cgi?id=1019575#c1
Scott Bahling
From what I see that should cause the script to set the fallback-user or fallback-group as new reviewer. We just need to determine who should be set as reviewer.
I still need to test this in action to see if it works as expected. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=1019575
http://bugzilla.suse.com/show_bug.cgi?id=1019575#c2
--- Comment #2 from Scott Bahling
http://bugzilla.suse.com/show_bug.cgi?id=1019575
http://bugzilla.suse.com/show_bug.cgi?id=1019575#c3
--- Comment #3 from Scott Bahling
http://bugzilla.suse.com/show_bug.cgi?id=1019575
http://bugzilla.suse.com/show_bug.cgi?id=1019575#c4
Ismail Donmez
I just tested and it works as expected:
https://build.opensuse.org/request/show/449846
I ran "check_source_in_factory.py id 449846" and the request was declined as usual.
https://build.opensuse.org/request/show/449848
With this second request I ran
check_source_in_factory.py --review-mode=fallback-onfail --fallback-user=sbahling id 449848
and the request is set to review by me.
Question is who to set the review to? The Maintenance team? Do we want to create a "backports" group?
I would very much prefer a group set up, so we can use the group for other purposes too. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=1019575
http://bugzilla.suse.com/show_bug.cgi?id=1019575#c5
--- Comment #5 from Wolfgang Engel
http://bugzilla.suse.com/show_bug.cgi?id=1019575
http://bugzilla.suse.com/show_bug.cgi?id=1019575#c6
--- Comment #6 from Scott Bahling
hmm the only thing missing in the second SR is a notification that the factory checker ran and failed. The script seems to just assign a reviewer, but gives no message why.
Turns out I was not testing accurately. The bot will "accept" the review with the declined message "the package needs to be accepted in openSUSE:Factory first", and assign the fallback reviewer. So it should just be a matter of creating the group that does the fallback review and changing the call in our cron job to use the fallback mode. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=1019575
http://bugzilla.suse.com/show_bug.cgi?id=1019575#c7
Wolfgang Engel
participants (1)
-
bugzilla_noreply＠novell.com