https://bugzilla.novell.com/show_bug.cgi?id=710203 https://bugzilla.novell.com/show_bug.cgi?id=710203#c0 Summary: [obs-webui] Adding package sources goes to "OBS Web Interface Error" page after invalid input Classification: openSUSE Product: openSUSE.org Version: unspecified Platform: Other OS/Version: Other Status: NEW Severity: Normal Priority: P5 - None Component: BuildService AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: stoyan.dimkov@gmail.com QAContact: adrian@novell.com Found By: --- Blocker: --- Created an attachment (id=444011) --> (http://bugzilla.novell.com/attachment.cgi?id=444011) screenshot1 of add sources bug User-Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/535.1 (KHTML, like Gecko) Chrome/13.0.782.109 Safari/535.1 If user enters specific invalid data in the form for adding sources to a package the browser gets redirected to "OBS Web Interface Error". Basically two ways to get there: 1) invalid file name (must contain slash). I used "//\\//\\" 2) Valid url (in order to pass the initial parsing) but not containing any file. I used "100.100.100.100" Screenshots added. Reproducible: Always Steps to Reproduce: 1. Create/Open a package. 2. Open Sources tab. 3. Open link "Add file". 4.a Enter name containing slash. Don't enter other data. 4.b Enter valid url that does not contain a file. Actual Results: Browser is redirected to "OBS Web Interface Error". if followed 4.a page shows "Message: Sorry, not found" if followed 4.b page shows "Message: undefined method `to_xs' for nil:NilClass" Expected Results: A flash message should inform the user for the invalid input. The form for adding sources should remain. Maybe the fields can get cleaned from the invalid data. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.