[Bug 596354] New: dh_reenable script fails
http://bugzilla.novell.com/show_bug.cgi?id=596354 http://bugzilla.novell.com/show_bug.cgi?id=596354#c0 Summary: dh_reenable script fails Classification: openSUSE Product: openSUSE 11.2 Version: Final Platform: x86-64 OS/Version: openSUSE 11.2 Status: NEW Severity: Normal Priority: P5 - None Component: Other AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: pat@indy.rr.com QAContact: qa@suse.de Found By: --- Blocker: --- User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-us) AppleWebKit/531.2+ (KHTML, like Gecko) Safari/531.2+ Epiphany/2.28.2 SUSE/2.28.0-2.4 when trying to reenable an ip which denyhosts added to /etc/hosts.deny, the script /usr/sbin/dh_reenable fails: 16:44 wahoo:~ # dh_reenable 12.34.567.890 File "/usr/sbin/dh_reenable", line 22 from __future__ import with_statement SyntaxError: from __future__ imports must occur at the beginning of the file note: editing /usr/sbin/dh_reenable and moving "from__future__imports" to the top of the script corrects the error but does not reenable the ip. Reproducible: Always Steps to Reproduce: 1./usr/sbin/dh_reenable <ip> 2. 3. Actual Results: quoted above Expected Results: remove the subject ip from the deny lists, /etc/hosts.deny, /var/lib/denyhosts/* -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=596354 http://bugzilla.novell.com/show_bug.cgi?id=596354#c yang xiaoyu <xyyang@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |xyyang@novell.com AssignedTo|bnc-team-screening@forge.pr |pgajdos@novell.com |ovo.novell.com | -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=596354 http://bugzilla.novell.com/show_bug.cgi?id=596354#c1 Petr Gajdos <pgajdos@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|pgajdos@novell.com |lrupp@novell.com --- Comment #1 from Petr Gajdos <pgajdos@novell.com> 2010-04-15 07:26:21 UTC --- xyyang, I am not maintainer of denyhosts. comp> osc meta pkg network:utilities denyhosts | grep bugowner <person userid="lrupp" role="bugowner"/> -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=596354 http://bugzilla.novell.com/show_bug.cgi?id=596354#c2 Petr Gajdos <pgajdos@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pgajdos@novell.com --- Comment #2 from Petr Gajdos <pgajdos@novell.com> 2010-04-15 07:27:20 UTC --- JFYI: http://osdir.com/ml/debian-bugs-closed/2009-06/msg02999.html -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=596354 http://bugzilla.novell.com/show_bug.cgi?id=596354#c3 --- Comment #3 from patrick shanahan <pat@indy.rr.com> 2010-04-15 13:54:22 UTC --- reply to "Comment #2, JFYI" as I commented in the original report, repositioning the "from __future__ import with_statement" line to the beginning of the script DOES ALLOW the script to run, but the scripts function is NOT ACCOMPLISHED. It does not reenable the ip address! tks -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=596354 http://bugzilla.novell.com/show_bug.cgi?id=596354#c4 Lars Vogdt <lrupp@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - None |P3 - Medium Status|NEW |ASSIGNED CC| |lrupp@novell.com Found By|--- |Community User Target Milestone|--- |Milestone 7 --- Comment #4 from Lars Vogdt <lrupp@novell.com> 2010-04-15 21:01:07 UTC --- I never used that script to re-enable an IP Address. Let's see if I can fix it... -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=596354 http://bugzilla.novell.com/show_bug.cgi?id=596354#c5 Lars Vogdt <lrupp@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEEDINFO InfoProvider| |pat@indy.rr.com --- Comment #5 from Lars Vogdt <lrupp@novell.com> 2010-04-15 21:21:42 UTC --- I tried the fixed (as mentioned in comment #1) dh_reenable here on my system now and everything works as expected (the IP is removed successfully from all files in /var/lib/denyhosts/ and /etc/hosts.allow. Have you restarted denyhosts via "rcdenyhosts restart" afterwards? -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=596354 http://bugzilla.novell.com/show_bug.cgi?id=596354#c6 patrick shanahan <pat@indy.rr.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |ASSIGNED InfoProvider|pat@indy.rr.com | --- Comment #6 from patrick shanahan <pat@indy.rr.com> 2010-04-15 21:41:34 UTC --- Yes, and "yes, it appears to work now". I reenabled the last ip in /etc/hosts.deny and it did remove it from hosts.deny, but it still remains in: 17:36 wahoo:~ # grep 200.82.137.126 /etc/hosts.deny /var/lib/denyhosts/* /var/lib/denyhosts/sync-received:200.82.137.126:Thu Apr 15 16:47:12 2010 if that makes any difference. I will close the bug with the option to reopen if it appears to fail in the near future. tks, -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=596354 http://bugzilla.novell.com/show_bug.cgi?id=596354#c7 patrick shanahan <pat@indy.rr.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED Severity|Normal |Major --- Comment #7 from patrick shanahan <pat@indy.rr.com> 2010-04-15 21:43:56 UTC --- correcting the position of "from __future__ import with_statement" line to the beginning of the script appears to have fixed the problem. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com