New subject: [Bug 835414] Kernel 3.4.47 - Compile error:=?UTF-8?Q?=20called=20object=20=E2=80=98efi=5Fenabled=E2=80=99=20is=20not=20a=20function?=

19 Aug 2013

      https://bugzilla.novell.com/show_bug.cgi?id=835414

https://bugzilla.novell.com/show_bug.cgi?id=835414#c0

           Summary: Kernel 3.4.47 - Compile error: called object
                    ‘efi_enabled’ is not a function
    Classification: openSUSE
           Product: openSUSE 12.2
           Version: Final
          Platform: Other
        OS/Version: openSUSE 12.2
            Status: NEW
          Severity: Major
          Priority: P5 - None
         Component: Kernel
        AssignedTo: kernel-maintainers@forge.provo.novell.com
        ReportedBy: freespacer@gmx.de
         QAContact: qa-bugs@suse.de
          Found By: ---
           Blocker: ---

User-Agent:       Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML,
like Gecko) Chrome/28.0.1500.95 Safari/537.36

The patch "kabi-re-add-efi_enabled-variable.patch" from Jiri Slaby is
incomplete. The patch renamed the function efi_enabled(EFI_BOOT) to
efi_enabled_f(EFI_BOOT) and set efi_enabled as variable. This is ok, but the
predefined variable EFI_BOOT was not renamed. This makes many compile error
because of incorrect assumption.

Example-Code from fglrx kernel module (AMD Catalyst 13.8 Beta1):
#ifdef CONFIG_EFI
#ifdef EFI_BOOT
   return efi_enabled(EFI_BOOT);
#else
   return efi_enabled;
#endif

In this case the compiler go to the section of "#ifdef EFI_BOOT" but this is
wrong. It is difficult to fix the above code that based upon the "re-add" patch
in the current kernel.

Please fix this ASAP. Thanks.

The header from the patch:
From: Jiri Slaby 
Subject: kABI: re-add efi_enabled variable
Patch-mainline: never, kabi

In 3.4.31, commit 739230186fa9d6999f88c53f0cb6d07ed4234fb0 (efi: Make
'efi_enabled' a function to query EFI facilities), upstream commit
83e68189745ad931c2afd45d8ee3303929233e7f, changed efi_enabled from
simple int to a function returning int. It indeed changed kABI.

Revert the effect of the patch while still preserving the fix. We
rename the newly added function to efi_enabled_f and add the
efi_enabled variable back (with setting at appropriate places).

We also change the efi_enabled occurence in samsung-laptop added in
commit 7f8d73f9e71d58187f42d26088578be5d2d70859 (samsung-laptop:
Disable on EFI hardware), upstream commit
e0094244e41c4d0c7ad69920681972fc45d8ce34.

Signed-off-by: Jiri Slaby 

Reproducible: Always

Steps to Reproduce:
1.
2.
3.
Actual Results:  
Compile error "error: called object ‘efi_enabled’ is not a function"

Expected Results:  
No compile error

-- 
Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 835414] New: Kernel 3.4.47 - Compile error:=?UTF-8?Q?=20called=20object=20=E2=80=98efi=5Fenabled=E2=80=99=20is=20not=20a=20function?=

bugzilla_noreply＠novell.com

bugzilla_noreply＠novell.com

bugzilla_noreply＠novell.com

bugzilla_noreply＠novell.com

bugzilla_noreply＠novell.com

bugzilla_noreply＠novell.com

bugzilla_noreply＠novell.com

bugzilla_noreply＠novell.com

bugzilla_noreply＠novell.com

bugzilla_noreply＠novell.com

tags

participants (1)