https://bugzilla.novell.com/show_bug.cgi?id=872266 https://bugzilla.novell.com/show_bug.cgi?id=872266#c2 --- Comment #2 from Dirk Weber 2014-04-06 19:29:39 UTC --- Created an attachment (id=585254) --> (http://bugzilla.novell.com/attachment.cgi?id=585254) patch which avoids that creation of the initrd fails when no ucode exists for this family patch for /lib/mkinitrd/scripts/setup-amd_microcode.sh /lib/mkinitrd/setup/91-amd_microcode.sh -> /lib/mkinitrd/scripts/setup-amd_microcode.sh which is part of the package ucode-amd-20130714git-2.5.1.noarch, so its existence already means that the package is installed. The patch adds a check if actually ucode files for the installed CPU family exist and avoids a failure if not. A possible workaround to avoid this problem with initrd creation for AMD CPU families newer then 0x15 is probably also just to uninstall the ucode-amd package. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=872266 https://bugzilla.novell.com/show_bug.cgi?id=872266#c4 Neil Brown changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |nfbrown@suse.com, | |trenn@suse.com Resolution| |FIXED --- Comment #4 from Neil Brown 2014-04-06 23:40:24 UTC --- Resolving as 'FIXED' as above patch has been submitted to Kernel:HEAD kernel-firmware -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=872266 https://bugzilla.novell.com/show_bug.cgi?id=872266#c6 --- Comment #6 from Bernhard Wiedemann 2014-04-10 03:00:13 CEST --- This is an autogenerated message for OBS integration: This bug (872266) was mentioned in https://build.opensuse.org/request/show/229555 13.1 / kernel-firmware -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=872266 https://bugzilla.novell.com/show_bug.cgi?id=872266#c8 --- Comment #8 from Swamp Workflow Management 2014-04-17 07:04:37 UTC --- openSUSE-RU-2014:0543-1: An update that has one recommended fix can now be installed. Category: recommended (low) Bug References: 872266 CVE References: Sources used: openSUSE 13.1 (src): kernel-firmware-20130714git-2.9.1 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=872266 https://bugzilla.novell.com/show_bug.cgi?id=872266#c10 --- Comment #10 from James Ogley 2014-04-22 13:00:01 UTC --- The patched version is still wrong, it checks for family >= 16 where it should be < 16. Changing line 19 to the following fixes it: if [ $fam -lt 16 >& /dev/null ];then -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=872266 https://bugzilla.novell.com/show_bug.cgi?id=872266#c12 --- Comment #12 from James Ogley 2014-05-06 12:44:37 UTC --- It still fails for me here on 0x16: Microcode: Adding AMD microcode microcode_amd_fam16h.bin cp: missing destination file operand after ‘/tmp/.LoGlN2zm/mnt/lib/firmware/amd-ucode’ Try 'cp --help' for more information. Script /lib/mkinitrd/setup/91-amd_microcode.sh failed! There was an error generating the initrd (1) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=872266 https://bugzilla.novell.com/show_bug.cgi?id=872266#c14 --- Comment #14 from James Ogley 2014-05-06 17:25:53 UTC --- Looks right to me: ogley@riggwelter:~> ls -l /lib/mkinitrd/setup/91-amd_microcode.sh lrwxrwxrwx 1 root root 33 May 6 13:36 /lib/mkinitrd/setup/91-amd_microcode.sh -> ../scripts/setup-amd_microcode.sh ogley@riggwelter:~> rpm -qf /lib/mkinitrd/scripts/setup-amd_microcode.sh ucode-amd-20130714git-2.13.1.noarch -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=872266 https://bugzilla.novell.com/show_bug.cgi?id=872266#c16 --- Comment #16 from James Ogley 2014-05-07 08:16:19 UTC --- ogley@riggwelter:~> /lib/mkinitrd/scripts/setup-amd_microcode.sh Microcode: No AMD microcode found for CPU family 0x16.ogley@riggwelter:~> (No \n after the no microcode message) Also, running the script directly as root works fine but it still fails when called by mkinitrd. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=872266 https://bugzilla.novell.com/show_bug.cgi?id=872266#c18 --- Comment #18 from Dirk Weber 2014-05-08 17:59:51 UTC --- Created an attachment (id=589208) --> (http://bugzilla.novell.com/attachment.cgi?id=589208) patch which "really" avoids failure if no microcode for the installed CPU family is available The current version of setup-amd_microcode.sh included in ucode-amd-20130714git-2.13.1.noarch uses "*" to check the availablity of ucode update files, e.g. microcode_amd_fam16h.bin* for family == 22. It is called from /sbin/mkinitrd which uses shopt -s nullglob, therefore the test is successful even if the needed file(s) do(es) not exist resulting in an attempt to copy the file(s) into the temporary mkinitrd directory structure, which fails if the files actually do not exist. original code: if [ "`echo /lib/firmware/amd-ucode/"$file"*`" != "/lib/firmware/amd-ucode/$file*" ];then patch: if [ -f /lib/firmware/amd-ucode/"$file" ];then This test now only checks for the existence of the binary file, not for its signature or other files beginning with the name. This approach only works if the exact file name is known in advance and correctly created by the script, e.g. file=`printf "microcode_amd_fam%xh.bin" $fam` I assume this is the case. For the actual copying the "*" is still used, so the fitting $file*.asc signature will be included in the initrd. The patch also adds the "\n" for the printf output lines. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.