[Bug 354200] New: stack mangling bug ...
https://bugzilla.novell.com/show_bug.cgi?id=354200 Summary: stack mangling bug ... Product: openSUSE 10.3 Version: Final Platform: Other OS/Version: Other Status: NEW Severity: Major Priority: P5 - None Component: Evolution AssignedTo: bnc-team-evolution@forge.provo.novell.com ReportedBy: mmeeks@novell.com QAContact: lakhil@novell.com CC: sragavan@novell.com Found By: --- Running valgrind to try to nail down my evo crasher experience: ==19909== Invalid write of size 4 ==19909== at 0x58A7587: time (time.c:34) ==19909== by 0x10B8F8B0: sound_notify_idle_cb (mail-notification.c:571) ==19909== by 0x5787DC0: g_idle_dispatch (gmain.c:4132) ==19909== by 0x5789CB7: g_main_context_dispatch (gmain.c:2061) ==19909== by 0x578D34A: g_main_context_iterate (gmain.c:2694) ==19909== by 0x578D84E: g_main_loop_run (gmain.c:2898) ==19909== by 0x4CBB082: bonobo_main (bonobo-main.c:311) ==19909== by 0x805EA1C: main (main.c:700) ==19909== Address 0xbec08c20 is just below the stack ptr. To suppress, use: --workaround-gcc296-bugs=yes ==19909== The code is pretty obviously broken / silly: static void new_notify_sound (EMEventTargetFolder *t) { time_t last_newmail; struct _SoundNotifyData data = {0, 0}; time (&last_newmail); /* just put it to the idle queue */ if (data.notify_idle_id == 0 && (last_newmail - data.last_notify >= NOTIFY_THROTTLE)) data.notify_idle_id = g_idle_add_full (G_PRIORITY_LOW, sound_notify_idle_cb, &data, NULL); } ** Note - passes a pointer on the stack to an idle handler ** I *think* that the intention was to include the keyword 'static' on the SoundNotifyData data - that seems the most logical fix. HTH. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=354200
User sragavan@novell.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=354200#c1
Srinivasa Ragavan V
https://bugzilla.novell.com/show_bug.cgi?id=354200
User sragavan@novell.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=354200#c3
--- Comment #3 from Srinivasa Ragavan V
https://bugzilla.novell.com/show_bug.cgi?id=354200
User mmeeks@novell.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=354200#c4
--- Comment #4 from Michael Meeks
https://bugzilla.novell.com/show_bug.cgi?id=354200
User sragavan@novell.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=354200#c5
--- Comment #5 from Srinivasa Ragavan V
participants (1)
-
bugzilla_noreply@novell.com