https://bugzilla.novell.com/show_bug.cgi?id=366467 User jkupec@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=366467#c1 Ján Kupec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO Info Provider| |francis@opensuse.org --- Comment #1 from Ján Kupec 2008-03-05 05:17:35 MST --- Yes, that's because they are two different things: trust and import :O) Do you think no one will miss the possibility to use a repository without importing the key? (I would :O). Maybe it is not a common use-case, but it should be possible to do. What if you just want to install one package from that repo and forget it? What about one-click install? What about the --plus-repo? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=366467 User jkupec@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=366467#c3 Ján Kupec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEEDINFO Info Provider| |dmacvicar@novell.com --- Comment #3 from Ján Kupec 2008-03-05 05:29:13 MST --- Duncan, what do you think? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=366467 User jkupec@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=366467#c5 Ján Kupec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEEDINFO Info Provider| |dmacvicar@novell.com --- Comment #5 from Ján Kupec 2008-03-14 08:08:05 MST --- (In reply to comment #4 from Duncan Mac-Vicar)

The zypper callback can be enhanced so it can receive no/this time/always, where first is no, second is trust, not import and the third trust & import.

That is exactly how i meant it, i just wonder why not do it directly in libzypp, so that other apps don't have to do just that (handle two different callbacks with bool answers, instead of just one with multiple answers). -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=366467 User jkupec@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=366467#c7 Ján Kupec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |ASSIGNED Info Provider|jkupec@novell.com | --- Comment #7 from Ján Kupec 2008-03-27 02:44:06 MST --- Created an attachment (id=204202) --> (https://bugzilla.novell.com/attachment.cgi?id=204202) proposed patch OK, here is a patch (only a quick hack, may not be entirely correct). What do you think? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=366467 User cthiel@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=366467#c8 --- Comment #8 from Christoph Thiel 2008-04-22 05:35:37 MST --- Duncan, *ping* :) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=366467 User jkupec@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=366467#c10 --- Comment #10 from Ján Kupec 2008-04-24 17:33:02 MST --- (In reply to comment #9 from Duncan Mac-Vicar Prett)

Patch looks fine. Talked with Jano, only suggestion to change the name of the callback to "accept" instead of "trust" to avoid confusion.

OK, this was easy. The callback is called askUserToAcceptKey now. But the return value enum is typdef enum {KEY_DONT_TRUST=0, KEY_TRUST_TEMPORARILY, KEY_TRUST_AND_IMPORT} KeyTrust; Maybe i should rename those too to: typdef enum {KEY_DONT_ACCEPT=0, KEY_ACCEPT_TEMPORARILY, KEY_ACCEPT_PERMANENTLY} KeyAcceptLevel; ??

Also, if we are breaking the API and changing it, we could use the chance to fix bug 370223 and add a context structure to the callback where libzypp could pass some translated text that the user interface could show, like "the key of repo foo".

Now this is tough. I found it hard to come up with a string that could suite any application. Instead of passing string i decided to pass RepoInfo (wrapped in a struct called KeyContext). But the main problem is that now that we have all the components so beautifully independent, we completely lost the context. In orded to pass _something_ to a KeyRing callback you need to pass it all the way down from RepoManager -> {yum,susetags}::Downloader -> SignatureFileChecker -> KeyRing::verifyFileSignatureWorkflow() -> the callbacks. 4 components in the way now infected with the KeyContext... I'm not committing it yet as i'd like some comments before i do so. See the following attachment. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=366467 Ján Kupec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEEDINFO Info Provider| |zypp-maintainers@forge.provo.novell.com -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=366467 User jkupec@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=366467#c13 Ján Kupec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |RESOLVED Info Provider|zypp-maintainers@forge.provo.novell.com | Resolution| |LATER --- Comment #13 from Ján Kupec 2008-04-29 02:41:16 MST --- OK, no response, let's do this after 11.0 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=366467 User jkupec@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=366467#c15 Ján Kupec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |ASSIGNED Priority|P5 - None |P2 - High --- Comment #15 from Ján Kupec 2008-09-18 07:57:45 MDT --- almost done... -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=366467 User jkupec@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=366467#c17 Ján Kupec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #17 from Ján Kupec 2008-09-25 15:30:15 MDT --- submitted in libzypp-5.12.0, zypper-0.12.6, yast2-pkg-bindings-2.17.13, yast2-2.17.30 and yast2-packager-2.17.20. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.