[Bug 436470] New: [RPM] Fixed path in rpm script.
https://bugzilla.novell.com/show_bug.cgi?id=436470 Summary: [RPM] Fixed path in rpm script. Product: openSUSE 11.1 Version: Beta 2 Platform: All OS/Version: Other Status: NEW Severity: Normal Priority: P5 - None Component: Basesystem AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: eich@novell.com QAContact: qa@suse.de Found By: Development Created an attachment (id=246272) --> (https://bugzilla.novell.com/attachment.cgi?id=246272) Proposed fix. The rpm script find-supplements.ksyms contains an fixed path to the SOURCES directory. This doesn't work when this path is modified in .rpmmacros. Furthermore spec files are not found in the SOURCES directory when one installs a source rpm. Thus it needs to be checked if the spec file is really present in the SOURCES directory or in SPECS. Checking for the presence in SOURCES first preserve as much backwards compatibility and reduce the risk of surprises in autobuild. Patch attached. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=436470 Michal Seben <mseben@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mseben@novell.com AssignedTo|bnc-team-screening@forge.provo.novell.com |mls@novell.com -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=436470 User mls@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=436470#c1 Michael Schröder <mls@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO Info Provider| |agruen@novell.com --- Comment #1 from Michael Schröder <mls@novell.com> 2008-10-17 07:25:57 MDT --- Andreas, ok to apply this patch? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=436470 User agruen@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=436470#c2 Andreas Gruenbacher <agruen@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |agruen@novell.com Status|NEEDINFO |NEW Info Provider|agruen@novell.com | --- Comment #2 from Andreas Gruenbacher <agruen@novell.com> 2008-10-17 07:39:40 MDT --- No, this just replaces one hack with a more elaborate and more complex other hack. Can't RPM pass that information down to find-* in environment variables instead? In another case, I ran into the problem that find-provides does not have a way to figure out for which package it is being involved: It is being passed %name in $1, but in case of multiple sub-packages of a spec file, this does not help at all. Any ideas for this related problem perhaps? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=436470 User eich@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=436470#c8 --- Comment #8 from Egbert Eich <eich@novell.com> 2008-10-20 08:38:28 MDT --- I've tried this: %__find_supplements \ RPM_SOURCE_DIR=\"%{u2p:%{_sourcedir}}\"\ RPM_SPEC_DIR=\"%{u2p:%{_specdir}}\"\ export RPM_SOURCE_DIR RPM_SPEC_DIR \ /usr/lib/rpm/find-supplements %name This is what I get: Finding Requires: /usr/lib/rpm/find-requires xorg-x11-driver-video error: Couldn't exec RPM_SOURCE_DIR=/home/eich/rpmbuild/SOURCES: No such file or directory Finding Supplements: RPM_SOURCE_DIR="/home/eich/rpmbuild/SOURCES" RPM_SPEC_DIR="/home/eich/rpmbuild/SPECS" export RPM_SOURCE_DIR RPM_SPEC_DIR /usr/lib/rpm/find-supplements xorg-x11-driver-video I don't know how to fix this and frankly I don't want to waste any more time on this either. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=436470 User mmarek@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=436470#c9 --- Comment #9 from Michal Marek <mmarek@novell.com> 2008-10-20 08:43:21 MDT --- (In reply to comment #8 from Egbert Eich)
I've tried this: %__find_supplements \ RPM_SOURCE_DIR=\"%{u2p:%{_sourcedir}}\"\ RPM_SPEC_DIR=\"%{u2p:%{_specdir}}\"\ export RPM_SOURCE_DIR RPM_SPEC_DIR \ /usr/lib/rpm/find-supplements %name
This is what I get: Finding Requires: /usr/lib/rpm/find-requires xorg-x11-driver-video error: Couldn't exec RPM_SOURCE_DIR=/home/eich/rpmbuild/SOURCES: No such file or directory
For some reason the content of the %__find_xxx macros is not passed to the shell as other build phases, but just split into words by rpm and execve()d directly :-/. You'd have to make it %__find_supplements sh -c 'RPM_SOURCE_DIR=... /usr/lib/rpm/find-supplements %name' and hope that rpm gets the apostrophes right... -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=436470 User agruen@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=436470#c12 --- Comment #12 from Andreas Gruenbacher <agruen@novell.com> 2008-10-21 08:20:51 MDT --- I have another packaging problem in the kernel in which the sub-package name, or even only %_sourcedir, would be nice to know in find-provides, by the way, so fixing would really help. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=436470 User mls@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=436470#c13 Michael Schröder <mls@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #13 from Michael Schröder <mls@novell.com> 2008-12-03 05:02:37 MST --- Fixed in 11.1. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com