https://bugzilla.novell.com/show_bug.cgi?id=789060 https://bugzilla.novell.com/show_bug.cgi?id=789060#c Jiri Srain changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|jsrain@suse.com |snwint@suse.com -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=789060 https://bugzilla.novell.com/show_bug.cgi?id=789060#c2 Michael Chang changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mchang@suse.com --- Comment #2 from Michael Chang 2012-11-12 11:48:14 UTC --- (In reply to comment #1)

Michael, is the patch ok for you?

I'm ok. It looks good. Thank you Steffen and Andrey. :) Btw .. I think bnc#789172 could be fixed by this patch. Let's see how the reporter replied. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=789060 https://bugzilla.novell.com/show_bug.cgi?id=789060#c4 --- Comment #4 from Andrey Borzenkov 2012-11-12 12:27:35 UTC --- (In reply to comment #3)

+ my ($sysname, $nodename, $release, $version, $machine) = POSIX::uname(); + my $target = "$machine-efi"; + $loader->{'target'} = $target;

Could it possible to use --hardware-platform rather than --machine? The grub2-install script would fail in, for ex, i686-efi as target.

Ah, right. Hmm ... I intended to avoid calling external uname. I think I just forgot to map i.86 => i386. Would it be OK? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=789060 https://bugzilla.novell.com/show_bug.cgi?id=789060#c5 Andrey Borzenkov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #512713|0 |1 is obsolete| | --- Comment #5 from Andrey Borzenkov 2012-11-12 16:09:06 UTC --- Created an attachment (id=512810) --> (http://bugzilla.novell.com/attachment.cgi?id=512810) Patch to remove grub2-efi-* artefacts from perl-Bootloader (In reply to comment #4)

(In reply to comment #3)

Ah, right. Hmm ... I intended to avoid calling external uname. I think I just forgot to map i.86 => i386. Would it be OK?

Updated patch attached. I still prefer to avoid calling "uname -i" and rather follow what grub-install does. This way we are sure that we do the same. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=789060 https://bugzilla.novell.com/show_bug.cgi?id=789060#c7 --- Comment #7 from Andrey Borzenkov 2012-11-14 17:36:20 UTC --- OK, no comments is good :) https://github.com/openSUSE/perl-bootloader/pull/11 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.