[Bug 623460] New: rcxdm restart doesn't wait for stop before issuing start
http://bugzilla.novell.com/show_bug.cgi?id=623460 http://bugzilla.novell.com/show_bug.cgi?id=623460#c0 Summary: rcxdm restart doesn't wait for stop before issuing start Classification: openSUSE Product: openSUSE 11.3 Version: Final Platform: All OS/Version: openSUSE 11.3 Status: NEW Severity: Normal Priority: P5 - None Component: X.Org AssignedTo: bnc-team-xorg-bugs@forge.provo.novell.com ReportedBy: jnelson-suse@jamponi.net QAContact: xorg-maintainer-bugs@forge.provo.novell.com CC: mt@novell.com, werner@novell.com Depends on: 622058 Found By: --- Blocker: --- +++ This bug was initially created as a clone of Bug #622058 +++ the xdm init script suffers from the same issue discovered in Bug 622058. Can a fix for the xdm script also be supplied? Actually, this seems like it might be a more systemic issue. Why was the change made in the first place? It seems like this issue might effect many packages. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=623460 http://bugzilla.novell.com/show_bug.cgi?id=623460#c1 Stefan Dirsch <sndirsch@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - None |P3 - Medium Status|NEW |ASSIGNED AssignedTo|bnc-team-xorg-bugs@forge.pr |sndirsch@novell.com |ovo.novell.com | --- Comment #1 from Stefan Dirsch <sndirsch@novell.com> 2010-07-19 13:50:38 UTC ---
Why was the change made in the first place?
Which change? -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=623460 http://bugzilla.novell.com/show_bug.cgi?id=623460#c Stefan Dirsch <sndirsch@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEEDINFO InfoProvider| |jnelson-suse@jamponi.net -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=623460 http://bugzilla.novell.com/show_bug.cgi?id=623460#c2 Jon Nelson <jnelson-suse@jamponi.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |ASSIGNED InfoProvider|jnelson-suse@jamponi.net | --- Comment #2 from Jon Nelson <jnelson-suse@jamponi.net> 2010-07-19 14:19:31 UTC --- As noted in bug 622068 (comment #5), the behavior of killproc was changed to meet LSB specs (or something like that). The upshot is that _prior_ to 11.3, when invoked like this: killproc -TERM /some/process/path it would send a -TERM. wait (normally) 5 seconds and if the process still hasn't exited, send a SIGKILL. The new behavior eliminates the wait and subsequent SIGKILL. Thus, what happens _now_, in very rapid succession: obtain pid of (for example) /usr/bin/kdm kill -TERM $that_pid start /usr/bin/kdm The problem is that the old kdm hasn't exited yet (the signal was sent just one one-jillionth of a second ago, after all). Thus, "rcxdm restart" frequently only ends up killing the current display manager, as it can't start the new one. This change in the behavior of killproc seems terribly ill-advised without also having had a good look at **all** of the init scripts which use it. In any case, the change in bug 622058 should, IMO, be applied here as well: Use: killproc ${PIDFILE:+-p ${PIDFILE}} -t 10 -TERM $DISPLAYMANAGER instead of: killproc ${PIDFILE:+-p ${PIDFILE}} -TERM $DISPLAYMANAGER Indeed, the comment immediately prior to the killproc code reads: # # killproc(8) sleep upto five seconds and sends # SIGKILL if xdm does not terminate within # and that comment is now *wrong*. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=623460 http://bugzilla.novell.com/show_bug.cgi?id=623460#c3 --- Comment #3 from Dr. Werner Fink <werner@novell.com> 2010-07-19 14:41:31 UTC --- Remove the -TERM as LSB requires that if the signal is specified the killproc should only send the signal specified on the command line ... if no signal is specified on the command line the signal TERM is used followed by KILL after 5 seconds. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=623460 http://bugzilla.novell.com/show_bug.cgi?id=623460#c4 --- Comment #4 from Jon Nelson <jnelson-suse@jamponi.net> 2010-07-19 14:49:19 UTC --- Dr. Werner Fink - that seems like a more reasonable solution. If I may ask - did anybody bother to go through the init scripts to look for applications which depend on the (old) behavior of killproc? Just a suggestion: perhaps someone should to head off more bugs. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=623460 http://bugzilla.novell.com/show_bug.cgi?id=623460#c5 Dr. Werner Fink <werner@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |coolo@novell.com, | |ro@novell.com --- Comment #5 from Dr. Werner Fink <werner@novell.com> 2010-07-19 14:57:24 UTC --- Normally the package should not depend on the old behaviour that is that 5 seconds should be enough to terminate a normal server daemon. And yes I've look through out the services. Currently only cups is known to have a problem for restart. The question is *why* SIGTERM takes that long for xdm od gdm or xdm or any other display manager? And why was this problem discoverd that late as the changes was done at Mon Apr 12 17:49:46 CEST 2010. Compare with bug #595796 and bug #622058 -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=623460 http://bugzilla.novell.com/show_bug.cgi?id=623460#c6 Stefan Dirsch <sndirsch@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|sndirsch@novell.com |werner@novell.com --- Comment #6 from Stefan Dirsch <sndirsch@novell.com> 2010-07-19 15:00:38 UTC --- Werner? I wasn't aware of that change at all ... -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=623460 http://bugzilla.novell.com/show_bug.cgi?id=623460#c7 Dr. Werner Fink <werner@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|werner@novell.com |sndirsch@novell.com --- Comment #7 from Dr. Werner Fink <werner@novell.com> 2010-07-19 15:16:38 UTC --- See request 43403 and request 43404 -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=623460 http://bugzilla.novell.com/show_bug.cgi?id=623460#c8 Stefan Dirsch <sndirsch@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #8 from Stefan Dirsch <sndirsch@novell.com> 2010-07-19 15:37:24 UTC --- Ok. Accepter for X11:XOrg and submitted to openSUSE:Factory. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=623460 http://bugzilla.novell.com/show_bug.cgi?id=623460#c9 --- Comment #9 from Jon Nelson <jnelson-suse@jamponi.net> 2010-07-19 16:11:44 UTC --- (In reply to comment #5)
Normally the package should not depend on the old behaviour that is that 5 seconds should be enough to terminate a normal server daemon.
And yes I've look through out the services. Currently only cups is known to have a problem for restart.
The question is *why* SIGTERM takes that long for xdm od gdm or xdm or any other display manager? And why was this problem discoverd that late as the changes was done at Mon Apr 12 17:49:46 CEST 2010.
Compare with bug #595796 and bug #622058
With all due respect, I believe that there still exists an issue with lots of packages. A quick "grep TERM /etc/init.d/* | grep killproc" shows 36 of 110 init scripts (on this machine) make use of killproc -TERM in some way. I recently discovered that haldaemon is *also* susceptible to this particular issue. To me, the core issue is the fact that many init scripts are specifying the -TERM which means that with the new killproc behavior they do not wait _at all_. I would wager that a great many of the init scripts which currently specify -TERM would not reliably restart their packages if the system were under any sort of load or the program took more than a fraction of a second to exit. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=623460 http://bugzilla.novell.com/show_bug.cgi?id=623460#c10 --- Comment #10 from Dr. Werner Fink <werner@novell.com> 2010-07-20 09:54:38 UTC --- I've submitted a changed version of killproc (package sysvinit). It now waits upto 5 seconds even if SIGTERM was specified on the command line and therefore the final SIGKILL is not used as required for LSB. See request https://build.opensuse.org/request/show/43484 and https://build.opensuse.org/request/show/43483 . -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=623460 http://bugzilla.novell.com/show_bug.cgi?id=623460#c11 Dr. Werner Fink <werner@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED | --- Comment #11 from Dr. Werner Fink <werner@novell.com> 2010-07-22 10:43:37 UTC --- Reopen for SWAMID -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=623460 http://bugzilla.novell.com/show_bug.cgi?id=623460#c12 Dr. Werner Fink <werner@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |NEEDINFO InfoProvider| |maintenance@opensuse.org --- Comment #12 from Dr. Werner Fink <werner@novell.com> 2010-07-22 10:44:56 UTC --- A SWAMPID for sysvinit and xorg-x11 for OS11.3 is required. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=623460 http://bugzilla.novell.com/show_bug.cgi?id=623460#c13 --- Comment #13 from Marcus Meissner <meissner@novell.com> 2010-07-22 13:30:57 UTC --- sounds reasonible. although the X update might be quite large ... can we postpone that part and collect other X fixes first? sysvinit can be done now I guess +1 -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=623460 http://bugzilla.novell.com/show_bug.cgi?id=623460#c14 --- Comment #14 from Stefan Dirsch <sndirsch@novell.com> 2010-07-22 14:41:26 UTC --- Actually I'm not really interested into an update of xorg-x11 for 11.3 for that issue at all. I don't believe it's that important. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=623460 http://bugzilla.novell.com/show_bug.cgi?id=623460#c15 Swamp Workflow Management <swamp@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status Whiteboard| |maint:running:34705:low --- Comment #15 from Swamp Workflow Management <swamp@suse.com> 2010-07-22 15:05:07 UTC --- The SWAMPID for this issue is 34705. This issue was rated as low. Please submit fixed packages as soon as possible. Also create a patchinfo file using this link: https://swamp.suse.de/webswamp/wf/34705 -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=623460 http://bugzilla.novell.com/show_bug.cgi?id=623460#c16 Christian Dengler <cdengler@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |REOPENED CC| |cdengler@novell.com InfoProvider|maintenance@opensuse.org | --- Comment #16 from Christian Dengler <cdengler@novell.com> 2010-07-22 15:05:48 UTC --- Ok, update process started for sysvinit. For xorg we can collect more bugs and start an update then. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=623460 http://bugzilla.novell.com/show_bug.cgi?id=623460#c Stefan Dirsch <sndirsch@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|sndirsch@novell.com |werner@novell.com -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=623460 http://bugzilla.novell.com/show_bug.cgi?id=623460#c17 Dr. Werner Fink <werner@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution| |FIXED --- Comment #17 from Dr. Werner Fink <werner@novell.com> 2010-07-23 07:57:22 UTC --- Patchinfo submitted -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=623460 http://bugzilla.novell.com/show_bug.cgi?id=623460#c Swamp Workflow Management <swamp@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status Whiteboard|maint:running:34705:low |. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com