[Bug 1167952] New: bash-completion: mplayer completion excludes directories
http://bugzilla.opensuse.org/show_bug.cgi?id=1167952 Bug ID: 1167952 Summary: bash-completion: mplayer completion excludes directories Classification: openSUSE Product: openSUSE Tumbleweed Version: Current Hardware: Other OS: Other Status: NEW Severity: Normal Priority: P5 - None Component: Basesystem Assignee: screening-team-bugs@suse.de Reporter: msuchanek@suse.com QA Contact: qa-bugs@suse.de Found By: --- Blocker: --- Created attachment 834115 --> http://bugzilla.opensuse.org/attachment.cgi?id=834115&action=edit patch that seems to fix the issue The mplayer completion completes files and directories but only with a media extensions. Directories should be completed regardless of extension. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1167952 Michal Suchanek <msuchanek@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|screening-team-bugs@suse.de |werner@suse.com -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1167952 http://bugzilla.opensuse.org/show_bug.cgi?id=1167952#c1 --- Comment #1 from Dr. Werner Fink <werner@suse.com> --- (In reply to Michal Suchanek from comment #0)
Created attachment 834115 [details] patch that seems to fix the issue
The mplayer completion completes files and directories but only with a media extensions. Directories should be completed regardless of extension.
Hmm .... please could a) fix it in such a way that both the completion on the file type and b) as well as for directories work And then submit it also to upstream as well -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1167952 http://bugzilla.opensuse.org/show_bug.cgi?id=1167952#c2 --- Comment #2 from Michal Suchanek <msuchanek@suse.com> --- It seems this does just that. Do you see any issues with the patch? -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1167952 http://bugzilla.opensuse.org/show_bug.cgi?id=1167952#c3 --- Comment #3 from Dr. Werner Fink <werner@suse.com> --- (In reply to Michal Suchanek from comment #2)
It seems this does just that.
Do you see any issues with the patch?
I'd like to avoid completion for e.g. foobar.txt :) ... the peferct solution would be to use the file(1) command to check for playable data files but AFAIC the endings useed in the upstream solution catches most file types whic hare playable by mplayer but misses the possiblilty to goes to a deeper (sub)directory -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1167952 http://bugzilla.opensuse.org/show_bug.cgi?id=1167952#c4 --- Comment #4 from Michal Suchanek <msuchanek@suse.com> --- And the patch adds the completion of directories. So it does exactly that. Or am I missing something? foobar.txt is not completed for me unless it's a directory. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1167952 http://bugzilla.opensuse.org/show_bug.cgi?id=1167952#c5 Dr. Werner Fink <werner@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #5 from Dr. Werner Fink <werner@suse.com> --- (In reply to Michal Suchanek from comment #4)
And the patch adds the completion of directories. So it does exactly that. Or am I missing something?
foobar.txt is not completed for me unless it's a directory.
Ah .. OK, then I've missread the patch its self. Accepted now for Factory with SR#789711 -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1167952 http://bugzilla.opensuse.org/show_bug.cgi?id=1167952#c7 --- Comment #7 from Michal Suchanek <msuchanek@suse.com> --- This is more complex than that. The completion should complete directories as well out of the box and often does. However, under some circumstances it fails. Not sure what triggers the failure. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1167952 http://bugzilla.opensuse.org/show_bug.cgi?id=1167952#c8 Dr. Werner Fink <werner@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- --- Comment #8 from Dr. Werner Fink <werner@suse.com> --- (In reply to Michal Suchanek from comment #7)
This is more complex than that. The completion should complete directories as well out of the box and often does.
However, under some circumstances it fails. Not sure what triggers the failure.
Ok ... -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1167952 http://bugzilla.opensuse.org/show_bug.cgi?id=1167952#c9 Michal Suchanek <msuchanek@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://github.com/scop/bas | |h-completion/issues/378 --- Comment #9 from Michal Suchanek <msuchanek@suse.com> --- Looks like this is an open issue upstream. There was a solution with calling _filedir -d which was then replaced with a more convoluted solution which is not as reliable. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1167952 http://bugzilla.opensuse.org/show_bug.cgi?id=1167952#c10 --- Comment #10 from Michal Suchanek <msuchanek@suse.com> --- Does reverting the offending commit reported upstream sound like the right thing? The revert supposedly completes directories reliably at the cost of generating duplicate completions. This may cause issues with some more convoluted completion scripts that count the number of completions returned and behave differently based on that. Not sure if any of the included scripts do so. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1167952 Michal Suchanek <msuchanek@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|bash-completion: mplayer |bash-completion: completion |completion excludes |sometimes excludes |directories |directories when file | |pattern given -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1167952 http://bugzilla.opensuse.org/show_bug.cgi?id=1167952#c11 --- Comment #11 from Dr. Werner Fink <werner@suse.com> --- (In reply to Michal Suchanek from comment #10)
Does reverting the offending commit reported upstream sound like the right thing?
The revert supposedly completes directories reliably at the cost of generating duplicate completions.
This may cause issues with some more convoluted completion scripts that count the number of completions returned and behave differently based on that.
Not sure if any of the included scripts do so.
If this really mmatters, that is the current behaviour is breaing the workflow of many users out there, then yes we should revert it. Btw: the mentioned upstream issue is about spaces in file names ... sounds like quoting is missed somewhere in _filedir() or a shell function below -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1167952 http://bugzilla.opensuse.org/show_bug.cgi?id=1167952#c12 --- Comment #12 from Dr. Werner Fink <werner@suse.com> --- If you have an expample for e.g. mplayer, that is video files and sub directories which do fail in completion then report it upstream -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1167952 http://bugzilla.opensuse.org/show_bug.cgi?id=1167952#c13 Dr. Werner Fink <werner@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED --- Comment #13 from Dr. Werner Fink <werner@suse.com> --- Fix submitted -- You are receiving this mail because: You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com