[Bug 398995] New: [Novell:NTS/ntsutils] Binary files being appended to . txt files
https://bugzilla.novell.com/show_bug.cgi?id=398995 Summary: [Novell:NTS/ntsutils] Binary files being appended to .txt files Product: openSUSE.org Version: unspecified Platform: Other OS/Version: Other Status: NEW Severity: Normal Priority: P5 - None Component: 3rd party software AssignedTo: jrecord@novell.com ReportedBy: jhatch@novell.com QAContact: opensuse-communityscreening@forge.provo.novell.com Found By: --- If there is a binary file in a directory that is captured by supportconfig it is appended to the txt file, causing 1) a bit of ugliness and 2) very large txt files, especially if the binary file is something like a xen virtual disk. It would be splendid if suportconfig would perform a check to make sure the file is not binary before including it. If a binary file is found it should be reported in the text file though (ie, "binary file -- not included"). -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=398995 Jason Record <jrecord@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=398995 User jrecord@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=398995#c1 --- Comment #1 from Jason Record <jrecord@novell.com> 2008-06-13 13:55:34 MDT --- Created an attachment (id=222101) --> (https://bugzilla.novell.com/attachment.cgi?id=222101) Fix for non-text files. Checks all conf_files and only includes text files. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=398995 User jrecord@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=398995#c2 Jason Record <jrecord@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEEDINFO Info Provider| |jhatch@novell.com --- Comment #2 from Jason Record <jrecord@novell.com> 2008-06-13 15:43:28 MDT --- Fixed, please test supportconfig in https://forgesvn1.novell.com/viewsvn/ntsutils/trunk/scripts/ -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=398995 User jrecord@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=398995#c4 Jason Record <jrecord@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |ASSIGNED Info Provider|jhatch@novell.com | --- Comment #4 from Jason Record <jrecord@novell.com> 2008-07-03 16:14:45 MDT --- Fixed -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=398995 User jrecord@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=398995#c5 Jason Record <jrecord@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #5 from Jason Record <jrecord@novell.com> 2008-07-03 16:16:22 MDT --- Index: trunk/scripts/supportconfig =================================================================== --- trunk/scripts/supportconfig (revision 5) +++ trunk/scripts/supportconfig (revision 6) @@ -1,7 +1,7 @@ #!/bin/bash -SVER=2.19-58 -SDATE="2008 06 10" +SVER=2.19-59 +SDATE="2008 06 13" ############################################################################## # supportconfig - Gathers system troubleshooting information for NTS. @@ -212,12 +212,18 @@ echo "#==[ Configuration File ]===========================#" >> $LOGFILE if [ -f $CONF ]; then echo "# $CONF" >> $LOGFILE - if (( ADD_OPTION_LOGS )); then - sed -e 's/ + TEXTFILE=$(file -L $CONF | egrep "text|empty") + if [ -z "$TEXTFILE" ]; then + file -L $CONF >> $LOGFILE + echo "ERROR: Not a normal text file, excluding it." >> $LOGFILE + else + if (( ADD_OPTION_LOGS )); then + sed -e 's/ //g' $CONF >> $LOGFILE 2>> $LOG/$CSFILE - else - sed -e '/^[[:space:]]*#/d' -e '/^[[:space:]]*;/d' -e '/^[[:space:]]*\/\//d' -e 's/ + else + sed -e '/^[[:space:]]*#/d' -e '/^[[:space:]]*;/d' -e '/^[[:space:]]*\/\//d' -e 's/ //g' -e '/^$/d' $CONF >> $LOGFILE 2>> $LOG/$CSFILE + fi fi echo >> $LOGFILE else -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=398995 User jrecord@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=398995#c6 Jason Record <jrecord@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #6 from Jason Record <jrecord@novell.com> 2008-08-01 09:32:51 MDT --- Closed. Released to OBS http://en.opensuse.org/NTSutils -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com