[Bug 797243] New: Documentation/sysctl/net.txt is outdated
https://bugzilla.novell.com/show_bug.cgi?id=797243 https://bugzilla.novell.com/show_bug.cgi?id=797243#c0 Summary: Documentation/sysctl/net.txt is outdated Classification: openSUSE Product: openSUSE Factory Version: 12.3 Milestone 1 Platform: Other OS/Version: Other Status: NEW Severity: Minor Priority: P5 - None Component: Kernel AssignedTo: kernel-maintainers@forge.provo.novell.com ReportedBy: christian.morales.vega@gmail.com QAContact: qa-bugs@suse.de Found By: Community User Blocker: --- Documentation/sysctl/net.txt says: "netdev_budget ------------- Maximum number of packets taken from all interfaces in one polling cycle (NAPI poll). In one polling cycle interfaces which are registered to polling are probed in a round-robin manner. The limit of packets in one such probe can be set per-device via sysfs class/net/<device>/weight ." But /sys/class/net/<device>/weight was removed five years ago in http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=commitdiff;h=... Probably there is a better place to report this. But I am too lazy to try to find which is that place. By the way. I see netif_napi_add() still has a weight parameter. Is it being used? There is actually any replacement for the functionality of /sys/class/net/<device>/weight? After reading Documentation/sysctl/net.txt (ignoring the sysfs part) what I understand is that all the interfaces now have the same weight. And the number of packets that can be taken in a polling cycle is limited by: a) /proc/sys/net/core/dev_weight per CPU b) /proc/sys/net/core/netdev_budget globally But I suspect I am still not understanding it (specially because of the weight parameter in netif_napi_add()). Even if I am not a kernel developer, it would be great if that document could be updated to make it 100% clear even for someone as stupid as me. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=797243 https://bugzilla.novell.com/show_bug.cgi?id=797243#c1 Jiri Slaby <jslaby@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |jslaby@suse.com Resolution| |FIXED --- Comment #1 from Jiri Slaby <jslaby@suse.com> 2013-06-24 08:27:50 UTC --- This is fixed by in -next and will be part of 3.11: commit 3cc7587b30032b7c4dd9610a55a77519e84da7db Author: Rami Rosen <ramirose@gmail.com> Date: Fri May 17 09:10:34 2013 +0000 Documentation/sysctl/net.txt: fix (attribute removal). This patch removes mentioning the sysfsf net_device weight attribute (class/net/<device>/weight) in Documentation/sysctl/net.txt, since the net sysfs weight attribute was removed by the following patch: [NET]: Make NAPI polling independent of struct net_device objects bea3348eef27e6044b6161fd04c3152215f96411 Signed-off-by: Rami Rosen <ramirose@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net> -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply@novell.com