New subject: [Bug 491043] cdrdao-1.2.2-308.57: dodgy switch code

1 Apr 2009


      https://bugzilla.novell.com/show_bug.cgi?id=491043
Summary: cdrdao-1.2.2-308.57: dodgy switch code
    Classification: openSUSE
           Product: openSUSE 11.2
           Version: Factory
          Platform: All
        OS/Version: openSUSE 11.1
            Status: NEW
          Severity: Normal
          Priority: P5 - None
         Component: Other
        AssignedTo: bnc-team-screening@forge.provo.novell.com
        ReportedBy: dcb314@hotmail.com
         QAContact: qa@suse.de
          Found By: ---
I just tried to build Factory package cdrdao-1.2.2-308.57
and the build said
TrackData.cc:401: warning: case label value exceeds maximum value for type
The source code is
switch (dataFileLength(filename_, offset_, &len) != 0) {
      case 1:
        message(-2, "Track %d: Cannot open data file "%s": %s", trackNr,
                filename_, strerror(errno));
        return 2;
        break;
      case 2:
I agree with the compiler. Suggest code rework.
Perhaps the original programmer intended
switch (dataFileLength(filename_, offset_, &len)) {
like the other call to dataFileLength in the same file.
-- 
Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 491043] New: cdrdao-1.2.2-308.57: dodgy switch code