[Bug 524206] New: dosemu-1.4.0.1-61.7: possible missing call to fclose
http://bugzilla.novell.com/show_bug.cgi?id=524206 Summary: dosemu-1.4.0.1-61.7: possible missing call to fclose Classification: openSUSE Product: openSUSE 11.2 Version: Factory Platform: All OS/Version: openSUSE 11.1 Status: NEW Severity: Normal Priority: P5 - None Component: Other AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: dcb314@hotmail.com QAContact: qa@suse.de Found By: --- I just had a look at factory package dosemu-1.4.0.1-61.7 For source code file dosemu-1.4.0/src/base/serial/ser_init.c, around line 187 is the source code for the function tty_lock. I notice the following code fd = fopen(saved_path,"w"); but no matching call to fclose. This looks like a resource leak to me. Suggest code rework. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=524206 Marcus Meissner <meissner@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|bnc-team-screening@forge.pr |snwint@novell.com |ovo.novell.com | -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=524206 User dcb314@hotmail.com added comment http://bugzilla.novell.com/show_bug.cgi?id=524206#c1 --- Comment #1 from David Binderman <dcb314@hotmail.com> 2009-09-30 07:08:12 MDT --- (In reply to comment #0)
Suggest code rework.
I had a deeper look and it seems to me that fd is unused, so it looks like it can be safely deleted. Nothing has happened on this bug report for more than two months. Can I be sure this will be fixed for 11.2 ? -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=524206 User snwint@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=524206#c2 --- Comment #2 from Steffen Winterfeldt <snwint@novell.com> 2009-09-30 08:23:14 MDT --- When I get to it; it's low prio, though. If you have a patch anyway, you can also submit a new package yourself. See http://en.opensuse.org/Build_Service/Collaboration. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=524206 Steffen Winterfeldt <snwint@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - None |P4 - Low -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=524206 User rguenther@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=524206#c3 --- Comment #3 from Richard Guenther <rguenther@novell.com> 2009-10-17 08:54:38 MDT --- David, in case the issues are not introduced by a patch local to openSUSE please report the issues upstream. Packagers, please do not add openSUSE-local patches to fix this kind of errors but forward the bugs upstream and close the bugs as RESOLVED UPSTREAM. Note that it is perfectly fine to have "resource leaks" at the end of a program as the kernel will clean up for you. Manually freeing them only increases binary size and runtime. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=524206 https://bugzilla.novell.com/show_bug.cgi?id=524206#c4 Steffen Winterfeldt <snwint@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |WONTFIX --- Comment #4 from Steffen Winterfeldt <snwint@suse.com> 2014-03-18 08:57:04 CET --- sorry, no time for dosemu -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com