[Bug 524206] New: dosemu-1.4.0.1-61.7: possible missing call to fclose
![](https://seccdn.libravatar.org/avatar/3035b38ff33cf86f480bb169b8500b80.jpg?s=120&d=mm&r=g)
http://bugzilla.novell.com/show_bug.cgi?id=524206 Summary: dosemu-1.4.0.1-61.7: possible missing call to fclose Classification: openSUSE Product: openSUSE 11.2 Version: Factory Platform: All OS/Version: openSUSE 11.1 Status: NEW Severity: Normal Priority: P5 - None Component: Other AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: dcb314@hotmail.com QAContact: qa@suse.de Found By: --- I just had a look at factory package dosemu-1.4.0.1-61.7 For source code file dosemu-1.4.0/src/base/serial/ser_init.c, around line 187 is the source code for the function tty_lock. I notice the following code fd = fopen(saved_path,"w"); but no matching call to fclose. This looks like a resource leak to me. Suggest code rework. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
![](https://seccdn.libravatar.org/avatar/3035b38ff33cf86f480bb169b8500b80.jpg?s=120&d=mm&r=g)
http://bugzilla.novell.com/show_bug.cgi?id=524206
Marcus Meissner
![](https://seccdn.libravatar.org/avatar/3035b38ff33cf86f480bb169b8500b80.jpg?s=120&d=mm&r=g)
http://bugzilla.novell.com/show_bug.cgi?id=524206
User dcb314@hotmail.com added comment
http://bugzilla.novell.com/show_bug.cgi?id=524206#c1
--- Comment #1 from David Binderman
Suggest code rework.
I had a deeper look and it seems to me that fd is unused, so it looks like it can be safely deleted. Nothing has happened on this bug report for more than two months. Can I be sure this will be fixed for 11.2 ? -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
![](https://seccdn.libravatar.org/avatar/3035b38ff33cf86f480bb169b8500b80.jpg?s=120&d=mm&r=g)
http://bugzilla.novell.com/show_bug.cgi?id=524206
User snwint@novell.com added comment
http://bugzilla.novell.com/show_bug.cgi?id=524206#c2
--- Comment #2 from Steffen Winterfeldt
![](https://seccdn.libravatar.org/avatar/3035b38ff33cf86f480bb169b8500b80.jpg?s=120&d=mm&r=g)
http://bugzilla.novell.com/show_bug.cgi?id=524206
Steffen Winterfeldt
![](https://seccdn.libravatar.org/avatar/3035b38ff33cf86f480bb169b8500b80.jpg?s=120&d=mm&r=g)
http://bugzilla.novell.com/show_bug.cgi?id=524206
User rguenther@novell.com added comment
http://bugzilla.novell.com/show_bug.cgi?id=524206#c3
--- Comment #3 from Richard Guenther
![](https://seccdn.libravatar.org/avatar/3035b38ff33cf86f480bb169b8500b80.jpg?s=120&d=mm&r=g)
https://bugzilla.novell.com/show_bug.cgi?id=524206
https://bugzilla.novell.com/show_bug.cgi?id=524206#c4
Steffen Winterfeldt
participants (1)
-
bugzilla_noreply@novell.com