[Bug 523444] New: blktrace-1.0.1-2.8: memory leak found

older
[Bug 557563] New: Update Eclipse...

bugzilla_noreply＠novell.com

20 Jul 2009 20 Jul '09

10:42

http://bugzilla.novell.com/show_bug.cgi?id=523444 Summary: blktrace-1.0.1-2.8: memory leak found Classification: openSUSE Product: openSUSE 11.2 Version: Factory Platform: All OS/Version: openSUSE 11.1 Status: NEW Severity: Normal Priority: P5 - None Component: Other AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: dcb314@hotmail.com QAContact: qa@suse.de Found By: --- I just had a look at factory package blktrace-1.0.1-2.8 For source code blktrace-1.0.1/btreplay/btrecord.c, around line 371 is the source code for the function find_input_files. I notice that every time the continue statement is executed, the function leaks 256 bytes. Suggest code rework. Maybe the following would be suitable if (strstr(ent->d_name, ".blktrace.") == NULL) continue; char *p, *dsf = malloc(256); to ensure the call to malloc only happens after the continue. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Show replies by date

bugzilla_noreply＠novell.com

20 Jul 20 Jul

15:08

New subject: [Bug 523444] blktrace-1.0.1-2.8: memory leak found

http://bugzilla.novell.com/show_bug.cgi?id=523444 Marcus Meissner changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|bnc-team-screening@forge.pr |jblunck@novell.com |ovo.novell.com | -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

bugzilla_noreply＠novell.com

21 Jul 21 Jul

08:33

New subject: [Bug 523444] blktrace-1.0.1-2.8: memory leak found

http://bugzilla.novell.com/show_bug.cgi?id=523444 Jan Blunck changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - None |P3 - Medium Status|NEW |ASSIGNED -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

bugzilla_noreply＠novell.com

08:34

New subject: [Bug 523444] blktrace-1.0.1-2.8: memory leak found

http://bugzilla.novell.com/show_bug.cgi?id=523444 User jblunck@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=523444#c1 --- Comment #1 from Jan Blunck 2009-07-21 02:34:55 MDT --- Even worse the memory allocated by malloc() is immediately leaked by the first assignment to the dsf pointer. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

bugzilla_noreply＠novell.com

09:53

New subject: [Bug 523444] blktrace-1.0.1-2.8: memory leak found

http://bugzilla.novell.com/show_bug.cgi?id=523444 User jblunck@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=523444#c2 --- Comment #2 from Jan Blunck 2009-07-21 03:53:30 MDT --- Created an attachment (id=306431) --> (http://bugzilla.novell.com/attachment.cgi?id=306431) Proposed patch This patch just removes the unnecessary call to malloc. I'll send it to the blktrace mailing list if you don't want to do that yourself. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

bugzilla_noreply＠novell.com

10:43

New subject: [Bug 523444] blktrace-1.0.1-2.8: memory leak found

http://bugzilla.novell.com/show_bug.cgi?id=523444 User dcb314@hotmail.com added comment http://bugzilla.novell.com/show_bug.cgi?id=523444#c3 --- Comment #3 from David Binderman 2009-07-21 04:43:10 MDT --- (In reply to comment #2)

...

I'll send it to the blktrace mailing list

Go right ahead. Thanks for looking into this. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

bugzilla_noreply＠novell.com

8 Sep 8 Sep

22:12

New subject: [Bug 523444] blktrace-1.0.1-2.8: memory leak found

http://bugzilla.novell.com/show_bug.cgi?id=523444 User dcb314@hotmail.com added comment http://bugzilla.novell.com/show_bug.cgi?id=523444#c4 --- Comment #4 from David Binderman 2009-09-08 16:12:10 MDT --- (In reply to comment #2)

...

This patch just removes the unnecessary call to malloc. I'll send it to the blktrace mailing list

I just checked version 1.0.1-3.13 and the bug still exists. Does this patch need to be applied to the Factory version, or is there some other process to get it into Factory ? -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

bugzilla_noreply＠novell.com

17 Oct 17 Oct

14:54

New subject: [Bug 523444] blktrace-1.0.1-2.8: memory leak found

http://bugzilla.novell.com/show_bug.cgi?id=523444 User rguenther@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=523444#c5 --- Comment #5 from Richard Guenther 2009-10-17 08:54:32 MDT --- David, in case the issues are not introduced by a patch local to openSUSE please report the issues upstream. Packagers, please do not add openSUSE-local patches to fix this kind of errors but forward the bugs upstream and close the bugs as RESOLVED UPSTREAM. Note that it is perfectly fine to have "resource leaks" at the end of a program as the kernel will clean up for you. Manually freeing them only increases binary size and runtime. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

bugzilla_noreply＠novell.com

20 Jul 20 Jul

08:31

New subject: [Bug 523444] blktrace-1.0.1-2.8: memory leak found

http://bugzilla.novell.com/show_bug.cgi?id=523444 http://bugzilla.novell.com/show_bug.cgi?id=523444#c6 Jan Blunck changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |UPSTREAM --- Comment #6 from Jan Blunck 2010-07-20 08:31:43 UTC --- Patch is in openSUSE:Factory and submitted to blktrace mailing list. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

5040

Age (days ago)

5405

Last active (days ago)

List overview

Download

8 comments

1 participants

participants (1)

bugzilla_noreply＠novell.com

[Bug 523444] New: blktrace-1.0.1-2.8: memory leak found

tags

participants (1)