[Bug 698946] New: Apparent buglet in resolve_device in mkinitrd
https://bugzilla.novell.com/show_bug.cgi?id=698946 https://bugzilla.novell.com/show_bug.cgi?id=698946#c0 Summary: Apparent buglet in resolve_device in mkinitrd Classification: openSUSE Product: openSUSE 11.4 Version: Factory Platform: All OS/Version: openSUSE 11.4 Status: NEW Severity: Normal Priority: P5 - None Component: Basesystem AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: nfbrown@novell.com QAContact: qa@suse.de Found By: --- Blocker: --- User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:2.0.1) Gecko/20100101 Firefox/4.0.1 In mkinitrd, in mkinitrd-2.7.0/scripts/setup-storage.sh there is a function 'resolve_device' which contains: realrootdev=$(fsck -N "$rootdev" \ | sed -ne '2s/.* \/dev/\/dev/p' \ | sed -e 's/ *//g') I'm fairly sure that "$rootdev" should be "$realrootdev". As it is, if resumedev, journaldev or dumpdev are specified as LABEL= or UUID=, they will get confused with the root device. (I don't think this is causing the issue that I am hunting for, but it looks wrong so I thought I would mention it). Reproducible: Always Steps to Reproduce: 1. Read the code 2. 3. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=698946 https://bugzilla.novell.com/show_bug.cgi?id=698946#c zj jia <zjjia@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zjjia@novell.com AssignedTo|bnc-team-screening@forge.pr |mmarek@novell.com |ovo.novell.com | -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=698946 https://bugzilla.novell.com/show_bug.cgi?id=698946#c1 --- Comment #1 from Michal Marek <mmarek@novell.com> 2011-06-14 08:51:30 UTC --- This line [ -b "$realrootdev" ] || exit 0 looks also scary, given that all the scripts run in the same shell. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=698946 https://bugzilla.novell.com/show_bug.cgi?id=698946#c2 Michal Marek <mmarek@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #2 from Michal Marek <mmarek@novell.com> 2011-06-30 09:50:28 UTC --- Fixed in SLES-11-SP2 and master branch of http://gitorious.org/opensuse/mkinitrd. The exit statement turned out to be harmless, as the function runs in a subshell, but I changed it to return nevertheless. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=698946 https://bugzilla.novell.com/show_bug.cgi?id=698946#c3 --- Comment #3 from Bernhard Wiedemann <bwiedemann@novell.com> 2011-07-01 12:00:19 CEST --- This is an autogenerated message for OBS integration: This bug (698946) was mentioned in https://build.opensuse.org/request/show/74968 Factory / mkinitrd -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com