[Bug 892834] New: Ext4 support of RichACL is broken
https://bugzilla.novell.com/show_bug.cgi?id=892834 https://bugzilla.novell.com/show_bug.cgi?id=892834#c0 Summary: Ext4 support of RichACL is broken Classification: openSUSE Product: openSUSE 13.1 Version: Final Platform: x86-64 OS/Version: openSUSE 13.1 Status: NEW Severity: Normal Priority: P5 - None Component: Kernel AssignedTo: kernel-maintainers@forge.provo.novell.com ReportedBy: novell@roblucke.com QAContact: qa-bugs@suse.de Found By: --- Blocker: --- Created an attachment (id=602982) --> (http://bugzilla.novell.com/attachment.cgi?id=602982) repaired /usr/src/linux/fs/ext4/richacl.c User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Firefox/31.0 I know this is experimental and alpha. I am investigating NFSv4, CIFS, and POSIX ACLs and wanted to test the richacl implementation in OpenSuSE 13.1. The kernel configuration is non-functional, although the code is present. The kernel configuration clause in /usr/src/linux/fs/ext4/Kconfig depends upon a non-existent variable: EXT4_FS_XATTR. Once the dependency clause is removed, the code can be configured properly. Building the code encounters an error with one of the macros in richacl.c handle = ext4_journal_start( inode, EXT4_DATA_TRANS_BLOCKS(inode->i_sb)); ext4_journal)start() requires three parameters. I have approximated a fix with: handle = ext4_journal_start( inode, EXT4_HT_XATTR, (EXT4_DATA_TRANS_BLOCKS(inode->i_sb) + 1)); This may or may not be correct. (-;]> The code now builds. There apparently is a change in the richacl.h definition of the ACE bits, however, so it is necessary to know which version of the richacl-tools is required to match the code in the /usr/src/fs/ext4 directory (without extracting every git commit and comparing). Is there a way to get the appropriate tools? I know where they are at github. It would be really nice to have this working for my study, but I understand "EXPERIMENTAL", and "ALPHA". Reproducible: Always Steps to Reproduce: 1.Try to enable richacls with menuconfig or xconfig 2.Fix configuration in Kconfig 3.Build code and get error 4.Fix code and build kernel 5.Get richacl-tools v1.0 and attempt to manipulate acls in FS mounted with "richacl" option -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=892834 https://bugzilla.novell.com/show_bug.cgi?id=892834#c1 Takashi Iwai <tiwai@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tiwai@suse.com AssignedTo|kernel-maintainers@forge.pr |jack@suse.com |ovo.novell.com | --- Comment #1 from Takashi Iwai <tiwai@suse.com> 2014-08-26 15:53:38 UTC --- Jan, could you take a look? richacl stuff is still included in FACTORY (although not in SLE), so it's worth to check. Or we should drop it :) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=892834 https://bugzilla.novell.com/show_bug.cgi?id=892834#c2 Jan Kara <jack@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO InfoProvider| |jeffm@suse.com --- Comment #2 from Jan Kara <jack@suse.com> 2014-08-26 16:19:06 UTC --- So the patches have been dropped from SLE12 because only ext4 supports the feature and thus Samba doesn't plan to use it. For openSUSE they may still have some value though if someone is willing to build something custom. Jeff, what is your take on this? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=892834 https://bugzilla.novell.com/show_bug.cgi?id=892834#c3 Jeff Mahoney <jeffm@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |NEW CC| |jeffm@suse.com InfoProvider|jeffm@suse.com | --- Comment #3 from Jeff Mahoney <jeffm@suse.com> 2014-08-26 12:22:29 EDT --- We should just drop it. They were never officially adopted and the code has been dragged forward between releases with only build testing (as the reporter as noticed.) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=892834 https://bugzilla.novell.com/show_bug.cgi?id=892834#c4 --- Comment #4 from Rob Lucke <novell@roblucke.com> 2014-08-26 16:57:28 UTC --- Hi, I would hope you wouldn't really drop the feature. I know it may later be added upstream. Investigating ACLs has been interesting. POSIX ACLs are based on a withdrawn specification. Windows ACLs are not directly supported. The NFSv4 ACLs can only be used/set/changed from the NFSv4 client. What we really need is a form of ACL that can be used natively on the physical file system and yet be compatible with Windows and NFSv4. It looks to me like the richacls have that possibility. Trying to do file serving and keeping all this straight is a nightmare. To support the experimental richacl scheme isn't that difficult, the steps I followed are pretty easy. The difficulty is the patch version and the tools version have to match (I assume that there will be no further changes in the bits used to represent the permissions). If the code could be brought up to match the version 1.0 tools now available, that would allow continued experimentation. Thanks for the attention on this. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=892834 https://bugzilla.novell.com/show_bug.cgi?id=892834#c5 Andreas Gruenbacher <agruen@linbit.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |agruen@linbit.com --- Comment #5 from Andreas Gruenbacher <agruen@linbit.com> 2014-08-27 12:58:17 UTC --- I agree with Rob that something like richacls is needed for reasonable Windows and NFSv4 ACL support / compatibility, and also with Jeff that it doesn't make sense to keep this feature in openSUSE when it isn't clear if and when this code will make it into mainline, and nobody at SUSE is using this. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply@novell.com