[Bug 441078] New: Old extra repositories vanished after update
https://bugzilla.novell.com/show_bug.cgi?id=441078 Summary: Old extra repositories vanished after update Product: openSUSE 11.1 Version: Beta4 Platform: Other OS/Version: Other Status: NEW Severity: Critical Priority: P5 - None Component: Update Problems AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: kukuk@novell.com QAContact: jsrain@novell.com Found By: --- Created an attachment (id=249385) --> (https://bugzilla.novell.com/attachment.cgi?id=249385) y2logs.tgz during update I explicit re-enabled some repositories, but when the update was finished, they all were completly removed, not even only disabled. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=441078 Andreas Jaeger <aj@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|bnc-team-screening@forge.provo.novell.com |zypp-maintainers@forge.provo.novell.com -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=441078 Duncan Mac-Vicar <dmacvicar@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lslezak@novell.com, dmacvicar@novell.com AssignedTo|zypp-maintainers@forge.provo.novell.com |locilka@novell.com -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=441078 User locilka@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=441078#c1 Lukas Ocilka <locilka@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |locilka@novell.com AssignedTo|locilka@novell.com |lslezak@novell.com --- Comment #1 from Lukas Ocilka <locilka@novell.com> 2008-11-07 07:35:24 MST --- y2log-1 (the end of the first (the only) stage): Adding repository 'openSUSE-dvd 11.1-0' Adding repository 'repo' Adding repository 'openSUSE-11.1-Updates' Adding repository 'repo-oss' Adding repository 'repo-non-oss' Adding repository 'repo-debug' Adding repository 'openSUSE-dvd 11.1-0' Adding repository 'factory' Adding repository 'factory-non-oss' Adding repository 'openSUSE-11.0-Updates' Adding repository 'http://download.opensuse.org/distribution/11.0/repo/non-oss/' Adding repository 'updates' Adding repository 'openSUSE-DVD_11.0' Adding repository 'openSUSE-Tools' Adding repository 'repo' Adding repository 'openSUSE-11.1-Updates' Adding repository 'repo-oss' Adding repository 'repo-non-oss' Adding repository 'repo-debug' Source_Save.cc(SourceSaveAll):231 All sources have been saved For instance this Adding repo (disabled): $["alias":"openSUSE-11.0-Updates", "autorefresh":true, "base_urls":["http://download.opensuse.org/update/11.0/"], "enabled":false, "keeppackages":false, "name":"", "prod_dir":"/"] repository has been re-added as disabled. grep "Repo exception" y2log-1 shows 19x "RepoManager.cc(getRepositoryInfo):1475 THROW: RepoManager.cc(getRepositoryInfo):1475: Repo exception" Who to blame? Pkg-bindings or libzypp? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=441078 User lslezak@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=441078#c2 Ladislav Slezak <lslezak@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Priority|P5 - None |P2 - High --- Comment #2 from Ladislav Slezak <lslezak@novell.com> 2008-11-07 07:41:37 MST --- I'll check it... -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=441078 User lslezak@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=441078#c3 Ladislav Slezak <lslezak@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|lslezak@novell.com |dmacvicar@novell.com Status|ASSIGNED |NEW --- Comment #3 from Ladislav Slezak <lslezak@novell.com> 2008-11-10 08:34:15 MST --- The problem is probably in libzypp, yast removes all old repositories and then saves the current configuration: 2008-11-03 14:57:20 <1> firun(3794) [YCP] clients/pkg_finish.ycp:82 All old repositories were removed from the target 2008-11-03 14:57:20 <1> firun(3794) [Pkg] clients/pkg_finish.ycp:144 Pkg Builtin called: SourceSaveAll The problem is that there are these exceptions after saving .repo file in the log: 2008-11-03 14:57:20 <1> firun(3794) [zypp] RepoManager.cc(addRepository):1233 Saving repo in /mnt/etc/zypp/repos.d/factory.repo .. 2008-11-03 14:57:20 <5> firun(3794) [zypp] Exception.cc(log):119 RepoManager.cc(getRepositoryInfo):1475 THROW: RepoManager.c c(getRepositoryInfo):1475: Repo exception There is no detailed description, I don't know what happened exactly. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=441078 User dmacvicar@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=441078#c4 Duncan Mac-Vicar <dmacvicar@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|dmacvicar@novell.com |lslezak@novell.com --- Comment #4 from Duncan Mac-Vicar <dmacvicar@novell.com> 2008-11-24 08:04:14 MST --- That means someone is requesting info about a repository that does not exist. If you see the docs, that function getRepositoryInfo THROWS in certain cases. And in Source_Save.cc you use it without catching those exceptions. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=441078 Ladislav Slezak <lslezak@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=441078 User dmacvicar@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=441078#c5 --- Comment #5 from Duncan Mac-Vicar <dmacvicar@novell.com> 2008-11-24 09:41:27 MST --- Also you may want to check why are you requesting information about a repository which does not exist anymore? may be you do that after deleting them? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=441078 User lslezak@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=441078#c6 --- Comment #6 from Ladislav Slezak <lslezak@novell.com> 2008-11-24 09:53:32 MST --- Yes, pkg_finish.ycp removes old repositories and then saves the current settings. .. 2008-11-03 14:57:20 <1> firun(3794) [YCP] clients/pkg_finish.ycp:74 Removing target repository /etc/zypp/repos.d/openSUSE-Tools repo 2008-11-03 14:57:20 <1> firun(3794) [YCP] clients/pkg_finish.ycp:82 All old repositories were removed from the target 2008-11-03 14:57:20 <1> firun(3794) [Pkg] clients/pkg_finish.ycp:144 Pkg Builtin called: SourceSaveAll But the exception is caught: try { // if the repository already exists then just modify it repomanager.getRepositoryInfo(current_alias); y2milestone("Modifying repository '%s'", current_alias.c_str()); repomanager.modifyRepository(current_alias, (*it)->repoInfo()); } catch (const zypp::repo::RepoNotFoundException &ex) { // the repository was not found, add it y2milestone("Adding repository '%s'", current_alias.c_str()); repomanager.addRepository((*it)->repoInfo()); } So if the repo file exists is uses modifyRepository() if not (RepoNotFoundException exception has been caught) addRepository() is used. That is correct, isn't it? According to the log the repos should have been added: 2008-11-03 14:57:20 <5> firun(3794) [zypp] Exception.cc(log):119 RepoManager.cc(getRepositoryInfo):1475 THROW: RepoManager.c c(getRepositoryInfo):1475: Repo exception 2008-11-03 14:57:20 <1> firun(3794) [Pkg] Source_Save.cc(SourceSaveAll):216 Adding repository 'factory' 2008-11-03 14:57:20 <1> firun(3794) [Pkg] Callbacks.cc(start):461 ProgressStart: id:1844, Füge Repository 'factory' hinzu 2008-11-03 14:57:20 <1> firun(3794) [Pkg] Callbacks.cc(progress):481 ProgressProgress: id:1844, Füge Repository 'factory' hinzu: 0% 2008-11-03 14:57:20 <1> firun(3794) [Pkg] Callbacks.cc(progress):481 ProgressProgress: id:1844, Füge Repository 'factory' hinzu: 50% 2008-11-03 14:57:20 <1> firun(3794) [zypp] RepoManager.cc(generateFilename):445 generating filename for repo [factory] : './factory.repo' 2008-11-03 14:57:20 <1> firun(3794) [zypp] RepoManager.cc(addRepository):1233 Saving repo in /mnt/etc/zypp/repos.d/factory.repo 2008-11-03 14:57:20 <1> firun(3794) [Pkg] Callbacks.cc(progress):481 ProgressProgress: id:1844, Füge Repository 'factory' hinzu: 90% 2008-11-03 14:57:20 <1> firun(3794) [Pkg] Callbacks.cc(progress):481 ProgressProgress: id:1844, Füge Repository 'factory' hinzu: 100% 2008-11-03 14:57:20 <1> firun(3794) [zypp] RepoManager.cc(addRepository):1269 done 2008-11-03 14:57:20 <1> firun(3794) [Pkg] Callbacks.cc(progress):481 ProgressProgress: id:1844, Füge Repository 'factory' hinzu: 100% 2008-11-03 14:57:20 <1> firun(3794) [Pkg] Callbacks.cc(finish):498 ProgressFinish: id:1844, Füge Repository 'factory' hinzu -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=441078 User dmacvicar@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=441078#c7 --- Comment #7 from Duncan Mac-Vicar <dmacvicar@novell.com> 2008-11-24 10:07:28 MST --- you are catching only one exception type then. getRepositoryInfo is called from modifyRepository, which may throw a RepoAlreadyExistsException or even simple unknown Exception. RepoAlreadyExistsException if the alias specified in newinfo is already used by another repository RepoNotFoundException If no repo match ParseException If the file parsing fails Exception On other errors. If you catch one exception, you should always catch Exception too. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=441078 User lslezak@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=441078#c8 --- Comment #8 from Ladislav Slezak <lslezak@novell.com> 2008-11-24 10:20:24 MST --- Sorry, the code excerpt in comment #6 is not compby this block: catch (zypp::Exception & excpt) { y2error("Pkg::SourceSaveAll has failed: %s", excpt.msg().c_str() ); _last_error.setLastError(ExceptionAsString(excpt)); return YCPBoolean(false); } see pkg-bindings/src/Source_Save.cc, line ~210 "Pkg::SourceSaveAll has failed" is not logged, so the caught exception must be RepoNotFoundException and nothing else. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=441078 User lslezak@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=441078#c9 Ladislav Slezak <lslezak@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEEDINFO Info Provider| |kukuk@novell.com --- Comment #9 from Ladislav Slezak <lslezak@novell.com> 2008-11-25 10:22:03 MST --- Um, I wasn't able to reproduce it in Beta5 (I tested update from 11.0 to 11.1-Beta5 in a VBox VM). The additional repositories (nvidia + packman) were in the system after update. Thorsten, could you reproduce it in Beta5 (or RC1)? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=441078 User kukuk@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=441078#c10 Thorsten Kukuk <kukuk@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |ASSIGNED Info Provider|kukuk@novell.com | --- Comment #10 from Thorsten Kukuk <kukuk@novell.com> 2008-11-25 11:39:28 MST --- I cannot reproduce since the machine is already updated and the repositories are vanished. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=441078 User lslezak@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=441078#c11 --- Comment #11 from Ladislav Slezak <lslezak@novell.com> 2008-11-25 11:53:52 MST --- Well, you can try updating it to RC1 later. The old repos are backed up in /var/lib/YaST2/repos.d_backup/ dir so it should be easy to restore the original config before new update attempt. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=441078 User coolo@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=441078#c12 Stephan Kulow <coolo@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|Critical |Major Flag| |SHIP_STOPPER- --- Comment #12 from Stephan Kulow <coolo@novell.com> 2008-11-26 03:27:47 MST --- backup -> no dataloss -> not critical -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=441078 User lslezak@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=441078#c13 Ladislav Slezak <lslezak@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |WORKSFORME --- Comment #13 from Ladislav Slezak <lslezak@novell.com> 2008-12-02 09:12:28 MST --- I just have tested update from 11.0 to 11.1RC2, the old repos were present in the system after update. Resolving as WORKSFORME. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com