https://bugzilla.novell.com/show_bug.cgi?id=753935 https://bugzilla.novell.com/show_bug.cgi?id=753935#c1 Jiří Suchomel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO CC| |jsuchome@suse.com InfoProvider| |suse-beta@cboltz.de --- Comment #1 from Jiří Suchomel 2013-06-20 07:33:22 UTC --- There's not rpm comparision in your case, but YaST compares the file against some stored checksum, which should be saved in /var/lib/YaST2/file_checksums.ycp I do not know when the checksum was created, my guess is in some previous call of ntp-client module. Did you run it manually? Or during installation? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=753935 https://bugzilla.novell.com/show_bug.cgi?id=753935#c3 Jiří Suchomel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO InfoProvider| |max@suse.com --- Comment #3 from Jiří Suchomel 2013-06-21 00:49:30 UTC --- Yes, I think your guess might be correct one. Reducing to the rpm -V check would mean that every time you run yast2 ntp-client, you'll get the message. I think the point of checking the checksum (written by ntp-client at write time) was to really check only manual changes, and do not warn about changes done by YaST. Maybe the correct solution would be to delete /var/lib/YaST2/file_checksums.ycp at update. Or maybe just delete "/etc/ntp.conf" entry from the file, when the package is updated... but I'm not sure if "ntp" package maintainer would like to add such script into rpm.... Reinhard? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=753935 https://bugzilla.novell.com/show_bug.cgi?id=753935#c4 Reinhard Max changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |NEW CC| |max@suse.com InfoProvider|max@suse.com | --- Comment #4 from Reinhard Max 2013-06-21 03:48:45 CEST --- How about this algorithm for the YaST module? If no checksum exists If rpm -V reports the file as unchanged Proceed in changing the file. Create the checksum,but only if the file was actually changed. If rpm -V reports the file as changed Report the file as manually edited. If a checksum exists If the checksum matches the file Proceed in changing the file and update the checksum. If the checksum does not match the file Report the file as manually edited. This way a checksum will only exist if YaST really touched the file, and at that point due to the file being packaged as %config(noreplace) it will never get replaced by the new version on update. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=753935 https://bugzilla.novell.com/show_bug.cgi?id=753935#c6 --- Comment #6 from Reinhard Max 2013-06-21 04:45:19 CEST --- (In reply to comment #5)

(In reply to comment #4) Hm, but in reported case, checksum did exist and that was the reason for YaST to show a warning.

Yes, but it probably got created from an untouched config file, which then got replaced by an update. This wouldn't happen in my algorithm, because the checksum would only get created when YaST really changes the file.

Wasn't it really possible that ntp itself replaced the file during the update (see comment 2)?

Due to %config(noreplace) the package only replaces the config file if it wasn't changed. If it was changed, the old one stays in place and the new one gets installed as ntp.conf.rpmnew. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=753935 https://bugzilla.novell.com/show_bug.cgi?id=753935#c8 Jiří Suchomel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |NEW InfoProvider|max@suse.com | --- Comment #8 from Jiří Suchomel 2013-06-21 06:42:09 UTC --- (In reply to comment #6)

(In reply to comment #5)

...

(In reply to comment #4) Hm, but in reported case, checksum did exist and that was the reason for YaST to show a warning.

Yes, but it probably got created from an untouched config file, which then got replaced by an update.

This is unlikely, according to the code in NtpClient.ycp - the checksum gets created right after YaST writes the file. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=753935 https://bugzilla.novell.com/show_bug.cgi?id=753935#c Alberto Planas Dominguez changed: What |Removed |Added ---------------------------------------------------------------------------- Status Whiteboard| | GOLD -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.