[Bug 941629] New: config.rpath from gettext-tools adds unnessary rpaths in x86_64 builds
http://bugzilla.opensuse.org/show_bug.cgi?id=941629 Bug ID: 941629 Summary: config.rpath from gettext-tools adds unnessary rpaths in x86_64 builds Classification: openSUSE Product: openSUSE.org Version: unspecified Hardware: x86-64 OS: All Status: NEW Severity: Normal Priority: P5 - None Component: 3rd party software Assignee: pth@suse.com Reporter: i@marguerite.su QA Contact: opensuse-communityscreening@forge.provo.novell.com Found By: Community User Blocker: --- Hi, I found two unnessary rpaths are added to LDFLAGS during building Cinnamon: https://build.opensuse.org/build/home:MargueriteSu:branches:X11:Cinnamon:Fac... <pre> [ 98s] libtool: link: gcc -fmessage-length=0 -grecord-gcc-switches -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector -funwind-tables -fasynchronous-unwind-tables -g -Wmissing-prototypes -o test-theme st/test_theme-test-theme.o ./.libs/libst-1.0.a -lclutter-1.0 -lcogl-path -lcogl-pango -lcogl -lgmodule-2.0 -lwayland-egl -lgbm -ldrm -lEGL -lXrandr -ljson-glib-1.0 -lwayland-cursor -lwayland-client -lxkbcommon -lwayland-server -lXext -lXdamage -lXfixes -lXcomposite -lXi -lcroco-0.6 /usr/lib64/libxml2.so -ldl -lz -llzma -lm -lcinnamon-desktop -lgtk-3 -lgdk-3 -lpangocairo-1.0 -lpango-1.0 -latk-1.0 -lcairo-gobject -lcairo -lgdk_pixbuf-2.0 -lgio-2.0 -lgobject-2.0 -lglib-2.0 -lX11 -pthread -Wl,-rpath -Wl,/usr/lib64 -Wl,-rpath -Wl,/usr/lib64 </pre> by grep in the build directory, I found those two rpaths comes from config.rpath: <pre> d_shlibs=yes if test "$with_gnu_ld" = yes; then # Set some defaults for GNU ld with shared library support. These # are reset later if shared libraries are not supported. Putting them # here allows them to be overridden if necessary. # Unlike libtool, we use -rpath here, not --rpath, since the documented # option of GNU ld is called -rpath, not --rpath. hardcode_libdir_flag_spec='${wl}-rpath ${wl}$libdir' case "$host_os" in </pre> it seems that x86_64 didn't pass the host_os test. please have a look -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=941629 http://bugzilla.opensuse.org/show_bug.cgi?id=941629#c1 --- Comment #1 from Marguerite Su <i@marguerite.su> --- <pre> gnu* | linux* | tpf* | k*bsd*-gnu | kopensolaris*-gnu) if $LD --help 2>&1 | grep ': supported targets:.* elf' > /dev/null; then : else ld_shlibs=no fi ;; </pre> My `ld --help | grep "supported targets"` shows nothing. So I suppose ld_shlibs should be no. and then: <pre> if test "$ld_shlibs" = no; then hardcode_libdir_flag_spec= fi </pre> hardcode_libdir_flag_spec should be null. But unluckily it was not like that... -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=941629 http://bugzilla.opensuse.org/show_bug.cgi?id=941629#c2 --- Comment #2 from Marguerite Su <i@marguerite.su> --- sorry, ld --help | grep ': supported targets:.* elf' <pre> ld: supported targets: elf64-x86-64 elf32-i386 elf32-x86-64 a.out-i386-linux pei-i386 pei-x86-64 elf64-l1om elf64-k1om elf64-little elf64-big elf32-little elf32-big elf64-littleaarch64 elf64-bigaarch64 elf32-littleaarch64 elf32-bigaarch64 elf32-littlearm elf32-bigarm elf64-alpha ecoff-littlealpha elf32-hppa-linux elf32-hppa elf64-hppa-linux elf64-hppa elf64-ia64-little elf64-ia64-big pei-ia64 elf32-m68k a.out-m68k-linux elf32-tradbigmips elf32-tradlittlemips ecoff-bigmips ecoff-littlemips elf32-ntradbigmips elf64-tradbigmips elf32-ntradlittlemips elf64-tradlittlemips elf32-powerpc aixcoff-rs6000 elf32-powerpcle ppcboot elf64-powerpc elf64-powerpcle aixcoff64-rs6000 aix5coff64-rs6000 elf32-s390 elf64-s390 elf32-sh-linux elf32-shbig-linux elf32-sparc a.out-sparc-linux elf64-sparc a.out-sunos-big xcoff-powermac mach-o-be mach-o-le mach-o-fat pef pef-xlib sym elf32-spu pe-x86-64 pe-bigobj-x86-64 pe-i386 plugin srec symbolsrec verilog tekhex binary ihex </pre> it returns true...so "-Wl,-rpath -Wl,/usr/lib64" is set -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=941629 http://bugzilla.opensuse.org/show_bug.cgi?id=941629#c3 --- Comment #3 from Marguerite Su <i@marguerite.su> --- Is that on purpose or something's wrong with our ld on x86_64? If it was on purpose, how could I workaround it? -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=941629 http://bugzilla.opensuse.org/show_bug.cgi?id=941629#c4 Philipp Thomas <pth@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CONFIRMED --- Comment #4 from Philipp Thomas <pth@suse.com> --- The error is in config.rpath. It seems to always set rpath for ELF binaries not in /usr/lib, even if it's the standard path the linker would search anyways. As gettext is my package, I'll see what I can come up with. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=941629 http://bugzilla.opensuse.org/show_bug.cgi?id=941629#c5 --- Comment #5 from Marguerite Su <i@marguerite.su> --- (In reply to Philipp Thomas from comment #4)
The error is in config.rpath. It seems to always set rpath for ELF binaries not in /usr/lib, even if it's the standard path the linker would search anyways. As gettext is my package, I'll see what I can come up with.
Any updates? -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=941629 http://bugzilla.opensuse.org/show_bug.cgi?id=941629#c10 Marguerite Su <i@marguerite.su> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pth@suse.com Flags| |needinfo?(pth@suse.com) --- Comment #10 from Marguerite Su <i@marguerite.su> --- Hi, Philipp, https://build.opensuse.org/build/home:MargueriteSu:branches:X11:Cinnamon:Fac... The problem still presents. [ 76s] [274/511] cumulate gettext-runtime-mini-0.19.5.1-144.1 which is the patched gettext-runtime-mini: https://build.opensuse.org/package/show/home:MargueriteSu:branches:X11:Cinna... -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=941629 http://bugzilla.opensuse.org/show_bug.cgi?id=941629#c11 Marguerite Su <i@marguerite.su> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(pth@suse.com) | --- Comment #11 from Marguerite Su <i@marguerite.su> --- It was a false alarm, the patch actually works. I created a SR: https://build.opensuse.org/request/show/327897 -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=941629 http://bugzilla.opensuse.org/show_bug.cgi?id=941629#c15 Christian Vögl <christian.voegl@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED --- Comment #15 from Christian Vögl <christian.voegl@suse.com> --- fixed by https://build.opensuse.org/request/show/819271 -- You are receiving this mail because: You are on the CC list for the bug.
participants (2)
-
bugzilla_noreply＠novell.com -
bugzilla_noreply＠suse.com