[Bug 226402] New: iprutils-2.2.3-4: comparison with string literal
https://bugzilla.novell.com/show_bug.cgi?id=226402 Summary: iprutils-2.2.3-4: comparison with string literal Product: openSUSE 10.2 Version: RC 5 Platform: All OS/Version: SuSE Other Status: NEW Severity: Normal Priority: P5 - None Component: Basesystem AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: dcb314@hotmail.com QAContact: qa@suse.de I just tried to build the package iprutils-2.2.3-4 I got the following warning message from the compiler. iprconfig.c:747: warning: comparison with string literal The source code is if ((temp->key == "\n") || I agree with the compiler. Maybe the programmer intended if ((strcmp( temp->key, "\n") == 0) || -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=226402 mhorvath@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|bnc-team- |olh@novell.com |screening@forge.provo.novell| |.com | -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=226402 olh@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=226402 ------- Comment #1 from brking@us.ibm.com 2006-12-06 12:53 MST ------- Created an attachment (id=108571) --> (https://bugzilla.novell.com/attachment.cgi?id=108571&action=view) Proposed iprutils fix Here is my proposed fix for this. I'll add it to the cvs tree as well, so it will be in 2.2.4. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=226402 olh@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED ------- Comment #2 from olh@novell.com 2006-12-07 06:20 MST ------- thanks, patch applied here too. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
participants (1)
-
bugzilla_noreply@novell.com