[Bug 1074711] New: desktop file categories broken
http://bugzilla.opensuse.org/show_bug.cgi?id=1074711 Bug ID: 1074711 Summary: desktop file categories broken Classification: openSUSE Product: openSUSE.org Version: unspecified Hardware: Other OS: Other Status: NEW Severity: Major Priority: P5 - None Component: BuildService Assignee: bnc-team-screening@forge.provo.novell.com Reporter: axel.braun@gmx.de QA Contact: adrian@suse.com Found By: --- Blocker: --- I noticed that a .desktop file with the category definitions Categories=Science;MedicalSoftware;Biology does not work, but if I replace it with Categories=Office;Finance; it builds w/o problems. Error message: [ 46s] ERROR: No sufficient Category definition: /home/abuild/rpmbuild/BUILDROOT/gnuhealth-client-3.2.5-8.1.x86_64//usr/share/applications/gnuhealth-client.desktop [ 46s] Please refer to https://en.opensuse.org/openSUSE:Packaging_desktop_menu_categories according to the page, all three definitions are correct -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1074711
http://bugzilla.opensuse.org/show_bug.cgi?id=1074711#c1
--- Comment #1 from Axel Braun
http://bugzilla.opensuse.org/show_bug.cgi?id=1074711
Sebastian Wagner
http://bugzilla.opensuse.org/show_bug.cgi?id=1074711
http://bugzilla.opensuse.org/show_bug.cgi?id=1074711#c2
Luigi Baldoni
http://bugzilla.opensuse.org/show_bug.cgi?id=1074711
http://bugzilla.opensuse.org/show_bug.cgi?id=1074711#c3
--- Comment #3 from Axel Braun
http://bugzilla.opensuse.org/show_bug.cgi?id=1074711
http://bugzilla.opensuse.org/show_bug.cgi?id=1074711#c4
--- Comment #4 from Adrian Schröter
http://bugzilla.opensuse.org/show_bug.cgi?id=1074711
http://bugzilla.opensuse.org/show_bug.cgi?id=1074711#c5
--- Comment #5 from Axel Braun
It is not enough that the categories are existing, the check verifies that only one menu item gets created. This is to avoid to have the same entry in many menues which will lead to bloat.
I can not see from this report that this is not the case?
The problem is that valid categories were not accepted, not that they were in more than one category -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1074711
http://bugzilla.opensuse.org/show_bug.cgi?id=1074711#c6
--- Comment #6 from Adrian Schröter
http://bugzilla.opensuse.org/show_bug.cgi?id=1074711
http://bugzilla.opensuse.org/show_bug.cgi?id=1074711#c7
--- Comment #7 from Axel Braun
You can create plenty of entries in the menus with a single desktop file just using valid categories. Sorry, but this is a problem in xdg menu system and we want to protect at least our core distro to have crowded menus.
Right, but as stated in comment #5, a valid category should not be rejected as invalid -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1074711
http://bugzilla.opensuse.org/show_bug.cgi?id=1074711#c15
Benjamin Greiner changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |code@bnavigator.de
--- Comment #15 from Benjamin Greiner
---
Still open. Still very annoying to get a "No sufficient Category definition"
error, when you use a supposedly valid category from
https://en.opensuse.org/openSUSE:Packaging_desktop_menu_categories#SUSE_cate...
after half an hour of compiling. "Science;Engineering" or
"Science;Construction" in my case.
--
You are receiving this mail because:
You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1074711
http://bugzilla.opensuse.org/show_bug.cgi?id=1074711#c16
Benjamin Greiner changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |luizluca@tre-sc.jus.br
--- Comment #16 from Benjamin Greiner
---
*** Bug 990956 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1074711
http://bugzilla.opensuse.org/show_bug.cgi?id=1074711#c17
Fabian Vogt
http://bugzilla.opensuse.org/show_bug.cgi?id=1074711
http://bugzilla.opensuse.org/show_bug.cgi?id=1074711#c18
--- Comment #18 from Stasiek Michalski
http://bugzilla.opensuse.org/show_bug.cgi?id=1074711
http://bugzilla.opensuse.org/show_bug.cgi?id=1074711#c19
--- Comment #19 from Benjamin Greiner ---
Ham I should have checked the comments while working on
https://github.com/openSUSE/brp-check-suse/pull/18
Feel free to discard and write something up in the rpmlint infrastructure. But
if this is not going to happen soon, the categories need to be fixed.
--
You are receiving this mail because:
You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1074711
http://bugzilla.opensuse.org/show_bug.cgi?id=1074711#c20
--- Comment #20 from Stasiek Michalski
Ham I should have checked the comments while working on https://github.com/openSUSE/brp-check-suse/pull/18
Feel free to discard and write something up in the rpmlint infrastructure. But if this is not going to happen soon, the categories need to be fixed.
This PR isn't being accepted because nobody looked at PRs in brp-check-suse, not because it's a controversial PR. People are busy I guess. The desktop file check has been annoying and mostly irrelevant for many years at this point, which is it makes a lot of sense to just drop all the desktop related checks. Creating more PRs doesn't help though, notifying maintainers of the checks will. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1074711
http://bugzilla.opensuse.org/show_bug.cgi?id=1074711#c21
--- Comment #21 from Benjamin Greiner ---
My PR (#18)is only 2 hours old. Maybe you confuse it with #14.
If nobody checks the issues and PRs there, why maintain a github repository at
all? Also, what is this bugtracker for, when you have to contact maintainers
manually?
Sorry, but comments like this lead to rants and problems like
https://blog.fefe.de/?ts=a3c7b5d6
--
You are receiving this mail because:
You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1074711
http://bugzilla.opensuse.org/show_bug.cgi?id=1074711#c22
--- Comment #22 from Benjamin Greiner ---
And may I add that the specfile for brb-check-suse explicitly says
#
# Note: don't rebuild this manually. Instead submit your patches
# for inclusion in the git repo at https://github.com/openSUSE/brp-check-suse
#
--
You are receiving this mail because:
You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1074711
http://bugzilla.opensuse.org/show_bug.cgi?id=1074711#c23
--- Comment #23 from Stasiek Michalski
My PR (#18)is only 2 hours old. Maybe you confuse it with #14.
Yeah, I mean #14
If nobody checks the issues and PRs there, why maintain a github repository at all? Also, what is this bugtracker for, when you have to contact maintainers manually?
There are a lot of PRs and issues on gh that sit there for years before somebody checks that stuff unfortunately. Reminding maintainers is the only way to actually get something going. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1074711
http://bugzilla.opensuse.org/show_bug.cgi?id=1074711#c24
--- Comment #24 from Benjamin Greiner ---
Hence the bump here and on GitHub. Where else should I notify the maintainer
and how would I find out who this is?
--
You are receiving this mail because:
You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1074711
Benjamin Greiner changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |http://bugzilla.opensuse.or
| |g/show_bug.cgi?id=1005087
--
You are receiving this mail because:
You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1074711
Hernan Schmidt
http://bugzilla.opensuse.org/show_bug.cgi?id=1074711
http://bugzilla.opensuse.org/show_bug.cgi?id=1074711#c25
Benjamin Greiner changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|REOPENED |IN_PROGRESS
--- Comment #25 from Benjamin Greiner
---
New submitrequest for Base:System/brp-check-suse
https://build.opensuse.org/request/show/721062
--
You are receiving this mail because:
You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1074711
http://bugzilla.opensuse.org/show_bug.cgi?id=1074711#c26
--- Comment #26 from Benjamin Greiner ---
The submit request was accepted 2 days ago and it triggered some fails in KDE
packages because Teaching was not in the acceptable categories list.
https://github.com/openSUSE/brp-check-suse/issues/26
I habe submitted a fix in PR #27 there.
Also it became apparent, that ComputerScience was missing in the
update-dektop-files scripts. See sr #729934
--
You are receiving this mail because:
You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1074711
http://bugzilla.opensuse.org/show_bug.cgi?id=1074711#c27
Benjamin Greiner changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|IN_PROGRESS |RESOLVED
Resolution|--- |FIXED
--- Comment #27 from Benjamin Greiner
---
The fix finally made it into Factory.
--
You are receiving this mail because:
You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply@novell.com