[Bug 1220905] New: salt-master: Error loading known_hosts
https://bugzilla.suse.com/show_bug.cgi?id=1220905 Bug ID: 1220905 Summary: salt-master: Error loading known_hosts Classification: openSUSE Product: openSUSE Tumbleweed Version: Current Hardware: Other OS: Other Status: NEW Severity: Normal Priority: P5 - None Component: Python Assignee: python-maintainers@suse.com Reporter: egotthold@suse.com QA Contact: qa-bugs@suse.de Target Milestone: --- Found By: --- Blocker: --- This error is happening to me on openSUSE MicroOS 20240302 (the logs reveal this has been happening for a good while already). The error is known upstream and is due to a combination of changes in pygit2 and how Salt is starting up its daemon. https://github.com/saltstack/salt/issues/64121#issuecomment-1705658539 Since we are not using the onedir packaging yet one cannot downgrade to another pygit2 version via salt-pip. I am not that deep into the codebase to know if a systemd drop-in that specifies the user used for running the salt-master.service as "salt", is enough. The log of the salt-master is spammed with the following message: Mar 04 00:01:51 esprimo-1 salt-master[30997]: [ERROR ] Error occurred fetching git_pillar remote 'main git@gitlab.com:<user>/<repo>.git': error loading known_hosts: Mar 04 00:01:51 esprimo-1 salt-master[30997]: Traceback (most recent call last): Mar 04 00:01:51 esprimo-1 salt-master[30997]: File "/usr/lib/python3.11/site-packages/salt/utils/gitfs.py", line 1996, in _fetch Mar 04 00:01:51 esprimo-1 salt-master[30997]: fetch_results = origin.fetch(**fetch_kwargs) Mar 04 00:01:51 esprimo-1 salt-master[30997]: ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Mar 04 00:01:51 esprimo-1 salt-master[30997]: File "/usr/lib64/python3.11/site-packages/pygit2/remotes.py", line 155, in fetch Mar 04 00:01:51 esprimo-1 salt-master[30997]: payload.check_error(err) Mar 04 00:01:51 esprimo-1 salt-master[30997]: File "/usr/lib64/python3.11/site-packages/pygit2/callbacks.py", line 99, in check_error Mar 04 00:01:51 esprimo-1 salt-master[30997]: check_error(error_code) Mar 04 00:01:51 esprimo-1 salt-master[30997]: File "/usr/lib64/python3.11/site-packages/pygit2/errors.py", line 65, in check_error Mar 04 00:01:51 esprimo-1 salt-master[30997]: raise GitError(message) Mar 04 00:01:51 esprimo-1 salt-master[30997]: _pygit2.GitError: error loading known_hosts: -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1220905 https://bugzilla.suse.com/show_bug.cgi?id=1220905#c1 --- Comment #1 from Enno Gotthold <egotthold@suse.com> --- After talking to the Salt Maintainers I did try the following things: 1. Check with "ausearch -m AVC,USER_AVC -ts recent" if there are any SELinux denials present. - This is not the case. 2. Set SELinux to permissive mode. - This did not result in any change. 3. Verify that my salt-master RPM is up to date. - It is (3006.0-8.1) The change that should have fixed this is https://github.com/openSUSE/salt/pull/588. However the changes don't seem to be enough to actually fix the problem on MicroOS. -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1220905 https://bugzilla.suse.com/show_bug.cgi?id=1220905#c2 Pablo Suárez Hernández <pablo.suarezhernandez@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - None |P2 - High Status|NEW |CONFIRMED Assignee|python-maintainers@suse.com |salt-maintainers@suse.de Component|Python |Salt CC| |pablo.suarezhernandez@suse. | |com --- Comment #2 from Pablo Suárez Hernández <pablo.suarezhernandez@suse.com> --- I was able to reproduce this issue. Apparentely, latest libgit2/pygit2 versions are bringing this error back. As a temporary workaround, you could add: Environment=HOME=/var/lib/salt to the "[Service]" section of "/usr/lib/systemd/system/salt-master.service". It seems Salt internals to detect and properly set the environment variables after switching the user to "salt" is still not working fine in some cases, as "HOME" variable is not properly set. We would probably need to backport this: https://github.com/saltstack/salt/pull/64510/commits/a180bfe6e0d6daf0997b717... (I'm setting this bug to CONFIRMED and also changing the component to Salt, so it gets into the right queues) Hth! -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1220905 https://bugzilla.suse.com/show_bug.cgi?id=1220905#c3 --- Comment #3 from Enno Gotthold <egotthold@suse.com> --- The provided workaround works as expected. Thanks a lot for the help! -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1220905 Artem Shiliaev <artem.shiliaev@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |artem.shiliaev@suse.com URL| |https://github.com/SUSE/spa | |cewalk/issues/24222 -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1220905 https://bugzilla.suse.com/show_bug.cgi?id=1220905#c4 Pablo Suárez Hernández <pablo.suarezhernandez@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|CONFIRMED |RESOLVED Resolution|--- |FIXED --- Comment #4 from Pablo Suárez Hernández <pablo.suarezhernandez@suse.com> --- This is now fixed by: https://github.com/openSUSE/salt/pull/699 Missing changelog reference added here: https://build.opensuse.org/request/show/1244713 https://build.opensuse.org/request/show/1244714 https://build.opensuse.org/request/show/1244715 https://build.opensuse.org/request/show/1244720 https://build.opensuse.org/request/show/1244722 Closing as RESOLVED/FIXED. Thanks! -- You are receiving this mail because: You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠suse.com