[Bug 600563] New: log file bomb ...
http://bugzilla.novell.com/show_bug.cgi?id=600563 http://bugzilla.novell.com/show_bug.cgi?id=600563#c0 Summary: log file bomb ... Classification: openSUSE Product: openSUSE 11.3 Version: Factory Platform: Other OS/Version: Other Status: NEW Severity: Major Priority: P5 - None Component: libzypp AssignedTo: zypp-maintainers@forge.provo.novell.com ReportedBy: mmeeks@novell.com QAContact: qa@suse.de Found By: --- Blocker: --- The MeeGo guys are reporting a nasty with libzypp: http://bugs.meego.com/show_bug.cgi?id=704 if it is public; the thrust is you end up with Gigabytes of pkg_backend_zypp log filled with: "[zypp::KeyRing] KeyRing.cc(readSignatureKeyId):628" Since that is not ideal ;-) I knocked up this belt & braces patch to try to improve things (blind) - since we can't reproduce the issue. Thoughts ? -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=600563 http://bugzilla.novell.com/show_bug.cgi?id=600563#c1 --- Comment #1 from Michael Meeks <mmeeks@novell.com> 2010-04-28 15:42:41 UTC --- Created an attachment (id=357464) --> (http://bugzilla.novell.com/attachment.cgi?id=357464) give up when we find, or if we don't find the data earlyish -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=600563 http://bugzilla.novell.com/show_bug.cgi?id=600563#c2 Michael Andres <ma@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - None |P2 - High Status|NEW |NEEDINFO CC| |ma@novell.com InfoProvider| |mmeeks@novell.com --- Comment #2 from Michael Andres <ma@novell.com> 2010-04-28 19:02:12 CEST --- Feeling bad when looking at the log http://folks.o-hand.com/jku/pk_backend: [zypp] FileChecker.cc(operator()):129 checking /var/cache/zypp/raw/meego-extra-develyksTcv/repodata/repomd.xml file validity using digital signature.. [zypp] FileChecker.cc(operator()):129 checking /var/cache/zypp/raw/meego-extra- develyksTcv/repodata/repomd.xml file validity using digital signature.. .. [zypp:fetcher] Fetcher.cc(provideFromCache):348 start fetcher with 3 cache directories. [zypp:fetcher] Fetcher.cc(provideFromCache):348 start fetcher with 3 cache directories. .. [zypp++] MediaSetAccess.cc(provide):201 Going to try to provide optional... [zypp++] MediaManager.cc(checkDesired):112 checkDesired(6): desired (cached) [zypp++] ExternalProgram.cc(start_program):221 [zypp++] ExternalProgram.cc(start_program):373 [zypp] MediaAria2c.cc(fillAriaCmdLine):160 [zypp] TmpPath.cc(TmpFile):198 [zypp++] ExternalProgram.cc(start_program):221 [zypp++] ExternalProgram.cc(start_program):373 [zypp::KeyRing] KeyRing.cc(readSignatureKeyId):628 [zypp::KeyRing] KeyRing.cc(readSignatureKeyId):628 [zypp::KeyRing] KeyRing.cc(readSignatureKeyId):628 [zypp::KeyRing] KeyRing.cc(readSignatureKeyId):628 According to the log, the lines readSignatureKeyId logged are empty, but an empty line should have terminated the loop: for(line = prog.receiveLine(), count=0; !line.empty(); ... If I now look at the lines above, the previous lines are also empty, but they should not be! They should log the command lines and pids. Some more lines up I see duplicated lines Fetcher.cc and FileChecker.cc, but I don't think we have a workflow thet may produce them. Finally some triple line mentioning 2 files atr the same time (.xml and xml.asc): [zypp++] MediaSetAccess.cc(provide):201 Going to try to provide optional file /repodata/repomd.xml.asc from media number 1Going to try to provide file /repodata/repomd.xml from media number 1 Does packagekit run two threads using libzypp at the same time? This should not be. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=600563 http://bugzilla.novell.com/show_bug.cgi?id=600563#c3 --- Comment #3 from Michael Meeks <mmeeks@novell.com> 2010-04-29 09:22:16 UTC --- Great insight; I have no idea if it runs two threads. the output is made more odd - by the fact that we don't see the "'" characters with which the message is delimited; but perhaps this is some spinning in the logging code itself (when some constraint is broken by threading). Either way - having a 'break' when we catch the id= in that loop is no bad thing (right) ? :-) Will dig into the threading issue. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=600563 http://bugzilla.novell.com/show_bug.cgi?id=600563#c4 Michael Andres <ma@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |NEW InfoProvider|mmeeks@novell.com | --- Comment #4 from Michael Andres <ma@novell.com> 2010-04-29 13:37:14 CEST ---
having a 'break' when we catch the id=... Certainly :)
-- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=600563 http://bugzilla.novell.com/show_bug.cgi?id=600563#c5 --- Comment #5 from Michael Andres <ma@novell.com> 2010-04-30 14:14:40 CEST --- (Above fix is in libypp-7.4.0) -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=600563 http://bugzilla.novell.com/show_bug.cgi?id=600563#c6 Michael Andres <ma@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #6 from Michael Andres <ma@novell.com> 2010-07-07 10:53:42 CEST --- . -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply@novell.com