[Bug 783384] New: "Source Timestamp" clutters up diff for samba.spec

bugzilla_noreply＠novell.com

3 Oct 2012 3 Oct '12

16:56

https://bugzilla.novell.com/show_bug.cgi?id=783384 https://bugzilla.novell.com/show_bug.cgi?id=783384#c0 Summary: "Source Timestamp" clutters up diff for samba.spec Classification: openSUSE Product: openSUSE Factory Version: 12.3 Milestone 0 Platform: x86-64 OS/Version: Other Status: NEW Severity: Normal Priority: P5 - None Component: Samba AssignedTo: samba-maintainers@SuSE.de ReportedBy: suse-beta@cboltz.de QAContact: samba-maintainers@SuSE.de Found By: Beta-Customer Blocker: --- The samba.spec contains Source Timestamp: 2842 Branch : 3.6.8 for each and every subpackage in %description. This heavily clutters up the diff view, as you can see on nearly every SR for samba. You can use variables inside %description, so please change the spec to contain _one_ %define SOURCE_TIMESTAMP 2842 %define BRANCH 3.6.8 and for the %description of all subpackages, use %description .... Source timestamp: %{SOURCE_TIMESTAMP} Branch: %{BRANCH} -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Show replies by date

bugzilla_noreply＠novell.com

28 Nov 28 Nov

11:41

New subject: [Bug 783384] "Source Timestamp" clutters up diff for samba.spec

https://bugzilla.novell.com/show_bug.cgi?id=783384 https://bugzilla.novell.com/show_bug.cgi?id=783384#c Lars Müller changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |samba-maintainers@SuSE.de AssignedTo|samba-maintainers@SuSE.de |lmuelle@suse.com -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

bugzilla_noreply＠novell.com

30 Nov 30 Nov

23:18

New subject: [Bug 783384] "Source Timestamp" clutters up diff for samba.spec

https://bugzilla.novell.com/show_bug.cgi?id=783384 https://bugzilla.novell.com/show_bug.cgi?id=783384#c1 Lars Müller changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution| |FIXED --- Comment #1 from Lars Müller 2012-12-01 00:18:22 CET --- Thanks a lot for this elegant enhancement! With https://build.openSUSE.org/request/show/143734 it's on the way to openSUSE:Factory -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

bugzilla_noreply＠novell.com

23:49

New subject: [Bug 783384] "Source Timestamp" clutters up diff for samba.spec

https://bugzilla.novell.com/show_bug.cgi?id=783384 https://bugzilla.novell.com/show_bug.cgi?id=783384#c2 Christian Boltz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |REOPENED Resolution|FIXED | --- Comment #2 from Christian Boltz 2012-12-01 00:49:37 CET --- (In reply to comment #1)

...

Thanks a lot for this elegant enhancement!

You are welcome - and I'm slightly surprised that nobody came up with it earlier. I'd assume the old way was quite painful for reviewers like the Factory team...

...

From the patch view (just one example, it seems to be the same on all subpackages);

---------------------------------------------------------------------------------- %description doc +Source timestamp: %{SOURCE_TIMESTAMP} +Branch: %{BRANCH} + This package contains all the Samba documentation as it is not part of the man pages. -Source Timestamp: 2851 -Branch : 3.6.9 - ---------------------------------------------------------------------------------- Was it intentional to move the source timestamp and the branch to the top of %description? (IMHO it should stay at the end.) BTW: I just noticed in the spec ---------------------------------------------------------------------------------- %if 0%{?suse_version} && 0%{?suse_version} < 1031 %files -n libsmbclient %else %files -n libsmbclient0 %endif ---------------------------------------------------------------------------------- (and similar fun at least for %description and %post) Maybe you should use %if 0%{?suse_version} && 0%{?suse_version} < 1031 %define libsmbclient_package libsmbclient %else %define libsmbclient_package libsmbclient0 %endif which would allow you to get rid of various %if conditions and makes the spec more readable: %files %{libsmbclient_package} (untested ;-) BTW2: please use RESOLVED instead of CLOSED when marking a bug as fixed (or wontfix, invalid, ...) In an ideal world, the bugreporter (or QA) will follow up with setting it to VERIFIED (or REOPENED *g*), even if VERIFIED isn't used very often on bnc ;-) Anyway, CLOSED is the step _after_ VERIFIED (and not really used for openSUSE). -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

bugzilla_noreply＠novell.com

1 Dec 1 Dec