[Bug 483942] New: UI::DumpWidgetTree call Aborts if no dialog exists
https://bugzilla.novell.com/show_bug.cgi?id=483942 User locilka@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=483942#c483211 Summary: UI::DumpWidgetTree call Aborts if no dialog exists Classification: openSUSE Product: openSUSE 11.2 Version: Alpha 0 Platform: Other OS/Version: Other Status: NEW Severity: Normal Priority: P5 - None Component: YaST2 AssignedTo: kmachalkova@novell.com ReportedBy: locilka@novell.com QAContact: jsrain@novell.com CC: abittner@stud.fh-heilbronn.de, tgoettlicher@novell.com Found By: Development Created an attachment (id=278500) --> (https://bugzilla.novell.com/attachment.cgi?id=278500) YaST log Sounds like a feature but in some circumstances it is a bug. This has been originally reported as bug #483211: Description: Automatic Configuration calls several YaST scripts, one of the scripts accidentally closes the current dialog and tries to debug what has happened by calling a debugging function UI::DumpWidget to get something useful to logs. However, UI::DumpWidget finds out there's no dialog present and aborts. Sadly - in the middle of second stage installation. Solution: Debugging function should not abort YaST. From YaST point of view, it should log an error and just keep going. Test file dump.ycp: ------------------------------------- { UI::OpenDialog(`Label("yes/no")); UI::CloseDialog(); UI::DumpWidgetTree(); } ------------------------------------- Test: /usr/lib/YaST2/bin/y2base ./dump.ycp qt terminate called after throwing an instance of 'YUINoDialogException' what(): No dialog existing YaST got signal 6 at YCP file /yast/test/dump.ycp:4 Aborted -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=483942 User locilka@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=483942#c1 --- Comment #1 from Lukas Ocilka <locilka@novell.com> 2009-03-10 09:37:15 MST --- See also these logs: Created an attachment (id=277866) --> (https://bugzilla.novell.com/attachment.cgi?id=277866) Created an attachment (id=278403) --> (https://bugzilla.novell.com/attachment.cgi?id=278403) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=483942 User kmachalkova@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=483942#c2 --- Comment #2 from Katarina Machalkova <kmachalkova@novell.com> 2009-03-10 10:29:10 MST --- Created an attachment (id=278523) --> (https://bugzilla.novell.com/attachment.cgi?id=278523) An ycp-ui-bindings patch resolving the issue Attached is a simplistic patch, which modifies DumpWidgetTree function in such a way that it checks for current dialog in a "non-exception-throwing" mode and only if there is some dialog on the stack, it dumps the widget tree into the log. Otherwise it logs a warning. Although the above test is a corner case, abort()ing the whole YaST thing because of NULL pointer in debugging function is not nice. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=483942 User locilka@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=483942#c3 --- Comment #3 from Lukas Ocilka <locilka@novell.com> 2009-03-11 03:11:56 MST --- Looks good, please submit into 11.2 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=483942 User kmachalkova@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=483942#c4 Katarina Machalkova <kmachalkova@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #4 from Katarina Machalkova <kmachalkova@novell.com> 2009-03-11 10:39:53 MST --- y2-ycp-ui-bindings 2.18.5 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply@novell.com