[Bug 230681] New: "firefox -remote" seems to be more broken in the SUSE package than upstream
https://bugzilla.novell.com/show_bug.cgi?id=230681 Summary: "firefox -remote" seems to be more broken in the SUSE package than upstream Product: openSUSE 10.2 Version: Final Platform: x86 OS/Version: Linux Status: NEW Severity: Normal Priority: P5 - None Component: Firefox AssignedTo: bnc-team-mozilla@forge.provo.novell.com ReportedBy: andreas.hanke@gmx-topmail.de QAContact: qa@suse.de This has been observed with MozillaFirefox-2.0.0.1-0.1.i586.rpm (latest official security update for openSUSE 10.2). With the SUSE package: # /usr/bin/firefox -remote 'openURL(http://www.google.com, new-tab)' Error: No running window found # echo $? 0 With upstream binaries (from ftp.mozilla.org): # /tmp/firefox/firefox -remote 'openURL(http://www.google.com, new-tab)' Error: No running window found # echo $? 2 => Other than the upstream binary, the SUSE binary claims to succeed although it actually failed in the same way as the upstream binary. This behaviour breaks functionality of another application which relies on a correct exit status by doing: /bin/sh -c "if ! firefox -remote 'openURL(http://www.google.com, new-tab)'; then firefox 'http://www.google.com'; fi" -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=230681 wolfgang@rosenauer.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wolfgang@rosenauer.org ------- Comment #1 from wolfgang@rosenauer.org 2006-12-23 06:05 MST ------- I don't think that's a problem. Last thing I've heared is that firefox -remote is obsolete and won't be supported in the future. The official supported ways are AFAIK firefox $URL firefox -new-tab $URL firefox -new-window $URL If you have other information, please let us know. I'll have at least a short look at it soon if it's an easy fix or not. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=230681 ------- Comment #2 from andreas.hanke@gmx-topmail.de 2006-12-23 06:34 MST ------- I know that -remote is obsolete, the problem is that this application uses the exit status of firefox to support both the old (now obsolete) and the new way. The exit status of zero makes the application think that -remote worked, but it didn't actually work. IMHO, an application shouldn't report success on failure (if possible) and the mozilla.org binary doesn't do that. The above is if there is no instance of firefox running. But it's not much better if firefox is running. With the SUSE package: # /usr/bin/firefox -remote 'openURL(http://www.google.com, new-tab)' Error: Failed to send command: 500 command not parseable # echo $? 0 With the mozilla.org binary: # /tmp/firefox/firefox -remote 'openURL(http://www.google.com, new-tab)' (no output, it just works) # echo $? 0 I will contact the authors of this application and ask them to remove -remote usage, but that still doesn't explain the behaviour difference between firefox from SUSE and firefox from mozilla.org. I agree that they shouldn't use -remote any more, but unfortunately, I already know that none of them uses SUSE, so they might just say that it works for them. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=230681 ------- Comment #3 from wolfgang@rosenauer.org 2006-12-23 11:35 MST ------- (In reply to comment #2)
I know that -remote is obsolete, the problem is that this application uses the exit status of firefox to support both the old (now obsolete) and the new way.
I already said that I would look at it but those application should be fixed anyway. What I wrote above works already for both. There is no need to implement such logic to any application anymore. Firefox handles it internally since 1.5 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=230681 ------- Comment #4 from wolfgang@rosenauer.org 2006-12-23 12:02 MST ------- Hmm, started to look at it: Firefox not running (otherwise it works anyway for me) wolfgang@tvp:/local/home/wolfgang> firefox -remote 'openurl(http://www.heise.de/,new-tab)' GTK Accessibility Module initialized Error: No running window found wolfgang@tvp:/local/home/wolfgang> echo $? 2 Looking at the above please note that whitespaces are not allowed in the command AFAIK but even then: wolfgang@tvp:/local/home/wolfgang> firefox -remote 'openurl(http://www.heise.de, new-tab)' GTK Accessibility Module initialized Error: Failed to send command: 500 command not parseable wolfgang@tvp:/local/home/wolfgang> echo $? 1 I don't know yet why the upstream Firefox accepts the whitespace but I wasn't able to reproduce the returncode of 0. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=230681 wolfgang@rosenauer.org changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO Info Provider| |andreas.hanke@gmx-topmail.de ------- Comment #5 from wolfgang@rosenauer.org 2006-12-23 12:22 MST ------- I've just commited a change to the buildservice package. Please check the behaviour with this package. It's just building and will get a newer release number than 2.0.0.1-5.1. Please test when finished. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=230681 wolfgang@rosenauer.org changed: What |Removed |Added ---------------------------------------------------------------------------- Status Whiteboard| |fixed_bs -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=230681 andreas.hanke@gmx-topmail.de changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |NEW Info Provider|andreas.hanke@gmx-topmail.de| ------- Comment #6 from andreas.hanke@gmx-topmail.de 2007-01-04 18:51 MST ------- The buildservice package behaves exactly as the upstream builds now. Thanks a lot! -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=230681 ------- Comment #7 from wolfgang@rosenauer.org 2007-01-04 22:56 MST ------- Michael, you might want to merge the changes in mozilla.sh.in for the next security update. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=230681 wolfgang@rosenauer.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ken@turnkey.com.au ------- Comment #8 from wolfgang@rosenauer.org 2007-01-09 01:50 MST ------- *** Bug 231683 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=230681 wolfgang@rosenauer.org changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|bnc-team- |maw@novell.com |mozilla@forge.provo.novell.c| |om | -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=230681#c9
Michael Wolf
https://bugzilla.novell.com/show_bug.cgi?id=230681#c10
Wolfgang Rosenauer
participants (1)
-
bugzilla_noreply＠novell.com