[Bug 1223378] New: rstudio fails to build against boost 1.85
https://bugzilla.suse.com/show_bug.cgi?id=1223378 Bug ID: 1223378 Summary: rstudio fails to build against boost 1.85 Classification: openSUSE Product: openSUSE Tumbleweed Version: Current Hardware: Other OS: Other Status: NEW Severity: Normal Priority: P5 - None Component: Other Assignee: screening-team-bugs@suse.de Reporter: ana.guerrero@suse.com QA Contact: qa-bugs@suse.de Target Milestone: --- Found By: --- Blocker: --- rstudio failed to build in openSUSE:Factory after boost had been updated to version 1.85, see https://build.opensuse.org/package/live_build_log/openSUSE:Factory/rstudio/s... -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1223378 Ana Guerrero <ana.guerrero@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|screening-team-bugs@suse.de |dcermak@suse.com -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1223378 https://bugzilla.suse.com/show_bug.cgi?id=1223378#c2 Michael Pujos <pujos.michael@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pujos.michael@gmail.com --- Comment #2 from Michael Pujos <pujos.michael@gmail.com> --- Maybe it would be best to report that failure to compile with boost 1.85 to the rstudio issue tracker on github. -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1223378 https://bugzilla.suse.com/show_bug.cgi?id=1223378#c4 --- Comment #4 from Ana Guerrero <ana.guerrero@suse.com> --- (In reply to Arvin Schnell from comment #3)
Seems to be fixed upstream already, see:
I tested it, that patch is not enough. (In reply to Michael Pujos from comment #2)
Maybe it would be best to report that failure to compile with boost 1.85 to the rstudio issue tracker on github.
That would required first building against the HEAD version in github or at least against the last released version 2023.12.1+402. Current rstudio package in openSUSE is behind a couple of releases. -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1223378 https://bugzilla.suse.com/show_bug.cgi?id=1223378#c5 Ana Guerrero <ana.guerrero@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aaronpuchert@alice-dsl.net --- Comment #5 from Ana Guerrero <ana.guerrero@suse.com> --- Aaron, I have seen you have updated rstudio in the past. Adding you here in case you are interested in updating it again. Thank you. -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1223378 https://bugzilla.suse.com/show_bug.cgi?id=1223378#c6 --- Comment #6 from Michael Pujos <pujos.michael@gmail.com> --- I had a go at fixing it, updating it in the process to the latest update v2024.04.0+735.tar.gz. Due to the complexity of this package and the time it takes to compile, it was not exactly a piece of cake and required a few hours of digging. Interestingly, even git rstudio does not compile with boost 1.85: it required a trivial 1 line patch. The new version starts but I am not a rstudio user nor familiar with R, so it would be great if someone familiar with it could test it a bit and report before I submit it to the devel project: https://build.opensuse.org/package/show/home:bobbie424242:branches:openSUSE:... Note that this version does not compile on Leap 15.5 because it has older boost 1.66 and it would require conditionally reverting https://github.com/rstudio/rstudio/commit/251e441e1034950db8a054652dffb63481..., which I may do later. -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1223378 https://bugzilla.suse.com/show_bug.cgi?id=1223378#c7 Aaron Puchert <aaronpuchert@alice-dsl.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |IN_PROGRESS Assignee|screening-team-bugs@suse.de |aaronpuchert@alice-dsl.net --- Comment #7 from Aaron Puchert <aaronpuchert@alice-dsl.net> --- (In reply to Michael Pujos from comment #6)
I had a go at fixing it, updating it in the process to the latest update v2024.04.0+735.tar.gz.
Sorry, I should have said that I was working on it. (https://build.opensuse.org/package/show/home:aaronpuchert:branches:devel:lan...) Maybe you can have a look. I solved some parts differently, but I copied your approach towards Leap. (With a minor adjustment: copy_options is already available with Boost 1.75.)
Due to the complexity of this package and the time it takes to compile, it was not exactly a piece of cake and required a few hours of digging.
Yes, unfortunately we had to patch out some stuff.
Interestingly, even git rstudio does not compile with boost 1.85: it required a trivial 1 line patch.
Upstream seems to target Boost 1.83 for now, the relevant change is only in Boost 1.85. (https://github.com/boostorg/function/commit/af8e66d03b4366c7039a138306470567...)
The new version starts but I am not a rstudio user nor familiar with R, so it would be great if someone familiar with it could test it a bit and report before I submit it to the devel project:
https://build.opensuse.org/package/show/home:bobbie424242:branches:openSUSE: Factory/rstudio
I don't use RStudio a lot, but most of the stuff I've been doing in the past continues to work.
Note that this version does not compile on Leap 15.5 because it has older boost 1.66 and it would require conditionally reverting https://github.com/rstudio/rstudio/commit/ 251e441e1034950db8a054652dffb6348194f231, which I may do later.
Interestingly, SLE has Boost 1.75 since SP3 (https://build.opensuse.org/package/show/SUSE:SLE-15-SP3:GA/boost.175), but instead of libboost_*-devel it provides libboost_*-devel-impl. And it conflicts with Boost 1.66, which we transitively require via e.g. soci-devel. So I think patching it as you did is our only option. I think we shouldn't do BuildRequires: openSUSE-release Because it might cause frequent rebuilds (at least in the devel project) and it doesn't sound right. RStudio being a part of the distribution shouldn't depend on it. I'd propose to just patch this out. There is nothing SUSE-specific at the moment in the CMake files, and if there is it might not work for Tumbleweed anyway. -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1223378 https://bugzilla.suse.com/show_bug.cgi?id=1223378#c8 --- Comment #8 from Michael Pujos <pujos.michael@gmail.com> --- Understood, no worries. It still was a good learning experience for me, modifying such complex package. -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1223378 https://bugzilla.suse.com/show_bug.cgi?id=1223378#c9 Aaron Puchert <aaronpuchert@alice-dsl.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|IN_PROGRESS |RESOLVED --- Comment #9 from Aaron Puchert <aaronpuchert@alice-dsl.net> --- Should be fixed with https://build.opensuse.org/request/show/1171310. (In reply to Michael Pujos from comment #8)
Understood, no worries. It still was a good learning experience for me, modifying such complex package.
Good to hear you're seeing the positive side. For what it's worth, your patch for older Boost was quite valuable, and I basically just copied it (with attribution). -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1223378 https://bugzilla.suse.com/show_bug.cgi?id=1223378#c10 --- Comment #10 from Ana Guerrero <ana.guerrero@suse.com> --- Michael, Aaron, thank you for your help! -- You are receiving this mail because: You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply@suse.com