[Bug 1229062] New: drbd: fix build error against kernel v6.10.3
https://bugzilla.suse.com/show_bug.cgi?id=1229062 Bug ID: 1229062 Summary: drbd: fix build error against kernel v6.10.3 Classification: openSUSE Product: openSUSE Tumbleweed Version: Current Hardware: x86-64 OS: openSUSE Tumbleweed Status: NEW Severity: Normal Priority: P5 - None Component: High Availability Assignee: ha-bugs@suse.de Reporter: heming.zhao@suse.com QA Contact: qa-bugs@suse.de Target Milestone: --- Found By: --- Blocker: --- build error info: ``` CC [M] /usr/src/packages/BUILD/drbd-9.1.16/zhm/drbd_nl.o /usr/src/packages/BUILD/drbd-9.1.16/zhm/drbd_nl.c: In function ‘drbd_reconsider_queue_parameters’: /usr/src/packages/BUILD/drbd-9.1.16/zhm/drbd_nl.c:2114:9: error: implicit declaration of function ‘blk_queue_max_hw_sectors’; did you mean ‘queue_max_hw_sectors’? [-Werror=implicit-function-declaration] 2114 | blk_queue_max_hw_sectors(q, common_limits.max_hw_sectors); | ^~~~~~~~~~~~~~~~~~~~~~~~ | queue_max_hw_sectors ``` -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1229062 https://bugzilla.suse.com/show_bug.cgi?id=1229062#c1 --- Comment #1 from heming zhao <heming.zhao@suse.com> --- root cause: kernel commit ec84ca4025c0 ("scsi: block: Remove now unused queue limits helpers") remove the kabi function blk_queue_max_hw_sectors(). how to fix: re-enable the function blk_queue_max_hw_sectors(). -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1229062 https://bugzilla.suse.com/show_bug.cgi?id=1229062#c2 --- Comment #2 from heming zhao <heming.zhao@suse.com> --- There is another minor issue. When building the drbd module, drbd tests the kernel and reports a missing kvfree_rcu()
------------------- GENPATCHNAMES 6.10.3-1-default APPLIED_COCCI_FILES kvfree_rcu__no_present -------------------
Above info is incorrect, kernel 6.10.3 does have kvfree(), the test function is in located in "drbd-kernel-compat/tests/have_kvfree_rcu.c"
#include <linux/rcupdate.h>
void foo(void *ptr) { kvfree_rcu(ptr); }
the build error arises from the kvfree_rcu() input parameter, the upstream kernel requires two input parameters, but drbd uses only one input in the test. this kvfree_rcu issue can be completely ignored because the current drbd source code doesn't use kvfree_rcu(). -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1229062 heming zhao <heming.zhao@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |glass.su@suse.com -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1229062 heming zhao <heming.zhao@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - None |P3 - Medium Assignee|ha-bugs@suse.de |heming.zhao@suse.com -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1229062 https://bugzilla.suse.com/show_bug.cgi?id=1229062#c3 heming zhao <heming.zhao@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #3 from heming zhao <heming.zhao@suse.com> --- the patch had been merged into factory repo. close this bug as fixed. -- You are receiving this mail because: You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply@suse.com