[Bug 480803] New: pm-utils package missing a space after "--force" in /usr/lib/pm-utils/functions
https://bugzilla.novell.com/show_bug.cgi?id=480803 Summary: pm-utils package missing a space after "--force" in /usr/lib/pm-utils/functions Classification: openSUSE Product: openSUSE 11.1 Version: Final Platform: x86-64 OS/Version: Other Status: NEW Severity: Normal Priority: P5 - None Component: Other AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: jnelson-suse@jamponi.net QAContact: qa@suse.de Found By: --- User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9.0.6) Gecko/2009012700 SUSE/3.0.6-0.1.2 Firefox/3.0.6 The pm-utils package is missing a space after "--force" in /usr/lib/pm-utils/functions in 2 of the 3 locations it is used, thus rendering *ALL* s2ram options problematic. This affects both the 11.1 and factory (11.2) versions. The approximate line numbers are (with space *added*): 185: S2RAM_OPTS="--force " 205: S2RAM_OPTS="--force " 220: S2RAM_OPTS+="--force " Reproducible: Always Steps to Reproduce: 1. 2. 3. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=480803 User cyhan@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=480803#c1 Chuanye Han <cyhan@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cyhan@novell.com AssignedTo|bnc-team-screening@forge.pr |seife@novell.com |ovo.novell.com | --- Comment #1 from Chuanye Han <cyhan@novell.com> 2009-03-13 03:53:23 MST --- Stefan, could you please help to have a look at this? Thank you. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=480803 Stefan Seyfried <seife@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=480803 User seife@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=480803#c2 Stefan Seyfried <seife@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEEDINFO Info Provider| |jnelson-suse@jamponi.net --- Comment #2 from Stefan Seyfried <seife@novell.com> 2009-03-19 08:53:58 MST --- First: Thanks for spotting and reporting this. An embarassing bug ;-) But do you actually see a problem? The only potential problem I can see is in line 185, which is only triggered in case you set S2RAM_QUIRKS_SOURCE=hal (yes, a valid bug). The other lines are harmless: 205 is the "we only use --force" case, so no further option is passed: no space needed 220 HAS a space already. So unless I overlooked something, I would add a space after the --force in 185, and push that into factory, but I'd leave 11.1 alone, because this seems to be a minor issue. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=480803 User jnelson-suse@jamponi.net added comment https://bugzilla.novell.com/show_bug.cgi?id=480803#c3 Jon Nelson <jnelson-suse@jamponi.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |ASSIGNED Info Provider|jnelson-suse@jamponi.net | --- Comment #3 from Jon Nelson <jnelson-suse@jamponi.net> 2009-03-24 17:17:45 MST --- That seems just fine. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=480803 User jnelson-suse@jamponi.net added comment https://bugzilla.novell.com/show_bug.cgi?id=480803#c4 --- Comment #4 from Jon Nelson <jnelson-suse@jamponi.net> 2009-03-24 17:47:32 MST --- An additional note: you probably want to change (near line 220?) to use this: S2RAM_OPTS+=" --force " as you are *appending* not *prefixing*, thus the --force needs a space *before* it. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=480803 User seife@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=480803#c5 Stefan Seyfried <seife@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - None |P3 - Medium Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #5 from Stefan Seyfried <seife@novell.com> 2009-03-25 08:37:40 MST --- Not necessary, because get_s2ram_cmdline() returns S2RAM_OPTS with appended space. But yes, good spotting :-) So I'd say "FIXED in FACTORY". -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com