[Bug 223489] New: suspend to disk doesn't work with swap partition on lvm
https://bugzilla.novell.com/show_bug.cgi?id=223489 Summary: suspend to disk doesn't work with swap partition on lvm Product: SUSE Linux 10.1 Version: Final Platform: All OS/Version: SuSE Linux 10.1 Status: NEW Severity: Major Priority: P5 - None Component: Basesystem AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: vogt@itwm.fraunhofer.de QAContact: qa@suse.de Hi! Suspend to disk doesn't work with mkinitrd-1.2-106.19, if swap/resume partition is located on a lvm. With the following patch everything is fine again. Regards Martin --- mkinitrd.orig 2006-11-22 16:34:32.000000000 +0100 +++ mkinitrd 2006-11-22 17:24:46.000000000 +0100 @@ -1803,7 +1803,7 @@ |fi | |# Verify manual resume mode - |if [ "$resume_mode" != "off" -a -n "\$resumedev" ]; then + |if [ "\$resume_mode" != "off" -a -n "\$resumedev" ]; then | if [ -w /sys/power/resume ]; then | echo "Trying manual resume from \$resumedev" | resume_mode=1 @@ -2558,13 +2558,6 @@ EOF fi - cat_linuxrc <<-'EOF' - |# Wait for udev to settle - |/sbin/udevsettle --timeout=$udev_timeout - |# Check for a resume device - |udev_discover_resume - EOF - if [ -n "$need_mdadm" ]; then cat_linuxrc <<-EOF |if [ -n "\$resume_minor" ] ; then @@ -2713,6 +2706,13 @@ fi cat_linuxrc <<-'EOF' + |# Wait for udev to settle + |/sbin/udevsettle --timeout=$udev_timeout + |# Check for a resume device + |udev_discover_resume + EOF + + cat_linuxrc <<-'EOF' |# And now for the real thing |if ! udev_discover_root ; then | echo "not found -- exiting to /bin/sh" -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=223489 chrubis@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|bnc-team- |hare@novell.com |screening@forge.provo.novell| |.com | -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=223489 ------- Comment #1 from chrubis@novell.com 2006-11-24 04:30 MST ------- *** Bug 223490 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=223489 hare@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=223489 ------- Comment #2 from hare@novell.com 2006-11-30 03:23 MST ------- Created an attachment (id=107559) --> (https://bugzilla.novell.com/attachment.cgi?id=107559&action=view) /sbin/mkinitrd Fixed /sbin/mkinitrd. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=223489 hare@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEEDINFO Info Provider| |vogt@itwm.fraunhofer.de ------- Comment #3 from hare@novell.com 2006-11-30 03:24 MST ------- Can you retest with the above mkinitrd? It contains a slightly different fix; this was required for md to work properly. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=223489 ------- Comment #4 from vogt@itwm.fraunhofer.de 2006-12-05 02:26 MST ------- Hello, we tested the new version on the thinkpad and it worked fine. thanks & regards, Martin -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=223489 hare@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |ASSIGNED Info Provider|vogt@itwm.fraunhofer.de | ------- Comment #5 from hare@novell.com 2006-12-05 04:07 MST ------- Thanks for testing. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=223489 hare@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEEDINFO Info Provider| |aj@novell.com ------- Comment #6 from hare@novell.com 2006-12-05 04:08 MST ------- AJ, okay for update? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=223489 hare@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status Whiteboard| |mkinitrd-10.1-update -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=223489 hwadechandler-linux@yahoo.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hwadechandler-linux@yahoo.com ------- Comment #8 from hwadechandler-linux@yahoo.com 2007-05-14 13:53 MST ------- This is an issue in 10.2 as of 2007-05-14. I haven't seen any patches. Also, the setup of the swap file on the LVM was the SuSE default proposal. I installed the entire setup then had to go back, delete it all, and reinstall. The setup had made the LVM the entire disk free space, so I couldn't just remove the swap and add another one. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=223489#c9 Per Ångström <1kfmm4x02@sneakemail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |1kfmm4x02@sneakemail.com --- Comment #9 from Per Ångström <1kfmm4x02@sneakemail.com> 2007-08-26 13:16:55 MST --- (In reply to comment #8 from Wade Chandler) I ran into the same problem when I installed 10.2 using an all-LVM setup. The symptoms are a bit different from the original bug description. I should also say that I have compiled and installed kernel 2.6.22 in an attempt to fix some other problems. First of all, suspend to disk fails because the boot parameter resume=/dev/system/swap conflicts with the contents of /proc/swaps: Filename Type Size Used Priority /dev/mapper/system-swap partition 3145720 0 -1 This is probably because the comparison doesn't know that /dev/system/swap is a link to /dev/mapper/system-swap. I have tried to work around this by removing the swap-file name comparison: # diff /etc/pm/hooks/30s2disk-check.orig /etc/pm/hooks/30s2disk-check 30c30 < [ "$DEV" != "$RESUME" ] && continue ---
# [ "$DEV" != "$RESUME" ] && continue
With that "fix" suspend to disk works, but then resume won't work, see excerpt from /var/messages/boot.msg: --- Boot logging started on /dev/tty1(/dev/console) at Sun Aug 26 20:22:48 2007 Trying manual resume from /dev/system/swap Creating device nodes with udev Loading scsi_mod Loading sd_mod Loading processor Loading thermal Loading libata Loading ata_piix Loading fan Loading dm-mod Loading edd Loading dm-snapshot Waiting for /dev/mapper/control to appear: ok Loading jbd Loading mbcache Loading ext3 resume device /dev/system/swap not found (ignoring) 3 logical volume(s) in volume group "system" now active Waiting for device /dev/system/root to appear: ok --- Maybe this is done too early, before the LVM is fully up and running? I have also tried using a different boot resume parameter: "resume=/dev/mapper/system-swap". That made suspend to disk work, without fiddling with 30s2disk-check, but resume runs into the same problem as above, that the resume device cannot be found. I'm wondering whether this should be a new bug against version 10.2, but most important: is this fixed for 10.3? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=223489#c10
--- Comment #10 from Hannes Reinecke
https://bugzilla.novell.com/show_bug.cgi?id=223489#c11
Hannes Reinecke
https://bugzilla.novell.com/show_bug.cgi?id=223489#c12
Hannes Reinecke
https://bugzilla.novell.com/show_bug.cgi?id=223489#c14
--- Comment #14 from Anja Stock
participants (1)
-
bugzilla_noreply＠novell.com