[Bug 833765] New: dd_rescue creates bigger file
https://bugzilla.novell.com/show_bug.cgi?id=833765 https://bugzilla.novell.com/show_bug.cgi?id=833765#c0 Summary: dd_rescue creates bigger file Classification: openSUSE Product: openSUSE Factory Version: 13.1 Milestone 3 Platform: PowerPC-64 OS/Version: openSUSE 12.3 Status: NEW Severity: Normal Priority: P5 - None Component: Other AssignedTo: kurt@garloff.de ReportedBy: dvaleev@suse.com QAContact: qa-bugs@suse.de Found By: --- Blocker: --- dd_rescue test fails on powerpc. dd_rescue.copy produced is bigger than original file. /dd_rescue -apP dd_rescue dd_rescue.copy dd_rescue: (info): Using softbs=65536, hardbs=65536 dd_rescue: (warning): write into dd_rescue.copy (@0/223686): sparse not recommended dd_rescue: (info): expect to copy 150kB from dd_rescue dd_rescue: (info): read dd_rescue (172.1k): EOF dd_rescue: (info): Summary for dd_rescue -> dd_rescue.copy dd_rescue: (info): ipos: 172.1k, opos: 172.1k, xferd: 172.1k errs: 0, errxfer: 0.0k, succxfer: 172.1k +curr.rate: 3265kB/s, avg.rate: 3265kB/s, avg.load: 0.0% >-........................................< 114% TOT: 0:00:00 cmp dd_rescue dd_rescue.copy cmp: EOF on dd_rescue make: *** [check] Error 1 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=833765 https://bugzilla.novell.com/show_bug.cgi?id=833765#c1 Kurt Garloff <garloff@garloff.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |garloff@garloff.de --- Comment #1 from Kurt Garloff <garloff@garloff.de> 2013-08-07 17:02:34 UTC --- Good to have make check enabled, so this issue is exposed. That said, I'm surprised to see this happening. Questions: - Any chance to access a PPC64 (virtual) machine to reproduce this? - If not, any chance to have a debugging session with someone who can? - If not, at least full build log and a tarball of the BUILD directory might give me a clue. Thx! -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=833765 https://bugzilla.novell.com/show_bug.cgi?id=833765#c2 --- Comment #2 from Dinar Valeev <dvaleev@suse.com> 2013-08-07 21:15:58 UTC --- The full build log is here: https://build.opensuse.org/package/rawlog/openSUSE:Factory:PowerPC/dd_rescue... yes you can access the machine if you could provide a ssh key. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=833765 https://bugzilla.novell.com/show_bug.cgi?id=833765#c3 Kurt Garloff <garloff@garloff.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #3 from Kurt Garloff <garloff@garloff.de> 2013-08-07 22:13:20 UTC --- Dinar, thanks, that is helpful! http://www.garloff.de/kurt/id_dsa.pub md5sum: 8111e6785bd6a794b78fa994cd9cc630 id_dsa.pub ssh-dss AAAAB3NzaC1kc3MAAAEBAMzgTVCA8IDjLFIhKXOZOIFSsq6loDnX4dCFFL2wX7nHtWW3Kr+8mEsFM9XFSt6M65EeWKPNMOWRdD3G7OeddFRsGNK/5nHH4n4P/sxxaGqIWshz9BYiOGcWaNREtx0P8szZ9pRRDhfJ94uSgLGczWgvEWFdlPlU06DJ6ZYiD9Kuc0/9EjcpRt0bTmV/EcO76u304kOwd9OuKhBuXia2HEmcZ/mCqPxhIDKuKdcwMNAVZ4j7rK4gLF3psAjuLxo2KRFYyINyuMadTs4r5ahgHk7cksVcf/hM43qiFIf1Leq2I2RJgWwbRlAoRNJbWe/DbDVkS70jMIyywV1AKM2JNfcAAAAVALRo5U/lTmDdV/n550d3/kARBZe1AAABABJX2ytNaL9Mol6xoi5r6VINeBnRHxZWUFZwtiPSieGRpNkFgwPhj6eYcCYwZ/5AEGtiaYZMq+0ygBpKvZhDSjGfZjIJ6XlicTrLLA/qlL+jf+6oAdmKW42HJguvYk7RcjfSi9RfZUYFkJgfYugQT1bDZF2ADS9XSxBxuNS41mkPlCZVjVQJBCUWCQ5uPkKp8UsOwhRv36QyPSI7mbWwQtO8Xe/KwIbVC7kxoOoGG5TLpF2HcBoPRnDd8qN2yeBESDibdnRSrE/6MtiwVclVrBAbRLbjfeKFalG4cDegnzUdlxn9OowpI/bNAUj6H1F7CCrN5xMDI2PcfB8d9rV2DzMAAAEASt61L4taOFTJh8O3HeJZfjJNIqxTzkJrOLxCnr36VPSt9w/6n82gVSw7R0iWTaoME1LX6BlxIYTY54M7TX3PaX9Oe11R7Cdi8WMB0qqj2Bcz2usknVmJvt27yulCfMBzbucciqCT3L68laWR5dZn3ay5gGCsF4DHiqJtsgrFtTsefDItKhIKQE33zhmqpDrVOOl3mcMKHXexFEAo24pI9inqoDaKsOUMGSRI8v34h1FwJX7iFf IgG4DWDJUHAONvte6MlngCFhbhrLXTT9pYB7gj1cmBUdjhp+MkffC2A5+kn+i7jlBRgAYO7FiuMlpLxdL49vmabo7MmgLF+XpTlg== kurt@garloff.de -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=833765 https://bugzilla.novell.com/show_bug.cgi?id=833765#c4 --- Comment #4 from Kurt Garloff <garloff@garloff.de> 2013-08-08 12:10:40 UTC --- Actually, I caught it -- issue was copyfile_hardbs() which is used on PPC64 b/c hardbs = pagesize by default which works out to 64k on PPC64 and thus the same as default softbs. Fortunately, the effect was relatively harmless: - It would only append spurious sparse zeros at the end and only if copyfile_hardbs was used at the end. diff -u -p -r1.220 -r1.221 --- dd_rescue.c 7 Aug 2013 07:27:24 -0000 1.220 +++ dd_rescue.c 8 Aug 2013 09:08:11 -0000 1.221 @@ -1121,19 +1125,15 @@ int copyfile_hardbs(const off_t max) exitfatalerr(eno); /* Non fatal error */ /* This is the case, where we were not called from copyfile_softbs and thus have to assume harmless EOF */ - if (softbs <= hardbs && eno == 0) { + if (/*softbs <= hardbs &&*/ eno == 0) { int ret; /* But first: write available data and advance (optimization) */ if ((ret = partialwrite(rd)) < 0) return ret; else errs += ret; - xfer += rd; sxfer += rd; - if (reverse) { - ipos -= rd; opos -= rd; - } else { - ipos += rd; opos += rd; - } + /* partialwrite calls dowrite_retry which updates + * statistics and positions. */ continue; } /* Real error on small blocks: Don't retry */ I'm currently testing 1.39 which has this fixed I'll submit very soon ... -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=833765 https://bugzilla.novell.com/show_bug.cgi?id=833765#c5 Kurt Garloff <garloff@garloff.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #5 from Kurt Garloff <garloff@garloff.de> 2013-08-08 12:28:32 UTC --- Tested on PPC64 -- thanks Dinar. I released 1.39 and did an osc sr to Factory for the new package. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com