[Bug 418491] New: Callbacks of solver iterate functions should have user_data argument
https://bugzilla.novell.com/show_bug.cgi?id=418491 Summary: Callbacks of solver iterate functions should have user_data argument Product: openSUSE 11.0 Version: Final Platform: Other OS/Version: Other Status: NEW Severity: Enhancement Priority: P5 - None Component: libzypp AssignedTo: zypp-maintainers@forge.provo.novell.com ReportedBy: mrashmiranjan@novell.com QAContact: qa@suse.de Found By: --- solver_installs_iterate(...., int (*callback)( const XSolvable *xs ) ); solver_removals_iterate(..., int (*callback)( const XSolvable *xs ) ); solver_updates_iterate(..., int (*callback)( const XSolvable *xs_old, const XSolvable *xs_new ) ); The iterate function like above should have one more user_data argument which should be passed onto the callback function. Otherwise it becomes a mesh accessing the user data in callback functions. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=418491 Duncan Mac-Vicar <dmacvicar@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dmacvicar@novell.com AssignedTo|zypp-maintainers@forge.provo.novell.com |mls@novell.com -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=418491 User mls@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=418491#c2 Michael Schröder <mls@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|mls@novell.com |kkaempf@novell.com --- Comment #2 from Michael Schröder <mls@novell.com> 2008-11-04 04:04:47 MST --- Reassigned to bindings maintainer... (If you're not using the language bindings, you probably shouldn't use XSolvable) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=418491 User kkaempf@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=418491#c3 --- Comment #3 from Klaus Kämpf <kkaempf@novell.com> 2008-11-05 08:18:07 MST --- Ah, you're using the 'application' layer of sat-solver. Yes, I can add a user_data argument, but you might be better off without using XSolvable. Its primary use is for the swig bindings which do not need user_data. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=418491 User mrashmiranjan@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=418491#c4 --- Comment #4 from Rashmi Ranjan Mohanty <mrashmiranjan@novell.com> 2008-11-05 09:49:10 MST --- Well.. I can manage without using XSolvable, but these iterate functions are bit easy to get the list of installs/removals/updates. Otherwise I have to do the same task in my code. Thats not big deal either as the code is very simple for these functions ;-) Choice is upto you Klaus. You may or may not add the user_data argument. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=418491 User kkaempf@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=418491#c5 --- Comment #5 from Klaus Kämpf <kkaempf@novell.com> 2008-11-05 10:09:37 MST --- Ah, thanks, I just wanted to have some context. Expect user_data to all callbacks within 24 hrs ;-) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=418491 User kkaempf@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=418491#c6 Klaus Kämpf <kkaempf@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #6 from Klaus Kämpf <kkaempf@novell.com> 2008-11-06 01:51:49 MST --- Fixed in svn revision 11587. All applayer iterator callbacks now have a 'void *user_data' argument. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com