[Bug 439176] New: freesci-0.6.4-57.7: missing expression in return statement
https://bugzilla.novell.com/show_bug.cgi?id=439176 Summary: freesci-0.6.4-57.7: missing expression in return statement Product: openSUSE 11.1 Version: Factory Platform: All OS/Version: openSUSE 11.0 Status: NEW Severity: Normal Priority: P5 - None Component: Other AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: dcb314@hotmail.com QAContact: qa@suse.de Found By: --- I just tried to build the Suse Linux package freesci-0.6.4-57.7 and the compiler said core.c:916: warning: 'return' with no value, in function returning non-void The source code is sciprintf("Unexpected explicit MIDI command %02x\n", command); return; Suggest change to sciprintf("Unexpected explicit MIDI command %02x\n", command); return SFX_ERROR; -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=439176
Michal Seben
https://bugzilla.novell.com/show_bug.cgi?id=439176
User sndirsch@novell.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=439176#c1
Stefan Dirsch
https://bugzilla.novell.com/show_bug.cgi?id=439176
User dcb314@hotmail.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=439176#c2
David Binderman
There's no need to build the package yourself, since we provide packages on our distribution and via buildservice.
You missed the point: the code is broken and needs fixing. In my opinion, this code, as it is now, would fail a basic sanity test for commercial quality code. It is not clear to me that it is wise to ship, to paying customers, code that is known to be broken. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=439176
User sndirsch@novell.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=439176#c3
Stefan Dirsch
https://bugzilla.novell.com/show_bug.cgi?id=439176
User meissner@novell.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=439176#c4
--- Comment #4 from Marcus Meissner
https://bugzilla.novell.com/show_bug.cgi?id=439176
User dcb314@hotmail.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=439176#c5
--- Comment #5 from David Binderman
David, you have obviously not seen "commercial quality" code.
Commercial and quality usually do not go along. ;)
Good comedy - in fact, I've been writing and reviewing commercial code for over twenty years. I think there is an opportunity for some process improvement: Can it be arranged that such code, since it's clearly broken, doesn't get into the Factory and gets rejected as "not fit for purpose" in some way ? With a view to some basic re-work before letting it into Factory ? I am sure the fault will occur in other packages and preventing it seems a good idea. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=439176
User sndirsch@novell.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=439176#c6
--- Comment #6 from Stefan Dirsch
participants (1)
-
bugzilla_noreply＠novell.com