[Bug 789421] New: Two dependencies wrong between systemd units (IMHO)
https://bugzilla.novell.com/show_bug.cgi?id=789421 https://bugzilla.novell.com/show_bug.cgi?id=789421#c0 Summary: Two dependencies wrong between systemd units (IMHO) Classification: openSUSE Product: openSUSE Factory Version: 12.3 Milestone 1 Platform: All OS/Version: SUSE Other Status: NEW Severity: Normal Priority: P5 - None Component: Basesystem AssignedTo: fcrozat@suse.com ReportedBy: werner@suse.com QAContact: qa-bugs@suse.de Found By: Development Blocker: --- During debuging insserv with dbus call to systemd I've detected two dependencies which cold be wrong: a) in /lib/systemd/system/localfs.service the line After=local-fs.target should be Before=local-fs.target as the target `local-fs.target' is similar to `$local_fs' from LSB b) the insserv soriting algorithm shows insserv: There is a loop between service NetworkManager and NetworkManager-wait-online if started and indeed running systemctl dot | grep -i network | less shows: "network.target"->"NetworkManager-wait-online.service" [color="darkgrey"]; "NetworkManager-wait-online.service"->"network.target" [color="darkgrey"]; -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=789421
https://bugzilla.novell.com/show_bug.cgi?id=789421#c1
--- Comment #1 from Frederic Crozat
https://bugzilla.novell.com/show_bug.cgi?id=789421
https://bugzilla.novell.com/show_bug.cgi?id=789421#c2
Dr. Werner Fink
a) localfs.service is a dummy service written to "hide" boot.localfs initscript (since this job is handled by systemd itself). But if we put Before=local-fs.target in it, initscripts which have a dependency on boot.localfs (such as boot.cycle, boot.dmraid) could be called by systemd before local-fs.target is reached, ie before all mount points needed to have "local-fs" are started properly.
Does this mean that systemd is ignoring # X-Start-Before: boot.localfs of the boot.dmraid script and the # Required-Start: boot.localfs of the boot.cycle script? Within SysV and insserv the two lines caused an indirect dependency that is that $local_fs aka local-fs.target enclose not only the boot.localfs and optional the boot.crypto but also boot.dmraid and boot.cycle. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=789421
https://bugzilla.novell.com/show_bug.cgi?id=789421#c3
--- Comment #3 from Bernhard Wiedemann
https://bugzilla.novell.com/show_bug.cgi?id=789421
https://bugzilla.novell.com/show_bug.cgi?id=789421#c4
--- Comment #4 from Bernhard Wiedemann
https://bugzilla.novell.com/show_bug.cgi?id=789421
https://bugzilla.novell.com/show_bug.cgi?id=789421#c5
--- Comment #5 from Bernhard Wiedemann
https://bugzilla.novell.com/show_bug.cgi?id=789421
https://bugzilla.novell.com/show_bug.cgi?id=789421#c6
Frederic Crozat
Does this mean that systemd is ignoring
# X-Start-Before: boot.localfs
of the boot.dmraid script
No, boot.dmraid is correctly ordered : systemctl show dmraid.service | grep Before Before=local-fs-pre.target localfs.service lvm.service
and the
# Required-Start: boot.localfs
of the boot.cycle script?
systemctl show cycle.service | grep After After=localfs.service loadmodules.service systemd-journald.socket (and since localfs.service is after local-fs.target, we are safe)
Within SysV and insserv the two lines caused an indirect dependency that is that $local_fs aka local-fs.target enclose not only the boot.localfs and optional the boot.crypto but also boot.dmraid and boot.cycle.
I changed insserv parsing code in systemd to always ignore boot.crypto and boot.localfs when parsing insserv.conf because they are handled "internally" by systemd (and were causing errors in systemd output). -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=789421
https://bugzilla.novell.com/show_bug.cgi?id=789421#c7
Dr. Werner Fink
https://bugzilla.novell.com/show_bug.cgi?id=789421
https://bugzilla.novell.com/show_bug.cgi?id=789421#c8
--- Comment #8 from Frederic Crozat
If the NetworkManager dependency rules is corrected now we may close this bug as fixed. Do you agree?
let me fix this one first :) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=789421
https://bugzilla.novell.com/show_bug.cgi?id=789421#c9
Frederic Crozat
https://bugzilla.novell.com/show_bug.cgi?id=789421
https://bugzilla.novell.com/show_bug.cgi?id=789421#c10
--- Comment #10 from Bernhard Wiedemann
participants (1)
-
bugzilla_noreply@novell.com