[Bug 767545] New: Wrong exit code checked inside /usr/lib/pm-utils/pm-functions function (_run_hook())
https://bugzilla.novell.com/show_bug.cgi?id=767545 https://bugzilla.novell.com/show_bug.cgi?id=767545#c0 Summary: Wrong exit code checked inside /usr/lib/pm-utils/pm-functions function (_run_hook()) Classification: openSUSE Product: openSUSE 12.1 Version: Final Platform: All OS/Version: openSUSE 11.2 Status: NEW Severity: Normal Priority: P5 - None Component: Basesystem AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: fa0sck@gmail.com QAContact: qa-bugs@suse.de Found By: --- Blocker: --- User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20100101 Firefox/12.0 There is a (probably minor) glitch inside /usr/lib/pm-utils/pm-functions of pm-utils-1.4.1-12.20.1 package. In function _run_hook() at line 202 hook_exit_status should check hook_ok... line exit code, but log() exit status is checked instead. Currently I don't know what the consequences of this bug might be, if any. Reproducible: Didn't try Steps to Reproduce: 1.open /usr/lib/pm-utils/pm-functions 2.go to line 195 3.check _run_hook() code Actual Results: Not tried/unknown Expected Results: Not tried/unknown -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=767545 https://bugzilla.novell.com/show_bug.cgi?id=767545#c1 --- Comment #1 from Fabio Scl <fa0sck@gmail.com> 2012-06-18 20:28:12 UTC --- Created an attachment (id=495252) --> (http://bugzilla.novell.com/attachment.cgi?id=495252) fix exit code checked by hook_exit_status inside /usr/lib/pm-utils/pm-functions Here I attach trivial patch for pm-functions _run_hook() function. Regards -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=767545 https://bugzilla.novell.com/show_bug.cgi?id=767545#c kk zhang <kkzhang@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kkzhang@suse.com AssignedTo|bnc-team-screening@forge.pr |nld10-bugs-qa@forge.provo.n |ovo.novell.com |ovell.com -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=767545 https://bugzilla.novell.com/show_bug.cgi?id=767545#c Andreas Jaeger <aj@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nld10-bugs-qa@forge.provo.n |vdziewiecki@suse.com |ovell.com | -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=767545 https://bugzilla.novell.com/show_bug.cgi?id=767545#c2 Vojta Dziewięcki <vdziewiecki@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #2 from Vojta Dziewięcki <vdziewiecki@suse.com> 2012-06-22 11:34:42 UTC --- Fixing this would result in inhibiting suspend if one of the hooks failed, which seems desirable. But I'm afraid of this happening too often, and preventing users from suspending their computers because of some unimportant error. So I will test it a little and then submit it to factory maybe, but fixing it in 12.1 or 11.4 now could IMO cause more harm then leaving it as is. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=767545 https://bugzilla.novell.com/show_bug.cgi?id=767545#c3 Wojtek Dziewięcki <vdziewiecki@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |WONTFIX --- Comment #3 from Wojtek Dziewięcki <vdziewiecki@suse.com> 2014-07-16 15:07:40 UTC --- Noone has time to fix pm-utils any more, sorry. This package will not be present in future opensuse versions as it has been replacad by systemd's suspend functionality. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com