https://bugzilla.novell.com/show_bug.cgi?id=667408 https://bugzilla.novell.com/show_bug.cgi?id=667408#c1 Vincent Untz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEEDINFO InfoProvider| |bwiedemann@novell.com --- Comment #1 from Vincent Untz 2011-01-27 00:17:03 UTC --- I just tried locally, and if I set DEFAULT_WM to icewm, it works fine. My guess is that there's something that is not right on the test instance. Bernhard: are we sure that there are no ~/.dmrc and also nothing in /var/cache/gdm ? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=667408 https://bugzilla.novell.com/show_bug.cgi?id=667408#c3 --- Comment #3 from Vincent Untz 2011-01-27 12:12:20 UTC --- Hrm. Is xfce really shipping a /usr/share/xsessions/startxfce4.desktop file? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=667408 https://bugzilla.novell.com/show_bug.cgi?id=667408#c5 Guido Berhörster changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |ASSIGNED InfoProvider|bwiedemann@novell.com | --- Comment #5 from Guido Berhörster 2011-01-27 12:56:10 UTC --- There is an inconsistency between how gdm and the mess of scripts in /etc/X11/xinit handle the value of DEFAULT_WM, the former expects it to be the basename of the session file while the latter expect it to be an executable. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=667408 https://bugzilla.novell.com/show_bug.cgi?id=667408#c7 Vincent Untz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |ASSIGNED InfoProvider|vuntz@novell.com | --- Comment #7 from Vincent Untz 2011-01-27 13:22:37 UTC --- Hrm. I'm not sure what's best here. Ideally, everything would use a unique meaning for DEFAULT_WM. I believe that the stuff in /usr/share/xsessions is standard, so I'd prefer to use this meaning. But I don't know what else needs to be fixed. Opening the .desktop files in /usr/share/xsessions to see if the Exec lines match DEFAULT_WM is not really safe, since you could have various desktop files launching the same binary (but with options). So I'd advise against it. FWIW, doing a symlink for the desktop files is likely wrong, as the item will then be displayed twice. So, yeah, I see three solutions: a) remove the gdm patch, and live with the fact that gnome will be the default. Not good, imho. b) standardize the meaning of DEFAULT_WM. Best option, but it might be late in the cycle for this. Would need a mail to opensuse-factory for this. c) work around this by making sure that the name of the desktop file and the name of the executable are the same. I'd prefer b. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=667408 https://bugzilla.novell.com/show_bug.cgi?id=667408#c9 --- Comment #9 from Guido Berhörster 2011-01-29 21:10:37 UTC --- Created an attachment (id=411138) --> (http://bugzilla.novell.com/attachment.cgi?id=411138) change value of DEFAULT_WM to the basename of the session file Here is an implementation of option b as described in comment#7: /etc/profile.d/profile.sh and /etc/init.d/xdm uses DEFAULT_WM to set WINDOWMANAGER to the absolute path of an executable as follows: WINDOWMANAGER="`type -p ${DEFAULT_WM##*/}`" This can be changed so the executable is extracted from the session file: WINDOWMANAGER="$( while read -r line; do case ${line} in Exec=*) printf "%s\n" "$(type -p ${line#Exec=})" break;; esac done < /usr/share/xsessions/${DEFAULT_WM}.desktop )" sysconfig.windowmanager specifies the default value and describes the variable so it has to be changed to reflect the new values. All three files have been changed in home:gberh:branches:Base:System/aaa_base and home:gberh:branches:X11:XOrg/xorg-x11. Finally the yast installation control files and the included description need to be changed so the installer sets the right values, see attached patch. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=667408 https://bugzilla.novell.com/show_bug.cgi?id=667408#c11 --- Comment #11 from Guido Berhörster 2011-01-31 15:28:45 UTC --- SR #59526 provides the changes against Base:System/aaa_base SR #59527 provides the changes against X11:XOrg/xorg-x11 After that the attached patch will need to be applied against the yast installer control files. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=667408 https://bugzilla.novell.com/show_bug.cgi?id=667408#c Stefan Dirsch changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEEDINFO InfoProvider| |gber@opensuse.org -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=667408 https://bugzilla.novell.com/show_bug.cgi?id=667408#c Stefan Dirsch changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEEDINFO InfoProvider| |werner@novell.com -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=667408 https://bugzilla.novell.com/show_bug.cgi?id=667408#c15 --- Comment #15 from Dr. Werner Fink 2011-02-01 11:33:17 UTC --- Just seen that you have changed /etc/profile.d/profile.sh but *not* /etc/profile.d/profile.csh I'll add the change also to /etc/profile.d/profile.csh otherwise all tcsh users won't ne able to use desktop files. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=667408 https://bugzilla.novell.com/show_bug.cgi?id=667408#c17 --- Comment #17 from Dr. Werner Fink 2011-02-01 12:25:01 UTC --- Just done, see below. Also I've changes /etc/profile.d/profile.sh to support older configurations found in /etc/sysconfig/windowmanager # # Do not use the `which' builtin nor set path to avoid a rehash # if ( ! ${?WINDOWMANAGER} ) then if (! ${?default_wm} ) set default_wm set desktop="/usr/share/xsessions/${default_wm}.desktop" set default_wm=${default_wm:t} if ( -s ${desktop:q} ) then set wm=`sed -rn '/^Exec=/{s@[^=]*=([^=]*)@\1@p;}' ${desktop:q}` foreach val ($path /usr/X11R6/bin /usr/openwin/bin) if ( ${val:q} =~ *.* ) continue set val=${val:q}/${wm:q} if ( ! -x ${val:q} ) continue setenv WINDOWMANAGER ${val:q} break end unset val wm endif unset desktop if ( ${%default_wm} > 0 && ! ${?WINDOWMANAGER} ) then foreach val ($path /usr/X11R6/bin /usr/openwin/bin) if ( ${val:q} =~ *.* ) continue set val=${val:q}/${default_wm:q} if ( ! -x ${val:q} ) continue setenv WINDOWMANAGER ${val:q} break end unset val endif endif unset default_wm -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=667408 https://bugzilla.novell.com/show_bug.cgi?id=667408#c19 --- Comment #19 from Guido Berhörster 2011-02-01 13:27:15 UTC --- There is a ";;" missing in the case statement. I think it might also a better idea to use "command -v" rather than "type -p", the "-p" option to type is a bash extension which happens to work with ksh93 but not dash whereas the latter is specified as a IEEE Std 1003.1-2001 User Portability extension which is supported by all bourne shell derivative in oS. I've already submitted the changes to /etc/init.d/xdm as SR#59593, can you modify it so it matches the code in profile.sh? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=667408 https://bugzilla.novell.com/show_bug.cgi?id=667408#c21 Guido Berhörster changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|vuntz@novell.com |yast2-maintainers@suse.de --- Comment #21 from Guido Berhörster 2011-02-01 14:59:04 UTC --- Point taken, too bad it's not enough to implement Duff's device. Assigning to Yast maintainers, please evaluate the attached patch which adapts the installer control files to the new meaning of DEFAULT_WM. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=667408 https://bugzilla.novell.com/show_bug.cgi?id=667408#c23 Martin Vidner changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mvidner@novell.com AssignedTo|yast2-maintainers@suse.de |locilka@novell.com --- Comment #23 from Martin Vidner 2011-02-02 08:21:08 CET --- Re: patch in comment 9 (attachment 411138), the Factory mail is http://lists.opensuse.org/opensuse-factory/2011-01/msg00340.html , so far without a reply. I am afraid the patch is not enough, as it addresses only the control file, living in yast2-installation SVN and also in skelcd-*.rpm. DEFAULT_WM is also present in /etc/sysconfig/windowmanager, originating in /var/adm/fillup-templates/sysconfig.windowmanager (aaa_base.rpm, on 11.3) Another thing: since we are standardizing this, should LXDE really be uppercase and all others lowercase? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=667408 https://bugzilla.novell.com/show_bug.cgi?id=667408#c25 --- Comment #25 from Guido Berhörster 2011-02-02 11:48:06 UTC --- (In reply to comment #23)

Re: patch in comment 9 (attachment 411138 [details]), the Factory mail is http://lists.opensuse.org/opensuse-factory/2011-01/msg00340.html , so far without a reply.

I am afraid the patch is not enough, as it addresses only the control file, living in yast2-installation SVN and also in skelcd-*.rpm. DEFAULT_WM is also present in /etc/sysconfig/windowmanager, originating in /var/adm/fillup-templates/sysconfig.windowmanager (aaa_base.rpm, on 11.3)

sysconfig.windowmanager has already been changed.

Another thing: since we are standardizing this, should LXDE really be uppercase and all others lowercase?

I only did that because the session file is named LXDE.desktop, I can make a quick fix to lxde-common and aaa_base to make it lowercase. Would you adapt the patch to the control file accordingly? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=667408 https://bugzilla.novell.com/show_bug.cgi?id=667408#c26 --- Comment #26 from Stefan Dirsch 2011-02-02 13:02:37 UTC --- SR #59778 has been accepted and forwarded to openSUSE:Factory as SR #59781. What's still open? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=667408 https://bugzilla.novell.com/show_bug.cgi?id=667408#c28 --- Comment #28 from Stefan Dirsch 2011-02-03 10:06:17 UTC --- (In reply to comment #27)

(In reply to comment #26)

...

SR #59778 has been accepted and forwarded to openSUSE:Factory as SR #59781.

And meanwhile accepted.

...

What's still open?

I've just renamed LXDE.desktop to lxde.desktop in lxde-common, forwarded to Factory as SR#59784,

Accepted as well.

adaptation of sysconfig.windowmanager in aaa_base is SR#59779 and needs to be pushed into Factroy.

Accepted by gregkh but not been forwarded to openSUSE:Factory. :-( Werner, since you have permission in Base:System, can you do so?

Other than that only Yast needs to be updated.

==> assignee -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=667408 https://bugzilla.novell.com/show_bug.cgi?id=667408#c30 Guido Berhörster changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #411138|0 |1 is obsolete| | --- Comment #30 from Guido Berhörster 2011-02-08 12:52:37 UTC --- Created an attachment (id=412788) --> (http://bugzilla.novell.com/attachment.cgi?id=412788) change value of DEFAULT_WM to the basename of the session file Changed LXDE to lxde. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=667408 https://bugzilla.novell.com/show_bug.cgi?id=667408#c32 Lukas Ocilka changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED Target Milestone|--- |Factory --- Comment #32 from Lukas Ocilka 2011-02-08 14:28:33 UTC --- osc submitreq system:install:head skelcd-control-openSUSE openSUSE:Factory created request id 60312 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.