[Bug 1038408] New: wicked: Usage of systemctrl enable should be changed to %sytemd_add_pre/post
http://bugzilla.suse.com/show_bug.cgi?id=1038408 Bug ID: 1038408 Summary: wicked: Usage of systemctrl enable should be changed to %sytemd_add_pre/post Classification: openSUSE Product: openSUSE Tumbleweed Version: Current Hardware: Other OS: Other Status: NEW Severity: Normal Priority: P5 - None Component: Other Assignee: wicked-maintainers@suse.de Reporter: behlert@suse.com QA Contact: qa-bugs@suse.de CC: fcrozat@suse.com Found By: --- Blocker: --- "systemctl preset-all" is intended to return service states to a factory state based on presets. But currently we can see breakages in some products due to services that are not following the guidelines as described in https://en.opensuse.org/openSUSE:Systemd_packaging_guidelines#Enabling_syste... The package wicked was identified to use "systemctl enable" in its spec-file, and it should get replaced by the proper use of %sytemd_add_pre/post and preset. Please check your package, thanks. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=1038408 Stefan Behlert <behlert@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://fate.suse.com/32214 | |0 -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=1038408 http://bugzilla.suse.com/show_bug.cgi?id=1038408#c1 Marius Tomaschewski <mt@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |mt@suse.com Resolution|--- |WORKSFORME --- Comment #1 from Marius Tomaschewski <mt@suse.com> --- The `%{service_add_pre wicked.service}` & co are used in wicked, but presets are simply not enough to cover proper migration, see also bug 843526 that is mentioned in the spec file: %pre service # upgrade from sysconfig[-network] scripts _id=`readlink /etc/systemd/system/network.service 2>/dev/null` || : if test "x${_id##*/}" = "xnetwork.service" -a -x /etc/init.d/network ; then /etc/init.d/network stop-all-dhcp-clients || : fi %{service_add_pre wicked.service} %post service %{service_add_post wicked.service} # See bnc#843526: presets do not apply for upgrade / are not sufficient # to handle sysconfig-network|wicked -> wicked migration _id=`readlink /etc/systemd/system/network.service 2>/dev/null` || : case "${_id##*/}" in ""|wicked.service|network.service) /usr/bin/systemctl --system daemon-reload || : /usr/bin/systemctl --force enable wicked.service || : ;; esac I consider this as WORKSFORME. -- You are receiving this mail because: You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com