[Bug 551956] New: zypper al without explicit -type should derive the type from the name.
http://bugzilla.novell.com/show_bug.cgi?id=551956 Summary: zypper al without explicit -type should derive the type from the name. Classification: openSUSE Product: openSUSE 11.2 Version: RC 1 Platform: Other OS/Version: Other Status: NEW Severity: Normal Priority: P5 - None Component: libzypp AssignedTo: zypp-maintainers@forge.provo.novell.com ReportedBy: ma@novell.com QAContact: qa@suse.de Found By: --- # zypper al patch:yast2-samba-server # zypper ll # | Name | Type | Repository --+--------------------------+---------+----------- 1 | patch:yast2-samba-server | package | (any) This is unnecessarily wrong. If not type is explicitly given using --type, zypper can derive the correct type from the name. Class zypp:sat::Solvable::SplitIdent is intended to do this splitting. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=551956
User ma@novell.com added comment
http://bugzilla.novell.com/show_bug.cgi?id=551956#c1
Michael Andres
http://bugzilla.novell.com/show_bug.cgi?id=551956
User jkupec@novell.com added comment
http://bugzilla.novell.com/show_bug.cgi?id=551956#c2
Ján Kupec
- Initializing pool and target is most probably superfluous.
it's needed by 'rl', since it uses PoolQuery to check how the newly removed lock is related with the other existing locks. The specified args can be e.g. just a subset of an existing lock query.
@Jano: I sketched the suggested changes in branch 'ma-lock-changes'. Plaese have a look at them.
I'll try to take a look today. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=551956
User ma@novell.com added comment
http://bugzilla.novell.com/show_bug.cgi?id=551956#c3
--- Comment #3 from Michael Andres
it's needed by 'rl', since it uses PoolQuery to check how the newly removed lock is related with the other existing locks. The specified args can be e.g. just a subset of an existing lock query.
But it does not need to execute the query, does it? -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=551956
User jkupec@novell.com added comment
http://bugzilla.novell.com/show_bug.cgi?id=551956#c4
--- Comment #4 from Ján Kupec
http://bugzilla.novell.com/show_bug.cgi?id=551956
User jkupec@novell.com added comment
http://bugzilla.novell.com/show_bug.cgi?id=551956#c5
--- Comment #5 from Ján Kupec
http://bugzilla.novell.com/show_bug.cgi?id=551956
User jkupec@novell.com added comment
http://bugzilla.novell.com/show_bug.cgi?id=551956#c6
--- Comment #6 from Ján Kupec
http://bugzilla.novell.com/show_bug.cgi?id=551956
User ma@novell.com added comment
http://bugzilla.novell.com/show_bug.cgi?id=551956#c7
--- Comment #7 from Michael Andres
I just confirmed with Josef the pool is needed when removing the locks because it compares the results of the lock queries to see whether they intersect or not or they are equal (in results). In case of problem it asks user how to proceed via callback.
I don't see why this is necessary. To queries 'foo*' and '*oo' may or may not produce the same result in a specific context. Anyway they are never equal. IMO zypper rl should remove exactly the query that zypper al would have added. And equal is NOT same result in current context, but same query args which is context independent (syntactically equal, PoolQuery::operator==). Class Locks attempt to adjust the package locks in the Pool is actually wrong, unless you can make sure this pool is not used to commit. On commit the pool would write out the locks as individual package locks, and not the original queries. Better use ResPool::setHardLockQueries. The pool will not just write out the right lockset then, it will also correctly adjust locks in case repos are added/removed from the pool, or new package locks are applied removed by the UI. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=551956
User jreidinger@novell.com added comment
http://bugzilla.novell.com/show_bug.cgi?id=551956#c8
--- Comment #8 from Josef Reidinger
http://bugzilla.novell.com/show_bug.cgi?id=551956
User ma@novell.com added comment
http://bugzilla.novell.com/show_bug.cgi?id=551956#c9
Michael Andres
so for example: zypper al *zypp zypper al lib* zypper rl libzypp # informs user that there is two locks which locks more then just libzypp
I see. So it could make sense someday to have options for a 'fast' rl that checks for syntax only, and a more sophisticated one that loads the pool and does the content checks. I leave the target loading on. Applied the remaining fix for zypper-1.2.10. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=551956
http://bugzilla.novell.com/show_bug.cgi?id=551956#c10
Swamp Workflow Management
participants (1)
-
bugzilla_noreply@novell.com