https://bugzilla.novell.com/show_bug.cgi?id=474361 User werner@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=474361#c1 Dr. Werner Fink changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |prusnak@novell.com, | |werner@novell.com AssignedTo|werner@novell.com |jkupec@novell.com --- Comment #1 from Dr. Werner Fink 2009-02-18 07:35:30 MST --- Tip: remove the package bash-completion. It's broken. Beside this the /etc/bash_completion.d/zypper.sh is broken. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=474361 User werner@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=474361#c3 Dr. Werner Fink changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|werner@novell.com |jkupec@novell.com --- Comment #3 from Dr. Werner Fink 2009-02-18 08:33:54 MST --- The problem of bug #470548 is already fixed. It is the script /etc/bash_completion.d/zypper.sh which is broken ... if you're using a word list for compgen you may temporary change the IFS variable otherwise the script may fail. From man bash -W wordlist The wordlist is split using the characters in the IF special variable as delimiters, and each resultant word is expanded. The possible completions are the members of the resultant list which match the word being completed. by default IFS is <space><tab><newline> ... for an example how to use IFS see /etc/profile.d/complete.bash . -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=474361 User werner@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=474361#c5 Dr. Werner Fink changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|werner@novell.com |jreidinger@novell.com --- Comment #5 from Dr. Werner Fink 2009-02-18 09:24:28 MST --- I'm not the author nor maintainer of /etc/bash_completion.d/zypper.sh nor maintainer of the package zypper and /etc/bash_completion.d/zypper.sh is part of zypper ... isn't it? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=474361 User jreidinger@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=474361#c7 Josef Reidinger changed: What |Removed |Added ---------------------------------------------------------------------------- Info Provider|jreidinger@novell.com |werner@novell.com --- Comment #7 from Josef Reidinger 2009-02-19 00:23:27 MST --- Hi, thanks for your comment. At first I want say, that change IFS doesn't help as long as all characters is possible in repo names. What I find broken is not compgen, which I think generate correctly if I use in word list escaped IFS character. compgen -W "test lest" test lest compgen -W "test\ lest" test lest What I find problematic is that when I assign escaped value to COMPREPLY then it appear in behavior which I describe in initial commend (bash hint correct allias, but cannot complete it to full version. You can see actual development version of zypper bash complete here - http://git.opensuse.org/?p=projects/zypp/zypper.git;a=blob;f=src/bash-comple... Could you please specify what is break? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=474361 Dr. Werner Fink changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |NEW Info Provider|werner@novell.com | -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=474361 User werner@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=474361#c12 Dr. Werner Fink changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #273933|0 |1 is obsolete| | --- Comment #12 from Dr. Werner Fink 2009-02-19 08:15:59 MST --- Created an attachment (id=273967) --> (https://bugzilla.novell.com/attachment.cgi?id=273967) zypper.sh A more rugged version ... now it escapes the spaces found in names and also removes unwanted spaces which may cause negative array subscript otherwise. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=474361 User jkupec@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=474361#c14 Ján Kupec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |NEW Info Provider|jkupec@novell.com | --- Comment #14 from Ján Kupec 2009-02-19 09:00:14 MST --- c#12 - Exactly! It works, thanx a lot! :O) (In reply to comment #11)

Please, this is not my bug ... stop assigning me this bug.

You reassigned it to yourself the last time :O) Check the history

The original shell from attachment #271582 [details] script was never written by me nor I've done any change to this script.

Nobody ever said that. All that was said is that there could have been a bug in bash. But you showed us a way out of it, so thanx again. So the problem was the use of the default IFS we one expects those white characters in the to-be-completed strings? BTW, i guess the right way to handle this report should be to leave it assigned to you and resolve as INVALID, but i won't argue with you anymore :O) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=474361 User werner@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=474361#c16 --- Comment #16 from Dr. Werner Fink 2009-02-19 09:13:58 MST ---

All that was said is that there could have been a bug in bash. But you showed us a way out of it, so thanx again.

There is no bug in bash completion ... beside that is is not very handy like completion in tcsh or zsh. As you can see from script in attachment #273967 it requires wide bash knowledge to write such scripts ... a reason why some of the hasty written completion functions of the bash_completion package will fail in some corner cases. And the reason why simple completions for the cd command leads into such large shell function as found in /etc/profile.d/complete.bash ... you may compare this with /etc/profile.d/complete.tcsh ... last one is (IMHO) much more reliable. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=474361 User jkupec@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=474361#c18 Ján Kupec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #18 from Ján Kupec 2009-03-02 05:32:13 MST --- Done. Will push it soon. Thank you guys! commit 7cbd4def398ffb38732e0d935a2539e9fbe93ff6 Author: Werner Fink Date: Mon Mar 2 13:26:41 2009 +0100 bash-completion: Allow empty spaces in repos names. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.