[Bug 1155310] xfs_fsr ignores / misinterpretes its -p option
https://bugzilla.suse.com/show_bug.cgi?id=1155310 https://bugzilla.suse.com/show_bug.cgi?id=1155310#c15 --- Comment #15 from Gerben Jansen <gerben.jansen@aol.com> --- Hmmmm, i wanted to demonstrate that your fix works, so i first repeated the experiment from comment #5 and then wanted to repeat it with your test repo. However i can't reproduce it anymore. Over time xfs_fsr got upgraded to a newer version. guppy:~ # rpm -q --whatprovides /usr/sbin/xfs_fsr xfsprogs-4.15.0-lp151.7.12.1.x86_64 Trying to reproduce the loop from comment #5: guppy:~ # umount /MyLib guppy:~ # umount /MyDisk guppy:~ # cd /var/tmp guppy:/var/tmp # ls -l .fsrlast_xfs ls: cannot access '.fsrlast_xfs': No such file or directory guppy:/var/tmp # xfs_fsr -p 1 -t 1 xfs_fsr -m /proc/mounts -t 1 -f /var/tmp/.fsrlast_xfs ... / start inode=0 XFS_IOC_SWAPEXT failed: ino=181638: Invalid argument XFS_IOC_SWAPEXT failed: ino=225083: Invalid argument XFS_IOC_SWAPEXT failed: ino=228807: Invalid argument xfs_fsr startpass 0, endpass 0, time 2 seconds guppy:/var/tmp # ls -l .fsrlast_xfs -rw-r--r-- 1 root root 19 Nov 5 21:27 .fsrlast_xfs guppy:/var/tmp # xfs_fsr -p 1 -t 18000 xfs_fsr -m /proc/mounts -t 18000 -f /var/tmp/.fsrlast_xfs ... / start inode=228830 XFS_IOC_SWAPEXT failed: ino=1193026: Invalid argument XFS_IOC_SWAPEXT failed: ino=1207140: Invalid argument /home start inode=0 Completed all 1 passes guppy:/var/tmp # ls -l .fsrlast_xfs ls: cannot access '.fsrlast_xfs': No such file or directory guppy:/var/tmp # mount /MyLib/ guppy:/var/tmp # xfs_fsr -p 1 -t 1 xfs_fsr -m /proc/mounts -t 1 -f /var/tmp/.fsrlast_xfs ... / start inode=0 XFS_IOC_SWAPEXT failed: ino=181638: Invalid argument XFS_IOC_SWAPEXT failed: ino=225083: Invalid argument XFS_IOC_SWAPEXT failed: ino=228807: Invalid argument XFS_IOC_SWAPEXT failed: ino=1193026: Invalid argument XFS_IOC_SWAPEXT failed: ino=1207140: Invalid argument xfs_fsr startpass 0, endpass 0, time 2 seconds guppy:/var/tmp # ls -l .fsrlast_xfs -rw-r--r-- 1 root root 20 Nov 5 21:30 .fsrlast_xfs guppy:/var/tmp # cat .fsrlast_xfs /dev/sdb2 0 1543832 guppy:/var/tmp # xfs_fsr -p 1 -t 18000 xfs_fsr -m /proc/mounts -t 18000 -f /var/tmp/.fsrlast_xfs ... / start inode=1543832 /home start inode=0 /MyLib start inode=0 Completed all 1 passes guppy:/var/tmp # cat .fsrlast_xfs cat: .fsrlast_xfs: No such file or directory So the version from xfsprogs-4.15.0-lp151.7.12.1.x86_64 stops after 1 pass as wanted, were the version from xfsprogs-4.15.0-lp151.7.3.1.x86_64 repeated its loop forever. I didn't attempt to run the version from your test repo. -- You are receiving this mail because: You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply@suse.com