[Bug 529922] New: rlwrap-0.30-55.5: missing call to close
http://bugzilla.novell.com/show_bug.cgi?id=529922 Summary: rlwrap-0.30-55.5: missing call to close Classification: openSUSE Product: openSUSE 11.2 Version: Factory Platform: All OS/Version: openSUSE 11.1 Status: NEW Severity: Normal Priority: P5 - None Component: Other AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: dcb314@hotmail.com QAContact: qa@suse.de Found By: --- I just had a look at factory package rlwrap-0.30-55.5 For source code file rlwrap-0.30/src/readline.c around line 580 is the source code for the function munge_line_in_editor. I notice the following line of code tmpfile_fd = open(tmpfilename, O_RDONLY); but I fail to notice a missing call to close. This looks like a resource leak to me. Suggest code rework, possibly by adding a call to close. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=529922 Dirk Mueller <dmueller@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|bnc-team-screening@forge.pr |hvogel@novell.com |ovo.novell.com | -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=529922 User rguenther@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=529922#c1 --- Comment #1 from Richard Guenther <rguenther@novell.com> 2009-10-17 08:54:58 MDT --- David, in case the issues are not introduced by a patch local to openSUSE please report the issues upstream. Packagers, please do not add openSUSE-local patches to fix this kind of errors but forward the bugs upstream and close the bugs as RESOLVED UPSTREAM. Note that it is perfectly fine to have "resource leaks" at the end of a program as the kernel will clean up for you. Manually freeing them only increases binary size and runtime. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=529922 https://bugzilla.novell.com/show_bug.cgi?id=529922#c2 Hendrik Vogelsang <hvogel@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |UPSTREAM Severity|Normal |Major --- Comment #2 from Hendrik Vogelsang <hvogel@suse.com> 2012-07-20 12:59:21 UTC --- . -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply@novell.com