[Bug 803072] New: GRUB2 os-prober detects only mounted Windows partitions
https://bugzilla.novell.com/show_bug.cgi?id=803072 https://bugzilla.novell.com/show_bug.cgi?id=803072#c0 Summary: GRUB2 os-prober detects only mounted Windows partitions Classification: openSUSE Product: openSUSE Factory Version: 12.3 Beta 1 Platform: x86-64 OS/Version: Other Status: NEW Severity: Major Priority: P5 - None Component: Bootloader AssignedTo: jsrain@suse.com ReportedBy: cymerio@gmail.com QAContact: jsrain@suse.com Found By: --- Blocker: --- User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:18.0) Gecko/20100101 Firefox/18.0 When updating/installing GRUB2, either during the installation or during normal use, only the mounted Windows partitions are added to the boot menu. During the openSUSE installation the partitioner doesn't suggest to mount Windows partitions by default, so the user can end up with no Windows entry in the boot menu if he's not careful. Reproducible: Always Steps to Reproduce: 1. Install openSUSE 12.3 RC1 in an empty partition in a PC with Windows. 2. Uncheck "automatic configuration". 3. Review the proposed partitioning. Notice that the expert mode partitioner doesn't suggest to mount the Windows partitions. 4. Let the system finish the installation and reboot. Actual Results: After reboot there is no Windows entry in the boot menu. Expected Results: After an installation, a Windows entry should appear if the user has Windows installed. I'd suggest either try to temporarily mount every partition found on the system before calling "os-prober" or make the expert mode partitioner to suggest to mount Windows partitions to /windows/C, /windows/D or whatever. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=803072 https://bugzilla.novell.com/show_bug.cgi?id=803072#c Jiri Srain <jsrain@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|jsrain@suse.com |mchang@suse.com -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=803072 https://bugzilla.novell.com/show_bug.cgi?id=803072#c1 Michael Chang <mchang@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO InfoProvider| |cymerio@gmail.com --- Comment #1 from Michael Chang <mchang@suse.com> 2013-09-27 05:55:23 UTC --- Hi asd, There's quite some improvements in os-prober on 13.1 factroy. Could you please check the status with 13.1 factory ? Thanks. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=803072 https://bugzilla.novell.com/show_bug.cgi?id=803072#c2 Catalin Iacob <iacobcatalin@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - None |P2 - High Status|NEEDINFO |NEW Version|13.1 Beta 1 |Final InfoProvider|cymerio@gmail.com | Component|Bootloader |Bootloader CC| |iacobcatalin@gmail.com Product|openSUSE Factory |openSUSE 13.1 OS/Version|Other |openSUSE 13.1 --- Comment #2 from Catalin Iacob <iacobcatalin@gmail.com> 2014-01-02 06:26:14 UTC --- I'm affected by this too on 13.1. I've investigated with debug prints in os-prober's scripts and this happens because the NTFS partition is mounted with grub2-mount which only shows some of the files on that partition: 2013-12-16T07:55:10.244285+01:00 linux-p5jt 20microsoft: debug: listing result: total 1488071 dr-xr-xr-x 0 root root 0 Dec 15 10:57 ASUS.DAT dr-xr-xr-x 0 root root 0 Dec 10 2011 AsusVibeData -r--r--r-- 0 root root 2560 Apr 22 2009 $AttrDef -r--r--r-- 0 root root 0 Apr 22 2009 $BadClus -r--r--r-- 0 root root 6104800 Apr 22 2009 $Bitmap dr-xr-xr-x 0 root root 0 Jul 29 2009 Boot -r--r--r-- 0 root root 8192 Apr 22 2009 $Boot -r--r--r-- 0 root root 8192 Jul 29 2009 BOOTSECT.BAK -r--r--r-- 0 root root 85 Nov 14 2011 BurnHelp.txt dr-xr-xr-x 0 root root 0 Nov 19 2012 cygwin -r--r--r-- 0 root root 14188 Sep 10 2011 devlist.txt dr-xr-xr-x 0 root root 0 Aug 5 2011 $Extend -r--r--r-- 0 root root 67108864 Apr 22 2009 $LogFile -r--r--r-- 0 root root 1449394176 Aug 5 2011 $MFT -r--r--r-- 0 root root 4096 Apr 22 2009 $MFTMirr dr-xr-xr-x 0 root root 0 Nov 12 2011 $Recycle.Bin -r--r--r-- 0 root root 1006608 Aug 5 2011 $Secure -r--r--r-- 0 root root 131072 Apr 22 2009 $UpCase -r--r--r-- 0 root root 0 Apr 22 2009 $Volume If I change the mount part of /usr/lib/os-probes/50mounted-tests like this: #if type grub2-mount >/dev/null 2>&1 && \ # type grub2-probe >/dev/null 2>&1 && \ # grub2-mount "$partition" "$tmpmnt" 2>/dev/null; then # mounted=1 # type="$(grub2-probe -d "$partition" -t fs)" || true # if [ "$type" ]; then # debug "mounted using GRUB $type filesystem driver" # else # debug "mounted using GRUB, but unknown filesystem?" # type=fuseblk # fi #else ro_partition "$partition" for type in $types $delaytypes; do if mount -o ro -t "$type" "$partition" "$tmpmnt" 2>/dev/null; then debug "mounted as $type filesystem" mounted=1 break fi done #fi normal mount is used instead of grub2-mount and all files appear: 2013-12-19T07:29:09.963760+01:00 linux-p5jt 20microsoft: debug: listing result: total 10620308 drwx------ 1 catalin users 4096 Dec 18 07:15 ASUS.DAT drwx------ 1 catalin users 4096 Dec 10 2011 AsusVibeData drwx------ 1 catalin users 4096 Jul 29 2009 Boot -rw------- 1 catalin users 383562 Jul 14 2009 bootmgr -rw------- 1 catalin users 8192 Jul 29 2009 BOOTSECT.BAK -rw------- 1 catalin users 85 Nov 14 2011 BurnHelp.txt drwx------ 1 catalin users 4096 Nov 19 2012 cygwin -rw------- 1 catalin users 14188 Sep 10 2011 devlist.txt lrwxrwxrwx 2 catalin users 60 Jul 14 2009 Documents and Settings -> /run/media/catalin/OS/Users drwx------ 1 catalin users 0 Sep 10 2011 eSupport -rw------- 2 catalin users 17734 Nov 7 2007 eula.1028.txt -rw------- 2 catalin users 17734 Nov 7 2007 eula.1031.txt -rw------- 2 catalin users 10134 Nov 7 2007 eula.1033.txt -rw------- 2 catalin users 17734 Nov 7 2007 eula.1036.txt -rw------- 2 catalin users 17734 Nov 7 2007 eula.1040.txt -rw------- 2 catalin users 118 Nov 7 2007 eula.1041.txt -rw------- 2 catalin users 17734 Nov 7 2007 eula.1042.txt -rw------- 2 catalin users 17734 Nov 7 2007 eula.2052.txt -rw------- 2 catalin users 17734 Nov 7 2007 eula.3082.txt -rw------- 1 catalin users 9 Sep 9 2011 Finish.log -rw------- 1 catalin users 1110 Nov 7 2007 globdata.ini -rw------- 1 catalin users 124 Dec 18 07:14 HaxLogs.log -rw------- 1 catalin users 4656574464 Dec 18 07:14 hiberfil.sys -rw------- 1 catalin users 855040 Nov 7 2007 install.exe -rw------- 1 catalin users 843 Nov 7 2007 install.ini -rw------- 2 catalin users 75280 Nov 7 2007 install.res.1028.dll -rw------- 2 catalin users 95248 Nov 7 2007 install.res.1031.dll -rw------- 2 catalin users 90128 Nov 7 2007 install.res.1033.dll -rw------- 2 catalin users 96272 Nov 7 2007 install.res.1036.dll -rw------- 2 catalin users 94224 Nov 7 2007 install.res.1040.dll -rw------- 2 catalin users 80400 Nov 7 2007 install.res.1041.dll -rw------- 2 catalin users 78864 Nov 7 2007 install.res.1042.dll -rw------- 2 catalin users 74768 Nov 7 2007 install.res.2052.dll -rw------- 2 catalin users 95248 Nov 7 2007 install.res.3082.dll drwx------ 1 catalin users 0 Sep 10 2011 Intel -rw------- 1 catalin users 2621440 Sep 26 2011 K53E.BIN -rw------- 2 catalin users 19 Jul 6 2011 K53E_WIN7.60 drwx------ 1 catalin users 8192 Aug 31 17:01 mozilla-build drwx------ 1 catalin users 0 Nov 13 2011 MSOCache -rw------- 1 catalin users 6208765952 Dec 18 07:14 pagefile.sys -rw------- 1 catalin users 303 Sep 9 2011 Pass.txt drwx------ 1 catalin users 0 Jul 14 2009 PerfLogs drwx------ 1 catalin users 4096 Mar 1 2013 Perl drwx------ 1 catalin users 12288 Nov 19 22:41 ProgramData drwx------ 1 catalin users 12288 Nov 19 13:50 Program Files drwx------ 1 catalin users 28672 Dec 18 07:26 Program Files (x86) drwx------ 1 catalin users 8192 Oct 13 11:52 Python27 drwx------ 1 catalin users 4096 Nov 25 2012 Python27-amd64 drwx------ 1 catalin users 4096 Oct 31 13:40 Python32 drwx------ 1 catalin users 4096 Nov 10 2012 Python33 drwx------ 1 catalin users 0 Nov 10 14:23 Qt drwx------ 1 catalin users 0 Nov 12 2011 Recovery -rw------- 1 catalin users 6 Jul 6 2011 RECOVERY.DAT drwx------ 1 catalin users 0 Nov 12 2011 $Recycle.Bin -rw------- 1 catalin users 2450 Sep 10 2011 RHDSetup.log drwx------ 1 catalin users 4096 Mar 1 2013 Ruby193 -rw------- 1 catalin users 168 Sep 10 2011 setup.log drwx------ 1 catalin users 20480 Dec 15 20:13 System Volume Information drwx------ 1 catalin users 0 Nov 12 2011 temp drwx------ 1 catalin users 4096 Nov 12 2011 Users -rw------- 1 catalin users 1927956 Nov 7 2007 VC_RED.cab -rw------- 1 catalin users 5686 Nov 7 2007 vcredist.bmp -rw------- 1 catalin users 242176 Nov 7 2007 VC_RED.MSI drwx------ 1 catalin users 0 Nov 23 2011 Visual Studio 9.0 -rw------- 2 catalin users 2073703 Mar 20 2010 VS_EXPBSLN_x64_enu.CAB -rw------- 2 catalin users 551424 Mar 20 2010 VS_EXPBSLN_x64_enu.MSI drwx------ 1 catalin users 40960 Dec 18 07:35 Windows Since the bootmgr file is there, with my change the Windows partition is found. I understand from previous changes that grub2-mount sometimes works better than normal mount but it's now also clear that the reverse is also true at least for some NTFS filesystems (notice how many files are missing). Probably, what should happen is both mounts should be tried: try with grub2-mount, if no OS is found retry with normal mount. I could try to implement that logic but my shell skills are quite lacking, I'm hoping somebody else will pick it up. I think this bug is serious enough to warrant an update to 13.1 (on every kernel update some users will lose their Windows boot entry). -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=803072 https://bugzilla.novell.com/show_bug.cgi?id=803072#c3 Catalin Iacob <iacobcatalin@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arvidjaar@gmail.com --- Comment #3 from Catalin Iacob <iacobcatalin@gmail.com> 2014-01-02 06:30:55 UTC --- CC-ing Andrey Borzenkov since I see he's been helping with os-prober bugs before (see comment 2). -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=803072 https://bugzilla.novell.com/show_bug.cgi?id=803072#c4 Catalin Iacob <iacobcatalin@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |markus.kossmann@gmx.de --- Comment #4 from Catalin Iacob <iacobcatalin@gmail.com> 2014-01-02 06:32:56 UTC --- *** Bug 818314 has been marked as a duplicate of this bug. *** http://bugzilla.novell.com/show_bug.cgi?id=818314 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=803072 https://bugzilla.novell.com/show_bug.cgi?id=803072#c5 Andrey Borzenkov <arvidjaar@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO InfoProvider| |iacobcatalin@gmail.com --- Comment #5 from Andrey Borzenkov <arvidjaar@gmail.com> 2014-01-02 06:54:48 UTC --- Could you attach "ls -laf" listing of Windows directory both with grub-mount and native mount? ("f" does not sort entries and displays them in on-disk order) What exact version of Windows do you have? Is it 32 bit or 64 bit? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=803072 https://bugzilla.novell.com/show_bug.cgi?id=803072#c6 --- Comment #6 from Andrey Borzenkov <arvidjaar@gmail.com> 2014-01-02 09:54:33 UTC --- @Iacob: please test updated grub2 package: zypper ar obs://home:arvidjaar:bnc:803072:13.1/standard bnc803072 zypper refresh bnc803072 zypper dup -r bnc803072 No need to reboot - just call os-prober whether it finds Windows now. If you are running 12.3 - replace 13.1 with 12.3 in URL above. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=803072 https://bugzilla.novell.com/show_bug.cgi?id=803072#c7 --- Comment #7 from Catalin Iacob <iacobcatalin@gmail.com> 2014-01-02 16:58:28 UTC --- Created an attachment (id=573160) --> (http://bugzilla.novell.com/attachment.cgi?id=573160) ls -laf with grub mount -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=803072 https://bugzilla.novell.com/show_bug.cgi?id=803072#c8 --- Comment #8 from Catalin Iacob <iacobcatalin@gmail.com> 2014-01-02 16:59:05 UTC --- Created an attachment (id=573161) --> (http://bugzilla.novell.com/attachment.cgi?id=573161) ls -laf with native mount -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=803072 https://bugzilla.novell.com/show_bug.cgi?id=803072#c9 Catalin Iacob <iacobcatalin@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |NEW InfoProvider|iacobcatalin@gmail.com | --- Comment #9 from Catalin Iacob <iacobcatalin@gmail.com> 2014-01-02 16:59:54 UTC --- (In reply to comment #5)
Could you attach "ls -laf" listing of Windows directory both with grub-mount and native mount? ("f" does not sort entries and displays them in on-disk order)
Done
What exact version of Windows do you have? Is it 32 bit or 64 bit?
Windows 7, 64bit -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=803072 https://bugzilla.novell.com/show_bug.cgi?id=803072#c10 --- Comment #10 from Catalin Iacob <iacobcatalin@gmail.com> 2014-01-02 17:01:08 UTC --- Created an attachment (id=573162) --> (http://bugzilla.novell.com/attachment.cgi?id=573162) ls -laf with fixed grub mount -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=803072 https://bugzilla.novell.com/show_bug.cgi?id=803072#c11 --- Comment #11 from Catalin Iacob <iacobcatalin@gmail.com> 2014-01-02 17:07:06 UTC --- (In reply to comment #6)
@Iacob: please test updated grub2 package:
zypper ar obs://home:arvidjaar:bnc:803072:13.1/standard bnc803072 zypper refresh bnc803072 zypper dup -r bnc803072
No need to reboot - just call os-prober whether it finds Windows now.
I've tested it and it fixes the issue for me (I'm running 13.1). Great job Andrey! As I said, I think this deserves a maintenance update. For reference, see listing with the fixed grub in comment 10: all files appear now (though Program Files (x86) gets some ???) so it makes sense that os-prober is working. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=803072 https://bugzilla.novell.com/show_bug.cgi?id=803072#c12 Andrey Borzenkov <arvidjaar@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO InfoProvider| |maintenance@opensuse.org --- Comment #12 from Andrey Borzenkov <arvidjaar@gmail.com> 2014-01-02 19:06:45 UTC --- (In reply to comment #11)
I've tested it and it fixes the issue for me (I'm running 13.1).
Good. The problem was (mis)handling of symbolic links to directories by grub-mount and Windows 7 (or was it Vista?) introduced "\Documents and Settings" as symlink to \Users. I expect this affects minority of users, because standard Windows 7 puts bootloader on separate system partition with minimal content. Anyway, @maintenance team - please review: 13.1: SR#212657 12.3: SR#212658 @Michael: for Factory I submitted 2.02 beta2 (SR#212604) which includes this fix already, so I'll hold off separate patch. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=803072 https://bugzilla.novell.com/show_bug.cgi?id=803072#c13 --- Comment #13 from Markus Koßmann <markus.kossmann@gmx.de> 2014-01-02 19:25:18 UTC --- Only a fresh installation of Windows 7 puts its bootloader in a separate system partition. On update installations from XP it doesn't create a new bootloader partition. So don't underestimate the number of users affected by this problem. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=803072 https://bugzilla.novell.com/show_bug.cgi?id=803072#c14 --- Comment #14 from Bernhard Wiedemann <bwiedemann@suse.com> 2014-01-02 21:00:12 CET --- This is an autogenerated message for OBS integration: This bug (803072) was mentioned in https://build.opensuse.org/request/show/212657 13.1 / grub2 https://build.opensuse.org/request/show/212658 12.3 / grub2 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=803072 https://bugzilla.novell.com/show_bug.cgi?id=803072#c15 --- Comment #15 from Michael Chang <mchang@suse.com> 2014-01-06 04:02:14 UTC --- (In reply to comment #12)
@Michael: for Factory I submitted 2.02 beta2 (SR#212604) which includes this fix already, so I'll hold off separate patch.
I've accepted it and forwarded to factory. Thanks for your work. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=803072 https://bugzilla.novell.com/show_bug.cgi?id=803072#c16 Marcus Meissner <meissner@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |RESOLVED CC| |meissner@suse.com InfoProvider|maintenance@opensuse.org | Resolution| |FIXED --- Comment #16 from Marcus Meissner <meissner@suse.com> 2014-01-07 10:58:49 UTC --- accepted for maintenance -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com