[Bug 1052970] New: suse-xsl-stylesheets depends on aspell
http://bugzilla.suse.com/show_bug.cgi?id=1052970 Bug ID: 1052970 Summary: suse-xsl-stylesheets depends on aspell Classification: openSUSE Product: openSUSE Tumbleweed Version: Current Hardware: Other OS: Other Status: NEW Severity: Normal Priority: P5 - None Component: Basesystem Assignee: bnc-team-screening@forge.provo.novell.com Reporter: pgajdos@suse.com QA Contact: qa-bugs@suse.de Found By: --- Blocker: --- Our management would like to remove aspell from the distro (fate#323578). We need to ensure it is not dependency of any package in Tumbleweed. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=1052970 Petr Gajdos <pgajdos@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|bnc-team-screening@forge.pr |pgajdos@suse.com |ovo.novell.com | -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=1052970 Petr Gajdos <pgajdos@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - None |P3 - Medium -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=1052970 http://bugzilla.suse.com/show_bug.cgi?id=1052970#c1 Petr Gajdos <pgajdos@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sknorr@suse.de Flags| |needinfo?(sknorr@suse.de) --- Comment #1 from Petr Gajdos <pgajdos@suse.com> --- Hello Stefan, can I ask you for help to get rid of aspell dependency? -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=1052970 http://bugzilla.suse.com/show_bug.cgi?id=1052970#c2 Stefan Knorr <sknorr@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fs@suse.com, | |sknorr@suse.com, | |thomas.schraitle@suse.com Summary|suse-xsl-stylesheets |suse-xsl-stylesheets and |depends on aspell |daps depend on aspell --- Comment #2 from Stefan Knorr <sknorr@suse.com> --- Heh, so as an explanation for this dependency: Our stylesheets for historical reasons ship a *.pws file that extends the English aspell dictionary with SUSE-specific words. This word list is used by DAPS (package "daps") subcommand called "daps spellcheck". I have wanted to remove that aspell *.pws file from suse-xsl-stylesheets for some time anyway, because a dictionary does not belong anywhere near stylesheets. However, the word list is useful to us (SUSE doc team), so I need to move that to a new package. So that would only move the issue elsewhere. The real question is what to replace the functionality in DAPS with... Is there a replacement spell checker that has the following features: 1. compatible with aspell word lists 2. interactive spell checking mode like aspell 3. ability to ignore XML tags -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=1052970 Stefan Knorr <sknorr@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pgajdos@suse.com Flags| |needinfo?(pgajdos@suse.com) -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=1052970 http://bugzilla.suse.com/show_bug.cgi?id=1052970#c3 Petr Gajdos <pgajdos@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tchvatal@suse.com Flags|needinfo?(pgajdos@suse.com) |needinfo?(tchvatal@suse.com | |) --- Comment #3 from Petr Gajdos <pgajdos@suse.com> --- (In reply to Stefan Knorr from comment #2)
The real question is what to replace the functionality in DAPS with... Is there a replacement spell checker that has the following features: 1. compatible with aspell word lists 2. interactive spell checking mode like aspell 3. ability to ignore XML tags
Unfortunately I do not know, apologize. I guess hunspell is agreed on to be a replacement. It surely has 2, but not sure about the others. Tomas, do you have idea? -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=1052970 http://bugzilla.suse.com/show_bug.cgi?id=1052970#c4 --- Comment #4 from Frank Sundermeyer <fs@suse.com> --- I am not happy with replacing aspell by hunspell as suggested in FATE #323578. aspell has much better support for HTML, XML, and TeX. Both spell checkers support these formats (by ignoring commands and tags), but aspell allows to specify certain tags/commands for TeX, XML and HTML that get checked. With this you can, for example, check alt-Tags in HTML. Aspell also lets you create your own filters, or, for HTML/XML lets you explicitly specify which tags to check and which ones to ignore. Hunspell, for example, offers no way to ignore preformatted text (such as program listings or command output) in spell checks. aspell does. As for DAPS, the usage of aspell is hardcoded (DAPS is a tool to process DocBook XML). Dropping aspell would not only mean that I would have to change DAPS' spell-checking code, it would also mean that DAPS will loose functionality for reasons mentioned above. I strongly suggest to keep aspell. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=1052970 http://bugzilla.suse.com/show_bug.cgi?id=1052970#c5 --- Comment #5 from Petr Gajdos <pgajdos@suse.com> --- I guess it would be worth to also update the fate. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=1052970 http://bugzilla.suse.com/show_bug.cgi?id=1052970#c6 Tomáš Chvátal <tchvatal@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(tchvatal@suse.com | |) | --- Comment #6 from Tomáš Chvátal <tchvatal@suse.com> --- (In reply to Frank Sundermeyer from comment #4)
I am not happy with replacing aspell by hunspell as suggested in FATE #323578.
aspell has much better support for HTML, XML, and TeX. Both spell checkers support these formats (by ignoring commands and tags), but aspell allows to specify certain tags/commands for TeX, XML and HTML that get checked. With this you can, for example, check alt-Tags in HTML.
Aspell also lets you create your own filters, or, for HTML/XML lets you explicitly specify which tags to check and which ones to ignore. Hunspell, for example, offers no way to ignore preformatted text (such as program listings or command output) in spell checks. aspell does.
As for DAPS, the usage of aspell is hardcoded (DAPS is a tool to process DocBook XML). Dropping aspell would not only mean that I would have to change DAPS' spell-checking code, it would also mean that DAPS will loose functionality for reasons mentioned above.
I strongly suggest to keep aspell.
As I said on the FATE request. I will have to dig a bit more if it is possible to specify tags. Actually, I see there is -X option in the hunspell to parse the xml input format. For the latex, I am perfectly sure it has tex mode with -t parameter (as I use it to spell check my slides :)). For the DAPS well again we have old dictionaries that are really not updated compared to myspell (hunspell) which are kept up-to-date. FWIW you can specify more dictionaries to make use of the checking using the hunspell: hunspell -d en_US -p local_whitelist -X myfile.xml I still think if something is missing then we should either implement it in hunspell or open features to get it done in future. Aspell last release is aprox 2011 and we have same version in SLE11 as in TW... -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=1052970 http://bugzilla.suse.com/show_bug.cgi?id=1052970#c7 Petr Gajdos <pgajdos@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(fs@suse.com) --- Comment #7 from Petr Gajdos <pgajdos@suse.com> --- @Stefan and Frank: As suse-xsl-stylesheets is the last hard depending on aspell, could you please consider to take over aspell? -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=1052970 http://bugzilla.suse.com/show_bug.cgi?id=1052970#c8 Frank Sundermeyer <fs@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(fs@suse.com) | --- Comment #8 from Frank Sundermeyer <fs@suse.com> --- We will turn the "Requires" for aspell into "Recommends". As for taking over the maintainership - I fear we lack the expertise to create backports of fixes for SLE 11/12+LTSS in case such a thing would be required. We will also write a wrapper script for DAPS that will allow us to choose between hunspell and aspell (https://github.com/openSUSE/daps/issues/422). -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=1052970 http://bugzilla.suse.com/show_bug.cgi?id=1052970#c9 --- Comment #9 from Petr Gajdos <pgajdos@suse.com> --- Thanks! -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=1052970 http://bugzilla.suse.com/show_bug.cgi?id=1052970#c12 --- Comment #12 from Swamp Workflow Management <swamp@suse.de> --- This is an autogenerated message for OBS integration: This bug (1052970) was mentioned in https://build.opensuse.org/request/show/576829 Factory / suse-xsl-stylesheets -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=1052970 http://bugzilla.suse.com/show_bug.cgi?id=1052970#c13 Stefan Knorr <sknorr@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(sknorr@suse.de) | --- Comment #13 from Stefan Knorr <sknorr@suse.com> --- Aspell dep has been completely removed for the stylesheets now. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=1052970 http://bugzilla.suse.com/show_bug.cgi?id=1052970#c14 Stefan Knorr <sknorr@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #14 from Stefan Knorr <sknorr@suse.com> --- -> fixed. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=1052970 http://bugzilla.suse.com/show_bug.cgi?id=1052970#c15 --- Comment #15 from Petr Gajdos <pgajdos@suse.com> --- Thanks a lot! -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=1052970 Swamp Workflow Management <swamp@suse.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Whiteboard| |maint:planned:update -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=1052970 Swamp Workflow Management <swamp@suse.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Whiteboard|maint:planned:update |maint:planned:update | |ibs:running:13396:moderate -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=1052970 http://bugzilla.suse.com/show_bug.cgi?id=1052970#c19 --- Comment #19 from Swamp Workflow Management <swamp@suse.de> --- SUSE-RU-2020:0018-1: An update that has three recommended fixes can now be installed. Category: recommended (moderate) Bug References: 1052970,1077375,1157786 CVE References: Sources used: SUSE Linux Enterprise Software Development Kit 12-SP5 (src): suse-xsl-stylesheets-2.0.15-18.4.1 SUSE Linux Enterprise Software Development Kit 12-SP4 (src): suse-xsl-stylesheets-2.0.15-18.4.1 NOTE: This line indicates an update has been released for the listed product(s). At times this might be only a partial fix. If you have questions please reach out to maintenance coordination. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=1052970 Swamp Workflow Management <swamp@suse.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Whiteboard|maint:planned:update |maint:planned:update |ibs:running:13396:moderate | -- You are receiving this mail because: You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com